[Bug 37814] New: Wrong use of __() in .tt files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Bug ID: 37814 Summary: Wrong use of __() in .tt files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org __() does not work in .tt files (only .js files) _() must be used instead The 4 occurrences returned here are wrong. % git grep '__(' **/*.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/alert-subscriptions.tt: return confirmDelete(__("Are you sure you want to unsubscribe %s from email alerts for %s?").format(patron, title)); koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: node.addClass("collapsed").removeClass("expanded").attr("title", __("Click to expand this section") ); koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: node.addClass("expanded").removeClass("collapsed").attr("title", __("Click to collapse this section") ); koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt: return confirmDelete(__("Are you sure you want to unsubscribe %s from email alerts for %s?").format(patron, title)); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28130 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 [Bug 35511] Add visual indicators of patron edit form collapsible sections -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170981&action=edit Bug 37814: Fix incorrect use of __() in .tt files This patch corrects instances of the double-underscore function being used in .tt files where the single-underscore function should be used instead. To test, apply the patch and update a translation, e.g. fr-FR:
gulp po:update --lang fr-FR
- Open the corresponding .po file for the affected strings, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the strings are now in the .po file for translation. You should find these lines: - koha-tmpl/intranet-tmpl/prog/en/modules/members/alert-subscriptions.tt: "Are you sure you want to unsubscribe %s from email alerts for %s?" - koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt "Click to expand this section" - Check fr-FR-opac-bootstrap.po for this line: - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt: "Are you sure you want to unsubscribe %s from email alerts for %s?" Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170981|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170989&action=edit Bug 37814: Fix incorrect use of __() in .tt files This patch corrects instances of the double-underscore function being used in .tt files where the single-underscore function should be used instead. To test, apply the patch and update a translation, e.g. fr-FR:
gulp po:update --lang fr-FR
- Open the corresponding .po file for the affected strings, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the strings are now in the .po file for translation. You should find these lines: - koha-tmpl/intranet-tmpl/prog/en/modules/members/alert-subscriptions.tt: "Are you sure you want to unsubscribe %s from email alerts for %s?" - koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt "Click to expand this section" - Check fr-FR-opac-bootstrap.po for this line: - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt: "Are you sure you want to unsubscribe %s from email alerts for %s?" Sponsored-by: Athens County Public Libraries Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |f.demians@tamil.fr, | |jonathan.druart@gmail.com Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org Component|Templates |I18N/L10N --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for these! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrong use of __() in .tt |Wrong use of '__()' in .tt |files |files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 Code in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt does not exists so only impacted : koha-tmpl/intranet-tmpl/prog/en/modules/members/alert-subscriptions.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Version|unspecified |Main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Bug 37814 depends on bug 28130, which changed state. Bug 28130 Summary: Show list of serial email alerts a patron subscribed to in patron account in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org