[Bug 31791] New: Add the ability to lock records to prevent modification through the Koha staff interface(s).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Bug ID: 31791 Summary: Add the ability to lock records to prevent modification through the Koha staff interface(s). Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl - Add a read-only field - The read-only field will only be editable by superlibrarian - Koha can update these internally for related routines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, could you share some details about the use cases for this one? As we usually don't give superlibrarian permissions to users, could this be tied to a new permission maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #1)
Hi Nick, could you share some details about the use cases for this one? As we usually don't give superlibrarian permissions to users, could this be tied to a new permission maybe?
We also talked about a new permission, that should not be a problem. The idea here is really the ability to lock records from certain sources - in this case the library will be cataloging in an external system and pushing records in to Koha. They do not wish for these records to be edited within Koha, so want to protect them - with a limited set of users being able to edit them if the need arises. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah! That makes a lot of sense and could be useful in our use case as well. Are you thinking of some kind of automatism to set the locked maybe on import too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen@gmail.com |agustinmoyano@theke.io -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #3)
Are you thinking of some kind of automatism to set the locked maybe on import too?
On the API front, this will be a flag to be passed, with (probably) some default for each source i.e. there will be an 'Import sources' crud page, to set this things. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 [Bug 32607] Add import sources crud -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- +1 I would like to see this functionality. There's a number of times we import data from other systems into Koha, and the place to correct that data is upstream, so it would flow into Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 [Bug 20256] Add ability to limit editing of items to home library or library group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- This should probably be based on ( or at least informed by ) bug 20256 which does a fair amount of refactoring. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add the ability to lock |Add the ability to lock |records to prevent |records to prevent |modification through the |modification through the |Koha staff interface(s). |Koha staff interface(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Bug 31791 depends on bug 32607, which changed state. Bug 32607 Summary: Add record sources CRUD https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 [Bug 35919] Add record sources CRUD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|agustinmoyano@theke.io |tomascohen@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32607 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 [Bug 32607] Add record sources CRUD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163371&action=edit Bug 35919: Add Koha::Biblio::Metadata->source_allows_editing This patch adds a convenient method that tells if the record is editable, according to it's record source. To test: 1. Apply this patch 2. Run: $ ktd k$ prove t/db_dependent/Koha/Biblio/Metadata.t => SUCCESS: Tests pass! Use cases covered! 3. Sign off :-D Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Bug 31791: Rename can_be_edited -> source_allows_editing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163372&action=edit Bug 31791: DB changes Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163373&action=edit Bug 31791: Add TT plugin method Biblio.CanBeEdited Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163374&action=edit Bug 31791: Add record locking based on source Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163375&action=edit Bug 31791: Add edit_locked_records and set_record_sources subpermissions Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163376&action=edit Bug 31791: Limit editing locked records Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163377&action=edit Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc) Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163378&action=edit Bug 31791: Add x-record-source-id header to POST /biblios This patch adds support for setting the record source on the API. It does so by adding support for a new header `x-record-source-id`. Setting the record source is restricted to patrons with the `set_record_sources` permission. A 403 error is returned on an attempt to set it without the correct permissions. The feature is documented on the spec. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! Tests cover the right use cases! 3. Play with Postman (or similar) 4. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
UPDATE biblio_metadata SET record_source_id=<A's ID> WHERE biblionumber=<chosen record>;
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The submitted patches implement the requested feature, paired with the 'record sources' feature. Test plan: 1. Have bug 35919 applied 2. Apply this patchset 3. Create 2 'Record sources' in the Administration section * Record source A having edition disabled * Record source B having edition enabled Take notes on the record source ID for each. 4. Create a valid staff member (known user and pass) 5. Have the user set the following permissions: - catalogue (staff access) - editcatalogue => all subpermissions bug `edit_locked_records` 6. Login with the user on a private/incognito browser 7. Pick a record and browse to it on the private browser => SUCCESS: You can edit it 8. Make the record source for the chosen record be A: $ koha-mysql kohadev 9. Refresh the private window => SUCCESS: You are redirected to an error page 10. Search for the chosen record 11. Try to edit it => SUCCESS: The 'Edit record' link is greyed and cannot be used => SUCCESS: The greyed text has a tooltip explaining what's going on 12. Either change the record source to B, or just edit the record source A to allow editing 13. Refresh the record detail page => SUCCESS: The 'Edit record' link is no longer greyed, and the record can be edited => SUCCESS: Record edition is limited by source configuration 14. Verify superlibrarians can always edit such records Note: the only way to set the record source for now is the API, which is extensively tested on the provided tests (t/db_dependent/api/v1/biblios.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163371|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163372|0 |1 is obsolete| | Attachment #163373|0 |1 is obsolete| | Attachment #163374|0 |1 is obsolete| | Attachment #163375|0 |1 is obsolete| | Attachment #163376|0 |1 is obsolete| | Attachment #163377|0 |1 is obsolete| | Attachment #163378|0 |1 is obsolete| | --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163405&action=edit Bug 31791: Add Koha::Biblio->can_be_edited Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163408&action=edit Bug 31791: DB changes Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163410&action=edit Bug 31791: Add TT plugin method Biblio.CanBeEdited Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163411&action=edit Bug 31791: Add record locking based on source Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163413&action=edit Bug 31791: Add edit_locked_records and set_record_sources subpermissions Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163414&action=edit Bug 31791: Limit editing locked records Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163415&action=edit Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc) Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163416&action=edit Bug 31791: Add x-record-source-id header to POST /biblios This patch adds support for setting the record source on the API. It does so by adding support for a new header `x-record-source-id`. Setting the record source is restricted to patrons with the `set_record_sources` permission. A 403 error is returned on an attempt to set it without the correct permissions. The feature is documented on the spec. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! Tests cover the right use cases! 3. Play with Postman (or similar) 4. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163405|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163426&action=edit Bug 31791: Add Koha::Biblio->can_be_edited Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163408|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163427&action=edit Bug 31791: DB changes Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163410|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163428&action=edit Bug 31791: Add TT plugin method Biblio.CanBeEdited Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163411|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163429&action=edit Bug 31791: Add record locking based on source Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163413|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163430&action=edit Bug 31791: Add edit_locked_records and set_record_sources subpermissions Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163414|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163431&action=edit Bug 31791: Limit editing locked records Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163415|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163432&action=edit Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc) Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163416|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163433&action=edit Bug 31791: Add x-record-source-id header to POST /biblios This patch adds support for setting the record source on the API. It does so by adding support for a new header `x-record-source-id`. Setting the record source is restricted to patrons with the `set_record_sources` permission. A 403 error is returned on an attempt to set it without the correct permissions. The feature is documented on the spec. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! Tests cover the right use cases! 3. Play with Postman (or similar) 4. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163434&action=edit Bug 31791: Remove CanBeEdited template helper We've opted to rely on the objects directly in templates whenever we can now. As such, I opt to remove this new template helper and use the object method directly instead. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All working great.. I added a small follow-up to remove the CanBeEdited helper as we can just use the object methods directly in the templates. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- PS. We can squash my follow-up btw.. it'll throw git manipulation errors in the QA scripts as it stands.. though I tend to like the extra info of a commit myself.. but that's personal preference.. I know others prefer less commits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163426|0 |1 is obsolete| | Attachment #163427|0 |1 is obsolete| | Attachment #163428|0 |1 is obsolete| | Attachment #163429|0 |1 is obsolete| | Attachment #163430|0 |1 is obsolete| | Attachment #163431|0 |1 is obsolete| | Attachment #163432|0 |1 is obsolete| | Attachment #163433|0 |1 is obsolete| | Attachment #163434|0 |1 is obsolete| | --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163531&action=edit Bug 31791: Add Koha::Biblio->can_be_edited Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163532&action=edit Bug 31791: DB changes Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163533&action=edit Bug 31791: Add record locking based on source Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #38 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163534&action=edit Bug 31791: Add edit_locked_records and set_record_sources subpermissions Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163535&action=edit Bug 31791: Limit editing locked records Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163536&action=edit Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc) Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163537&action=edit Bug 31791: Add x-record-source-id header to POST /biblios This patch adds support for setting the record source on the API. It does so by adding support for a new header `x-record-source-id`. Setting the record source is restricted to patrons with the `set_record_sources` permission. A 403 error is returned on an attempt to set it without the correct permissions. The feature is documented on the spec. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! Tests cover the right use cases! 3. Play with Postman (or similar) 4. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #42 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163538&action=edit Bug 31791: Add Koha::Biblio::Metadata->record_source This patch adds a method for retrieving the related *Koha::RecordSource* from a *Koha::Biblio::Metadata* object. The method is covered by tests: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Biblio/Metadata.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #43 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163539&action=edit Bug 31791: Display record source on the detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36372 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 [Bug 36372] Allow privileged users to set the 'record source' on cataloguing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #33)
All working great.. I added a small follow-up to remove the CanBeEdited helper as we can just use the object methods directly in the templates.
Oh, an oversight of mine. I had written this code before that decision was made! (In reply to Martin Renvoize from comment #34)
PS. We can squash my follow-up btw
Done! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #45 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I wanted to note that theres a 'tidy' warning regarding the C4::Biblio changes. They would only go away by tidying the entire sub, as the problem is my patch is adding lines to a fully untidy block. I'll submit a follow-up for tidying it all, but I wouldn't push it myself. Up to the RM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #46 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163545&action=edit Bug 31791: (follow-up) Tidy AddBiblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163536|0 |1 is obsolete| | Attachment #163537|0 |1 is obsolete| | Attachment #163538|0 |1 is obsolete| | Attachment #163539|0 |1 is obsolete| | Attachment #163545|0 |1 is obsolete| | --- Comment #47 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164193&action=edit Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc) Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164194&action=edit Bug 31791: Add x-record-source-id header to POST /biblios This patch adds support for setting the record source on the API. It does so by adding support for a new header `x-record-source-id`. Setting the record source is restricted to patrons with the `set_record_sources` permission. A 403 error is returned on an attempt to set it without the correct permissions. The feature is documented on the spec. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! Tests cover the right use cases! 3. Play with Postman (or similar) 4. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #49 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164195&action=edit Bug 31791: Add Koha::Biblio::Metadata->record_source This patch adds a method for retrieving the related *Koha::RecordSource* from a *Koha::Biblio::Metadata* object. The method is covered by tests: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Biblio/Metadata.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #50 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164196&action=edit Bug 31791: Display record source on the detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #51 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164197&action=edit Bug 31791: (follow-up) Tidy AddBiblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34943 --- Comment #52 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Rebased on top of bug 34943, currently in master. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 [Bug 34943] Add a pre-save plugin hook for biblios -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23705 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31109 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163531|0 |1 is obsolete| | --- Comment #53 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164696&action=edit Bug 31791: Add Koha::Biblio->can_be_edited Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163532|0 |1 is obsolete| | --- Comment #54 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164697&action=edit Bug 31791: DB changes Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163533|0 |1 is obsolete| | --- Comment #55 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164698&action=edit Bug 31791: Add record locking based on source Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163534|0 |1 is obsolete| | --- Comment #56 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164699&action=edit Bug 31791: Add edit_locked_records and set_record_sources subpermissions Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163535|0 |1 is obsolete| | --- Comment #57 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164700&action=edit Bug 31791: Limit editing locked records Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164193|0 |1 is obsolete| | --- Comment #58 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164701&action=edit Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc) Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164194|0 |1 is obsolete| | --- Comment #59 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164702&action=edit Bug 31791: Add x-record-source-id header to POST /biblios This patch adds support for setting the record source on the API. It does so by adding support for a new header `x-record-source-id`. Setting the record source is restricted to patrons with the `set_record_sources` permission. A 403 error is returned on an attempt to set it without the correct permissions. The feature is documented on the spec. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! Tests cover the right use cases! 3. Play with Postman (or similar) 4. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164195|0 |1 is obsolete| | --- Comment #60 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164703&action=edit Bug 31791: Add Koha::Biblio::Metadata->record_source This patch adds a method for retrieving the related *Koha::RecordSource* from a *Koha::Biblio::Metadata* object. The method is covered by tests: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Biblio/Metadata.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164196|0 |1 is obsolete| | --- Comment #61 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164704&action=edit Bug 31791: Display record source on the detail view Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164197|0 |1 is obsolete| | --- Comment #62 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164705&action=edit Bug 31791: (follow-up) Tidy AddBiblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Upgrading my SO to a QA.. I've thoroughly tested again, QA scripts are happy and tests coverage is good. I can see lots of refinements for the future I'll add as bugs now. Great work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164696|0 |1 is obsolete| | --- Comment #64 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 165044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165044&action=edit Bug 31791: Add Koha::Biblio->can_be_edited Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164697|0 |1 is obsolete| | --- Comment #65 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 165045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165045&action=edit Bug 31791: DB changes Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164698|0 |1 is obsolete| | --- Comment #66 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 165046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165046&action=edit Bug 31791: Add record locking based on source Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164699|0 |1 is obsolete| | --- Comment #67 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 165047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165047&action=edit Bug 31791: Add edit_locked_records and set_record_sources subpermissions Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164700|0 |1 is obsolete| | --- Comment #68 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 165048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165048&action=edit Bug 31791: Limit editing locked records Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164701|0 |1 is obsolete| | --- Comment #69 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 165049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165049&action=edit Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc) Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164702|0 |1 is obsolete| | --- Comment #70 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 165050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165050&action=edit Bug 31791: Add x-record-source-id header to POST /biblios This patch adds support for setting the record source on the API. It does so by adding support for a new header `x-record-source-id`. Setting the record source is restricted to patrons with the `set_record_sources` permission. A 403 error is returned on an attempt to set it without the correct permissions. The feature is documented on the spec. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! Tests cover the right use cases! 3. Play with Postman (or similar) 4. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164703|0 |1 is obsolete| | --- Comment #71 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 165051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165051&action=edit Bug 31791: Add Koha::Biblio::Metadata->record_source This patch adds a method for retrieving the related *Koha::RecordSource* from a *Koha::Biblio::Metadata* object. The method is covered by tests: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Biblio/Metadata.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164704|0 |1 is obsolete| | --- Comment #72 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 165052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165052&action=edit Bug 31791: Display record source on the detail view Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164705|0 |1 is obsolete| | --- Comment #73 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 165053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165053&action=edit Bug 31791: (follow-up) Tidy AddBiblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #74 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Added my signoff, this is very good work and we have a use case for this. Would be nice to have some interface to change the record source from staff interface but there is an attached bug for that (bz36372) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add the ability to lock |Add the ability to lock |records to prevent |records to prevent |modification through the |modification through the |Koha staff interface(s) |Koha staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If I understand correctly, this patch set makes the record locks work, but they still need to be set in the database or by API. I am mostly OK with that, but we also add a permission for "Set record source" and this doesn't seem to be included yet. Maybe we should comment/remove it for now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Talked to Tomas: we will try to finish bug 36373. If we don't manage in time for 24.05, we can add a little note to the permission that it's only relevant for API users for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #78 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 165697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165697&action=edit Bug 31791: (follow-up) Fix Permissions.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36786 [Bug 36786] (Bug 31791 follow-up) Koha explodes when trying to edit a biblio with invalid biblionumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36884 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36884 [Bug 36884] Make it possible to use the record_source as a criteria for a search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #79 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd really like some release notes for this one as it's not so self explanatory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This feature adds a way to release notes| |lock records from being | |manually edited, if their | |defined source is marked as | |such. | | | |The record source | |can only be set (so far) | |when adding records using | |the API (or a dedicated | |plugin using the new code). | |A future enhancement (bug | |36372) will allow | |privileged users to set the | |record source manually, as | |well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36975 [Bug 36975] Allow MarcModificationTemplates to change the record source for a batch of records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #81 from David Nind <david@davidnind.com> --- There is a query on the mailing list about how to use this new feature: https://lists.katipo.co.nz/pipermail/koha/2024-June/060730.html I've had a crack at responding, but if I've not got it right could someone involved provide some more information? Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #82 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Nind from comment #81)
There is a query on the mailing list about how to use this new feature: https://lists.katipo.co.nz/pipermail/koha/2024-June/060730.html
I've had a crack at responding, but if I've not got it right could someone involved provide some more information?
Thanks.
I'm not seeing the email on my inbox! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #82)
(In reply to David Nind from comment #81)
There is a query on the mailing list about how to use this new feature: https://lists.katipo.co.nz/pipermail/koha/2024-June/060730.html
I've had a crack at responding, but if I've not got it right could someone involved provide some more information?
Thanks.
I'm not seeing the email on my inbox!
I've received both of them - maybe a problem with spam? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37258 [Bug 37258] Locked records can still be modified/deleted by an unauthorized librarian with merge and in advanced editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Bug 31791 depends on bug 35919, which changed state. Bug 35919 Summary: Add record sources CRUD https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/887 Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #84 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I did my best to understand and describe this new feature (along with bug 35919). Please see the merge request and let me know if I what I wrote is wrong! https://gitlab.com/koha-community/koha-manual/-/merge_requests/887 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net --- Comment #85 from Miranda Nero <mnero@oslri.net> --- Is this automatic when using the API or do we have to turn it on? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #86 from David Nind <david@davidnind.com> --- (In reply to Miranda Nero from comment #85)
Is this automatic when using the API or do we have to turn it on?
You have to add a record source in the administration area, I think: https://koha-community.org/manual/latest/en/html/administration.html#record-... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #87 from Miranda Nero <mnero@oslri.net> --- (In reply to David Nind from comment #86)
(In reply to Miranda Nero from comment #85)
Is this automatic when using the API or do we have to turn it on?
You have to add a record source in the administration area, I think: https://koha-community.org/manual/latest/en/html/administration.html#record- sources-label
Okay thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|37258 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37258 [Bug 37258] Locked records can still be modified/deleted by an unauthorized librarian with merge and in advanced editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37258 [Bug 37258] Locked records can still be modified/deleted by an unauthorized librarian with merge and in advanced editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|37258 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37258 [Bug 37258] Locked records can still be modified/deleted by an unauthorized librarian with merge and in advanced editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 [Bug 42625] Allow records to be locked for editing based on library & group -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org