[Bug 27827] New: The Authority type input field for new authority types should be wider
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Bug ID: 27827 Summary: The Authority type input field for new authority types should be wider Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: a.roussos@dataly.gr QA Contact: testopia@bugs.koha-community.org Created attachment 117470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117470&action=edit The 'Authority type:' input field is too narrow When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents (please see the attached screenshot). This, IMHO, is a nuisance, so I'm choosing a Severity of 'minor' for this bug ("The component mostly works, but causes some irritation to users."). I suggest we increase the 'size' property of the HTML input element from 10 to 20 in order to make it twice as wide (thus allowing even the widest of entries to be displayed in their entirety without any scrolling) while the 'maxlength' property will remain at its current value of 10 since the max. number of characters allowed for an authtype in the database is 10. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |a.roussos@dataly.gr Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 --- Comment #1 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 117471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117471&action=edit Bug 27827: make the 'Authority type:' input field wider When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents. This patch fixes that. Test plan: 1) Try to add a new authority type with name "OOP_CORPUS". Notice how the input field is too narrow and cannot contain the entire string. 2) Apply this patch. 3) Repeat step 1), this time the input field has been widened and can accommodate the entire string. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117471|0 |1 is obsolete| | --- Comment #2 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 117474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117474&action=edit Bug 27827: make the 'Authority type:' input field wider When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents. This patch fixes that. Test plan: 1) Try to add a new authority type with name "OOP_CORPUS". Notice how the input field is too narrow and cannot contain the entire string. 2) Apply this patch. 3) Repeat step 1), this time the input field has been widened and can accommodate the entire string. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The Authority type input |Authority type input field |field for new authority |for new authority types |types should be wider |should be wider -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For me the 10 character strings fits exactly into the input box. Could there be a difference in how different browsers and browser settings influence this? I am not sure we have a guideline about this kind of thing, but it seems also confusing to have a much longer field that stops you from entering more than 10 characters. Adding Owen to see if there is a general guideline we could follow here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Testing with Firefox on macOS I see exactly what is in the screeshot. I think it's a problem especially when using all capital letters. I'm inclined to go with the proposed solution. I think the confusion about the max length could be mitigated by a hint: <div class="hint">10 characters maximum</div> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Interesting! Using Firefox on Linux, but it looked quite different. I am fine with Owen's suggestion. Could you add the hint? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 --- Comment #6 from Andreas Roussos <a.roussos@dataly.gr> --- Thank you both Katrin and Owen for your feedback. I'll add a follow-up patch for the hint ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 --- Comment #7 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 118741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118741&action=edit Bug 27827: (follow-up) add a hint for clarification When adding a new authority type, there is no indication of how big the authority type code can be (auth_types.authtypecode in the DB has a maximum length of 10 characters). This patch fixes that. To test, apply the patch and notice the hint appearing right above the "Authority type:" text box as you add a new authority type: it should display "10 characters maximum" in grey colour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117474|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 119115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119115&action=edit Bug 27827: make the 'Authority type:' input field wider When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents. This patch fixes that. Test plan: 1) Try to add a new authority type with name "OOP_CORPUS". Notice how the input field is too narrow and cannot contain the entire string. 2) Apply this patch. 3) Repeat step 1), this time the input field has been widened and can accommodate the entire string. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118741|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 119116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119116&action=edit Bug 27827: (follow-up) add a hint for clarification When adding a new authority type, there is no indication of how big the authority type code can be (auth_types.authtypecode in the DB has a maximum length of 10 characters). This patch fixes that. To test, apply the patch and notice the hint appearing right above the "Authority type:" text box as you add a new authority type: it should display "10 characters maximum" in grey colour. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119115|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119746&action=edit Bug 27827: make the 'Authority type:' input field wider When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents. This patch fixes that. Test plan: 1) Try to add a new authority type with name "OOP_CORPUS". Notice how the input field is too narrow and cannot contain the entire string. 2) Apply this patch. 3) Repeat step 1), this time the input field has been widened and can accommodate the entire string. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119116|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119747&action=edit Bug 27827: (follow-up) add a hint for clarification When adding a new authority type, there is no indication of how big the authority type code can be (auth_types.authtypecode in the DB has a maximum length of 10 characters). This patch fixes that. To test, apply the patch and notice the hint appearing right above the "Authority type:" text box as you add a new authority type: it should display "10 characters maximum" in grey colour. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in| | CC| |andrew@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org