[Bug 6201] New: BibTeX export does not incude MARC21 main entry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Bug #: 6201 Summary: BibTeX export does not incude MARC21 main entry Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: MARC Bibliographic data support AssignedTo: gmcharlt@gmail.com ReportedBy: jcamins@cpbibliography.com QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com The BibTeX export does not include 1xx fields when exporting MARC21 records because GetMarcAuthors only retrieves 7xx authors. 1xx fields should be included. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Stefano Bargioni <bargioni@pusc.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bargioni@pusc.it -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9274 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This bug is still present in master as of 3.12 beta1 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |philippe.blouin@inlibro.com Assignee|gmcharlt@gmail.com |eric.begin@inLibro.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 --- Comment #2 from Blou <philippe.blouin@inlibro.com> --- Created attachment 21503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21503&action=edit BibTeX export now includes MARC21 main entry -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 --- Comment #3 from Blou <philippe.blouin@inlibro.com> --- Patch attached -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Eric Bégin <eric.begin@inLibro.com> --- How to test : - Search any books in the OPAC with a main entry (1XX in MARC21, 700-720 in Unimarc) - Export the record in the bibtex format » The output won't contains the main entry. ---- Apply the patch - Export the record The output file will contain the main entry -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21503|0 |1 is obsolete| | --- Comment #5 from Blou <philippe.blouin@inlibro.com> --- Created attachment 21504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21504&action=edit Fix marc2bibtex to consider fields 1xx on author. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 --- Comment #6 from Eric Bégin <eric.begin@inLibro.com> --- Sponsored-by: Institut universitaire en santé mentale de Montréal -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21504|0 |1 is obsolete| | --- Comment #7 from Blou <philippe.blouin@inlibro.com> --- Created attachment 21511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21511&action=edit Add fields 1xxx to marc2bibtex Amended the last commit message to follow the standards. Redid the patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21511|0 |1 is obsolete| | --- Comment #8 from Blou <philippe.blouin@inlibro.com> --- Created attachment 21525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21525&action=edit Add fields 1xxx to marc2bibtex -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #9 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21525|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 21571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21571&action=edit Bug 6201 - Add fields 1xx to marc2bibtex Modified Record::marc2bibtex to varlidate fields 100,110 and 111 in non-Unimarc flavours. Test plan: 1)Search any books in the OPAC with a main entry (1XX in MARC21, 700-720 in Unimarc) 2)Export the record in the bibtex format ==>The output won't contains the main entry. 3)Apply the patch \n4)Export the record ==>The record will contain the main entry Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 21571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21571 Bug 6201 - Add fields 1xx to marc2bibtex Review of attachment 21571: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6201&attachment=21571) ----------------------------------------------------------------- ::: C4/Record.pm @@ +668,2 @@
} $author = join ' and ', @texauthors;
This is an old line, but also a bug. We should never hardcode English strings in Perl modules. Never ever. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10972 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21571|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21604&action=edit [PASSED QA] Bug 6201 - Add fields 1xx to marc2bibtex Modified Record::marc2bibtex to varlidate fields 100,110 and 111 in non-Unimarc flavours. Test plan: 1)Search any books in the OPAC with a main entry (1XX in MARC21, 700-720 in Unimarc) 2)Export the record in the bibtex format ==>The output won't contains the main entry. 3)Apply the patch 4)Export the record ==>The record will contain the main entry Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes a long standing bug. Passes all tests and QA script. Tested with multiple records, seems to work well. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 --- Comment #13 from Eric Bégin <eric.begin@inLibro.com> ---
$author = join ' and ', @texauthors;
This is an old line, but also a bug. We should never hardcode English strings in Perl modules. Never ever.
From what I know, the 'and' is part of the bibtex standard and is language agnostic.
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, weird format:) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Philippe! Also, looks like this is your first patch accepted into Koha. Congratulations! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Philippe and congratulations! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org