[Bug 17836] New: (ILSDI) 'charges' always '1'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 Bug ID: 17836 Summary: (ILSDI) 'charges' always '1' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Due to a typo, the 'charges' attribute will always return 1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 58568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58568&action=edit Bug 17836: (ILSDI) Regression test Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 58569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58569&action=edit Bug 17836: (ILSDI) Make GetPatronInfo fill 'charges' correctly This trivial fix corrects a typo on C4/ILSDI/Services.pm. It was hidden because the tests for ILSDI only cover the 'attributes' portion of the response. I added regression tests for this. To test: - Have the regression test patch applied - Run: $ prove t/db_dependent/ILSDI_Services.t => FAIL: Tests fail because 'charges' is always set to 1 - Apply the patch - Run: $ prove t/db_dependent/ILSDI_Services.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 58569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58569 Bug 17836: (ILSDI) Make GetPatronInfo fill 'charges' correctly Review of attachment 58569: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17836&attachment=58569) ----------------------------------------------------------------- ::: C4/ILSDI/Services.pm @@ -376,4 @@
# Cleaning the borrower hashref my $flags = C4::Members::patronflags( $borrower ); - $borrower->{'charges'} = $flags>{'CHARGES'}->{'amount'};
OH MY! What a horrid typo. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58568|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58574&action=edit Bug 17836: (ILSDI) Regression test Sponsored-by: ByWater Solutions Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58569|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58575&action=edit Bug 17836: (ILSDI) Make GetPatronInfo fill 'charges' correctly This trivial fix corrects a typo on C4/ILSDI/Services.pm. It was hidden because the tests for ILSDI only cover the 'attributes' portion of the response. I added regression tests for this. To test: - Have the regression test patch applied - Run: $ prove t/db_dependent/ILSDI_Services.t => FAIL: Tests fail because 'charges' is always set to 1 - Apply the patch - Run: $ prove t/db_dependent/ILSDI_Services.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Signed Off --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Followed test plan in comment #5 and also ran koha-qa test tools. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to M. Tompsett from comment #3)
Comment on attachment 58569 [details] [review] Bug 17836: (ILSDI) Make GetPatronInfo fill 'charges' correctly
Review of attachment 58569 [details] [review]: -----------------------------------------------------------------
::: C4/ILSDI/Services.pm @@ -376,4 @@
# Cleaning the borrower hashref my $flags = C4::Members::patronflags( $borrower ); - $borrower->{'charges'} = $flags>{'CHARGES'}->{'amount'};
OH MY! What a horrid typo.
This should have been cough by our test suite, but we haven't reached ILSID yet in our attempt to improve coverage. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58575|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 58981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58981&action=edit Bug 17836: (ILSDI) Make GetPatronInfo fill 'charges' correctly This trivial fix corrects a typo on C4/ILSDI/Services.pm. It was hidden because the tests for ILSDI only cover the 'attributes' portion of the response. I added regression tests for this. To test: - Have the regression test patch applied - Run: $ prove t/db_dependent/ILSDI_Services.t => FAIL: Tests fail because 'charges' is always set to 1 - Apply the patch - Run: $ prove t/db_dependent/ILSDI_Services.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58574|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 58982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58982&action=edit Bug 17836: (ILSDI) Regression test Sponsored-by: ByWater Solutions Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Error doesn't exist in 16.11.x - it looks like it has been introduced by http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=41493004f69c... which was after the release of 16.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org