[Bug 27746] New: Use of uninitialized value $oclc in pattern match (m//) error at C4/Koha.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 Bug ID: 27746 Summary: Use of uninitialized value $oclc in pattern match (m//) error at C4/Koha.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Searching Assignee: stalkernoid@gmail.com Reporter: stalkernoid@gmail.com QA Contact: testopia@bugs.koha-community.org CC: nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 117139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117139&action=edit Bug 27746: prevent regexp undefined warning when checking subfield contents ($oclc) Some of the books have subfield "a" of field "035" absent and it's possible to have such (it doesn't says "Require" in the interface), which causes "Use of uninitialized value $oclc in pattern match (m//)" error. Solved by screening regex with check for empty variables before the match. To reproduce: 1) Edit existing book or create a new one with empty marc subfield "a" of field "035" 2) Use the search feature that will find it along with some other books. 3) Check /var/log/koha/kohadev/plack-intranet-error.log to find "Use of uninitialized value $oclc in pattern match (m//)" error. 4) Apply the patch. 5) Repeat the search and check the logs again to ensure that error didn't appear again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117139|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 119144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119144&action=edit Bug 27746: prevent regexp undefined warning when checking subfield contents ($oclc) Some of the books have subfield "a" of field "035" absent and it's possible to have such (it doesn't says "Require" in the interface), which causes "Use of uninitialized value $oclc in pattern match (m//)" error. Solved by screening regex with check for empty variables before the match. To reproduce: 1) Edit existing book or create a new one with empty marc subfield "a" of field "035" 2) Use the search feature that will find it along with some other books. 3) Check /var/log/koha/kohadev/plack-intranet-error.log to find "Use of uninitialized value $oclc in pattern match (m//)" error. 4) Apply the patch. 5) Repeat the search and check the logs again to ensure that error didn't appear again. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119144|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119555&action=edit Bug 27746: prevent regexp undefined warning when checking subfield contents ($oclc) Some of the books have subfield "a" of field "035" absent and it's possible to have such (it doesn't says "Require" in the interface), which causes "Use of uninitialized value $oclc in pattern match (m//)" error. Solved by screening regex with check for empty variables before the match. To reproduce: 1) Edit existing book or create a new one with empty marc subfield "a" of field "035" 2) Use the search feature that will find it along with some other books. 3) Check /var/log/koha/kohadev/plack-intranet-error.log to find "Use of uninitialized value $oclc in pattern match (m//)" error. 4) Apply the patch. 5) Repeat the search and check the logs again to ensure that error didn't appear again. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.05 |21.05.00,20.11.05,20.05.11 released in| | CC| |andrew@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25790 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org