[Bug 9452] New: C4::Letters does not function under Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Bug ID: 9452 Summary: C4::Letters does not function under Plack Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jcamins@cpbibliography.com There are module-level variables in C4::Letters which cause problems with Plack installations. I haven't tracked down why, but there is also a db handle getting cached, resulting in: DBD::mysql::st execute failed: MySQL server has gone away at /home/jcamins/kohaclone/C4/Letters.pm line 546. at /home/jcamins/kohaclone/circ/circulation.pl line 747 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I am upgrading this to blocker, since we have been advertising Plack-compatibility since 3.10. I understand some people are running Plack on the staff client in production. I would greatly appreciate it if those people would consider submitting a patch fixing this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Jared, Could you provide a way to reproduce the error please? Line numbers are changed and I don't know if I search at the right place :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #3 from Colin Campbell <colin.campbell@ptfs-europe.com> --- The location of the problem generating the state db handles was identified on bug 9138 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 18100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18100&action=edit Bug 9452: C4::Letters not Plack-compatible Prior to this patch, at more-or-less random intervals pages working with notices will cease to function. To test: 1) Apply patch. 2) Try to edit some notices. 3) Trigger some notices. 4) If you were able to edit the notices and trigger the notices, sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I do not have any technique for consistently reproducing these errors. 75% of the time notices are not generated and/or I am unable to save changes to notices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18100|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18230&action=edit [PASSED QA] Bug 9452: C4::Letters not Plack-compatible Prior to this patch, at more-or-less random intervals pages working with notices will cease to function. To test: 1) Apply patch. 2) Try to edit some notices. 3) Trigger some notices. 4) If you were able to edit the notices and trigger the notices, sign off. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. I did a regression script without Plack: - edit, add, delete and copy notice - trigger checkout/checkin notice - print issueslip No problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- This patch has made it difficult to create test cases where letter-table needs to be rapidly rebuilt. There is no way to invalidate the "our %letter" -cache, other than by calling %C4::Letters::letter = (); Which is quite hacky! This commit leads to VERY hard to debug problems! To fix this, the whole CRUD-mechanism for letter-handling needs to change. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org