[Bug 8525] New: Highlight matches on details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Priority: P5 - low Change sponsored?: Sponsored Bug ID: 8525 Assignee: jcamins@cpbibliography.com Summary: Highlight matches on details page Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha After doing a search and going to the details page, it can sometimes be difficult to see exactly *why* a record was returned by a search. It would be very useful to highlight the matches on the details page in the same way we highlight them on the results page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11210&action=edit Bug 8525: highlight matches on OPAC detail page After doing a search and going to the details page, it can sometimes be difficult to see exactly *why* a record was returned by a search. By highlighting matches on the detail page as well as the results page, we make it much easier to figure that out. This patch uses a query_desc CGI parameter which is inserted into links from the results page with javascript. This serves to avoid the potential privacy implications of a cookie, and ensures that users without javascript enabled see no change whatsoever. To test: 1) Do a search (or two) in the OPAC with OpacHighlightedWords on. 2) View a record or two of the results, and ensure that the correct words are highlighted. 3) Disable OpacHighlightedWords and do another search (or two), this time ensuring that no words are highlighted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11210|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11328&action=edit Bug 8525: highlight matches on OPAC detail page After doing a search and going to the details page, it can sometimes be difficult to see exactly *why* a record was returned by a search. By highlighting matches on the detail page as well as the results page, we make it much easier to figure that out. This patch uses a query_desc CGI parameter which is inserted into links from the results page with javascript. This serves to avoid the potential privacy implications of a cookie, and ensures that users without javascript enabled see no change whatsoever. To test: 1) Do a search (or two) in the OPAC with OpacHighlightedWords on. 2) View a record or two of the results, and ensure that the correct words are highlighted. 3) Disable OpacHighlightedWords and do another search (or two), this time ensuring that no words are highlighted. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11329&action=edit Bug 8525: Followup Don't reset the hz scrollbar to the top Hum... an annoying behaviour exists when we click on the "highlight" or "unhighlight" links: the scrollbar is repositionned to the top. This patch fixes that. Switch to NSO. It's a very quick SO ! :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11328|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11336&action=edit Bug 8525: highlight matches on OPAC detail page After doing a search and going to the details page, it can sometimes be difficult to see exactly *why* a record was returned by a search. By highlighting matches on the detail page as well as the results page, we make it much easier to figure that out. This patch uses a query_desc CGI parameter which is inserted into links from the results page with javascript. This serves to avoid the potential privacy implications of a cookie, and ensures that users without javascript enabled see no change whatsoever. To test: 1) Do a search (or two) in the OPAC with OpacHighlightedWords on. 2) View a record or two of the results, and ensure that the correct words are highlighted. 3) Disable OpacHighlightedWords and do another search (or two), this time ensuring that no words are highlighted. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11329|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11337&action=edit Bug 8525: Followup Don't reset the hz scrollbar to the top Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #6 from Ian Walls <koha.sekjal@gmail.com> --- Template only changes (except for the addition of a new template param in the perl file) to allow highlighting on the details page. Marking as Passed QA, both primary and followup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed. Note that this feature has the same problem than the list one : it's diacritic sensible. It means that, if you search "jéan", you'll get result containing "jean" (as expected), but they won't be highlighted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12595&action=edit Follow up: Bug 8525: Update preference description The feature in bug 8525 added highlighting to the detail pages in the opac. This patch updates the preference to note this change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Nicole C. Engard <nengard@gmail.com> --- Follow up needs sign off please. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12595|0 |1 is obsolete| | --- Comment #10 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 12605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12605&action=edit Follow up: Bug 8525: Update preference description The feature in bug 8525 added highlighting to the detail pages in the opac. This patch updates the preference to note this change. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net --- Comment #11 from Mirko Tietgen <mirko@abunchofthings.net> --- Tiny followup for preference description signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Note that the follow-up is a bugfix. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Change syspref description. Last patch marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Severity|minor |enhancement --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- follow-up pushed to master. back to ENH -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org