[Bug 4256] New: auth_by_bind doesn't fetch user LDAP entry breaking replicate
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4256 Summary: auth_by_bind doesn't fetch user LDAP entry breaking replicate Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: blocker Priority: P5 Component: Authentication AssignedTo: chris@bigballofwax.co.nz ReportedBy: dpavlin@rot13.org Estimated Hours: 0.0 Change sponsored?: --- Created an attachment (id=1679) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1679) fix for combination of auth_by_bind and replicate LDAP options Latest git master is broken when using combination of auth_by_bind and replicate because code never fetches user's LDAP entry via search, so replicate dies with Can't call method "exists" on an undefined value at /usr/share/koha/lib/C4/Auth_with_ldap.pm line 191, <DATA> line 253. Attached patch fixes it, along with fix for mungling of mapping (I'm not quite sure that code as-is works for anyone). -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4256 Dobrica Pavlinušić <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org --- Comment #1 from Dobrica Pavlinušić <dpavlin@rot13.org> 2010-03-01 21:30:13 --- There is additional problem with ExtendedPatronAttributes and update disabled. Current code always tries to fill in ExtendedPatronAttributes from LDAP, which doesn't really make sense, since web interface provides edit boxes for it to librarians. In fact, it started destroying our data during upgrade until we turned ExtendedPatronAttributes off. Fortunately, we had backups. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4256 --- Comment #2 from Dobrica Pavlinušić <dpavlin@rot13.org> 2010-03-01 21:39:27 --- Created an attachment (id=1710) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1710) don't update ExtendedPatronAttributes if configured not to Attached patch adds shortcut if update is not specified in configuration file, thus creating ExtendedPatronAttributes only once (on replicate) and then allowing update over web interface without overwriting it. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4256 Dobrica Pavlinušić <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|auth_by_bind doesn't fetch |Koha LDAP broken and |user LDAP entry breaking |corrupts data when used |replicate |without update -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4256 Dobrica Pavlinušić <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha LDAP broken and |C4/Auth_with_ldap.pm |corrupts data when used |replication broken and |without update |corrupts data when used | |without update -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4256 --- Comment #3 from Dobrica Pavlinušić <dpavlin@rot13.org> 2010-03-01 22:04:18 --- Created an attachment (id=1711) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1711) LDAP entries without any ExtendedPatronAttributes break replication Logging into OPAC using LDAP user which doesn't have any attribute results in following error: Software error: Can't use string ("0") as an ARRAY ref while "strict refs" in use at /usr/share/koha/lib/C4/Auth_with_ldap.pm line 172, -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4256 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|chris@bigballofwax.co.nz |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> 2010-04-30 13:09:23 --- Combined diffs and submitted patch to patches mailing list. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4256 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4256 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> 2010-04-30 21:08:29 --- Committed patches to master. Please test and close. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4256 Dobrica Pavlinušić <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com