[Bug 25608] New: Regression: Bug 23463 broke inventory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Bug ID: 25608 Summary: Regression: Bug 23463 broke inventory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: didier.gautheron@biblibre.com Reporter: didier.gautheron@biblibre.com QA Contact: testopia@bugs.koha-community.org Depends on: 23463 need to use unblessed items. Test plan : - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZa' - Check 'Compare barcodes list to results' - Check ' - Submit => without patch, you get an error trace Error trace Can't call method "title" on an undefined value at /kohadevbox/koha/tools/inventory.pl line 347, <$fh> line 2. at /kohadevbox/koha/tools/inventory.pl line 347 in (eval) at /kohadevbox/koha/tools/inventory.pl line 347 344: : $inventorylist // []; 345: for my $item ( @$loop ) { 346: my $biblio = Koha::Biblios->find( $item->{biblionumber} ); 347: $item->{title} = $biblio->title; 348: $item->{author} = $biblio->author; 349: } 350: Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 --- Comment #1 from didier <didier.gautheron@biblibre.com> --- Created attachment 105373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105373&action=edit Bug 25608: Regression - Bug 23463 broke inventory Test plan : - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZa' - Check 'Compare barcodes list to results' - Submit => without patch, you get an error trace - Apply patch, it works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 [Bug 25167] Fix not for loan filter in inventory tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |rel_20_05_candidate Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit bbb504c86f5ca0a474365d4839177412f415c4ee Bug 23463: Replace ModItem with Koha::Item->store -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105373|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105377&action=edit Bug 25608: (bug 23463 follow-up) Fix inventory regression Follow-up work commit bbb504c86f5ca0a474365d4839177412f415c4ee Bug 23463: Replace ModItem with Koha::Item->store Test plan : - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZa' - Check 'Compare barcodes list to results' - Submit => without patch, you get an error trace - Apply patch, it works Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended commit title. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression: Bug 23463 broke |(regression) Inventory is |inventory |broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105377|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 105391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105391&action=edit Bug 25608: (bug 23463 follow-up) Fix inventory regression Follow-up work commit bbb504c86f5ca0a474365d4839177412f415c4ee Bug 23463: Replace ModItem with Koha::Item->store Test plan : - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZa' - Check 'Compare barcodes list to results' - Submit => without patch, you get an error trace - Apply patch, it works Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended commit title. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05 released in| | Status|Passed QA |Pushed to master Keywords|rel_20_05_candidate | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to master |Pushed to stable --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org