[Bug 23475] New: Search context is lost when simple search leads to a single record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Bug ID: 23475 Summary: Search context is lost when simple search leads to a single record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 19046 made search terms and dropdown preserve in the staff client, however, if one search for a barcode or something that returns a single record the dropdown and box are cleared -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92357&action=edit Bug 23475: Use cookies to preserve simple search values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- This patch is a POC - it needs some work and extension for the OPAC, but it should demonstrate possibility of passing through to the details page - Other options would be to build everythign into the url, or be able to process details page from search.pl - this seemed a quick way to get things there -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92357|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93558&action=edit Bug 23475: Use cookies to preserve simple search values Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Finally worked cleaning the cookies ! I just had a little encoding issue with the last 'é' (see screenshot) but I don't know it if comes from the patch I'm not sure it comes form the patch so I signed it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #6 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 93562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93562&action=edit Little issue with the final é -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Severine: Please describe how you got the encoding issue. I see a title field on your image. Where does it come from ? Nick: At first glance it seems to me that you should encode/decode unicode stuff when saving and fetching from CGI cookies. I had a quick look in CGI on cpan but the docs are very quiet about it. Cannot see if -utf8 should handle cookie values too. Please check. Changing status for feedback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #8 from Séverine Queune <severine.queune@bulac.fr> --- Hi Marcel, I know I used a Biblibre's sandbox in Unimarc, but I can't remember if it was http://pro.es5-koha.sandbox.biblibre.eu (login with test/test) which uses ES5 or http://pro.es6-koha.sandbox.biblibre.eu with ES6. I tried with several title and everything worked fine, except for the title "Mademoiselle liberté" with this little issue. This is something quite usual with some letter with diacritics in French (see for example bug 23542), so as I said, I'm not sure it comes from the patch, nor if the patch could solve this problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93558|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 108124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108124&action=edit Bug 23475: Use cookies to preserve simple search values To test: 1 - Enable IntranetCatalogSearchPulldown 2 - Perform a search that brings you to a single title 3 - Note the search is not displayed on the details page 4 - Apply patch 5 - Repeat 6 - Note the search is retained on details page 7 - Try with different dropdown values and search terms 8 - Test search terms including accented characters etc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #7)
Nick: At first glance it seems to me that you should encode/decode unicode stuff when saving and fetching from CGI cookies. I had a quick look in CGI on cpan but the docs are very quiet about it. Cannot see if -utf8 should handle cookie values too. Please check.
It looks like Firefox and Chrome both URI encode the values when we save them. To decode we need unescape, then utf8 decode, at least that's what worked. Afaict, things are not consistent: https://stackoverflow.com/questions/1969232/what-are-allowed-characters-in-c... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Nice work. In my opinion cookie name "pulldown_selection" is too generic. I propose you use a prefix like "cat_search". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109624&action=edit Bug 23475: Make cookie name more explicit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #13 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- I loaded this onto a sandbox, but received the following error when searching for a record with just one match: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_catalogue_detail_2epl::uri_unescape called at /kohadevbox/koha/catalogue/detail.pl line 121 A search which returns multiple records functions as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111325&action=edit Bug 23475: (follow-up) Include URI::Escape -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108124|0 |1 is obsolete| | --- Comment #15 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 111338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111338&action=edit Bug 23475: Use cookies to preserve simple search values To test: 1 - Enable IntranetCatalogSearchPulldown 2 - Perform a search that brings you to a single title 3 - Note the search is not displayed on the details page 4 - Apply patch 5 - Repeat 6 - Note the search is retained on details page 7 - Try with different dropdown values and search terms 8 - Test search terms including accented characters etc Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109624|0 |1 is obsolete| | --- Comment #16 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 111339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111339&action=edit Bug 23475: Make cookie name more explicit Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111325|0 |1 is obsolete| | --- Comment #17 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 111340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111340&action=edit Bug 23475: (follow-up) Include URI::Escape Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works well - here's some of the accented searches I used on the sandbox in case they're useful for others testing: Howe, Zoë Street Strk̆v̜elser Ślez -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111338|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111798&action=edit Bug 23475: Use cookies to preserve simple search values To test: 1 - Enable IntranetCatalogSearchPulldown 2 - Perform a search that brings you to a single title 3 - Note the search is not displayed on the details page 4 - Apply patch 5 - Repeat 6 - Note the search is retained on details page 7 - Try with different dropdown values and search terms 8 - Test search terms including accented characters etc Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111339|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111799&action=edit Bug 23475: Make cookie name more explicit Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111340|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111800&action=edit Bug 23475: (follow-up) Include URI::Escape Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |cookie --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please document the new cookies here: https://wiki.koha-community.org/wiki/Use_of_Cookies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why a cookie? We could use localStorage here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111798|0 |1 is obsolete| | Attachment #111799|0 |1 is obsolete| | Attachment #111800|0 |1 is obsolete| | --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 112697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112697&action=edit Bug 23475: Use localStorage to preserve simple search values To test: 1 - Enable IntranetCatalogSearchPulldown 2 - Perform a search that brings you to a single title 3 - Note the search is not displayed on the details page 4 - Apply patch 5 - Repeat 6 - Note the search is retained on details page 7 - Try with different dropdown values and search terms 8 - Test search terms including accented characters etc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112697|0 |1 is obsolete| | --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 112714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112714&action=edit Bug 23475: Use localStorage to preserve simple search values To test: 1 - Enable IntranetCatalogSearchPulldown 2 - Perform a search that brings you to a single title 3 - Note the search is not displayed on the details page 4 - Apply patch 5 - Repeat 6 - Note the search is retained on details page 7 - Try with different dropdown values and search terms 8 - Test search terms including accented characters etc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|cookie | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112714|0 |1 is obsolete| | --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 112971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112971&action=edit Bug 23475: Use localStorage to preserve simple search values To test: 1 - Enable IntranetCatalogSearchPulldown 2 - Perform a search that brings you to a single title 3 - Note the search is not displayed on the details page 4 - Apply patch 5 - Repeat 6 - Note the search is retained on details page 7 - Try with different dropdown values and search terms 8 - Test search terms including accented characters etc Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112971|0 |1 is obsolete| | --- Comment #27 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 113744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113744&action=edit Bug 23475: Use localStorage to preserve simple search values To test: 1 - Enable IntranetCatalogSearchPulldown 2 - Perform a search that brings you to a single title 3 - Note the search is not displayed on the details page 4 - Apply patch 5 - Repeat 6 - Note the search is retained on details page 7 - Try with different dropdown values and search terms 8 - Test search terms including accented characters etc Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. There are 2 unneeded use statements in catalogue/detail.pl 2. Shouldn't we use the same selectors for: + if ( search_index ){ $('.advsearch[name="idx"]').val(search_index)}; vs + localStorage.setItem('cat_search_pulldown_selection', $("#cat-search-block select.advsearch").val() ); and + if ( search_value ){ $('#search-form').val(search_value)}; vs + localStorage.setItem('searchbox_value', $("#cat-search-block #search-form").val() ); to make thing more obvious. Is there a reason not to? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113784&action=edit Bug 23475: (follow-up) Fix selectors and stray use statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Found a bug: 1. Search for "Chapman" on the adv search 2. The detail page has "undefined" in the search box -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113904&action=edit Bug 23475: Unset the storage if the values do not exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113744|0 |1 is obsolete| | Attachment #113784|0 |1 is obsolete| | Attachment #113904|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114055&action=edit Bug 23475: Use localStorage to preserve simple search values To test: 1 - Enable IntranetCatalogSearchPulldown 2 - Perform a search that brings you to a single title 3 - Note the search is not displayed on the details page 4 - Apply patch 5 - Repeat 6 - Note the search is retained on details page 7 - Try with different dropdown values and search terms 8 - Test search terms including accented characters etc Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Bug 23475: (follow-up) Fix selectors and stray use statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114056&action=edit Bug 23475: Unset the storage if the values do not exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00, 20.11.01 released in| | --- Comment #35 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00, 20.11.01 |21.05.00, 20.11.01, released in| |20.05.07 CC| |andrew@bywatersolutions.com --- Comment #36 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #37 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27697 [Bug 27697] Opening bibliographic record page prepopulates search bar text -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26247 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 [Bug 26247] Search terms retained in header search creates UX inconsistency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26247 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Ricardo Ruiz <rickx1@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rickx1@gmail.com --- Comment #38 from Ricardo Ruiz <rickx1@gmail.com> --- Hello everyone, I updated an old version of Koha to version 21.11.11. Following the steps of the bug solution the error continues. My Koha uses Zebra as its indexing engine. Could you confirm me if the solution also works for Zebra or only for Elasticsearch? Thank you -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Ricardo Ruiz from comment #38)
Hello everyone,
I updated an old version of Koha to version 21.11.11. Following the steps of the bug solution the error continues.
My Koha uses Zebra as its indexing engine. Could you confirm me if the solution also works for Zebra or only for Elasticsearch?
Thank you
As this bug has been closed, please file a new one and give the steps on how to see the problematic behaviour. You can link it to this one using the See also if you think it's similar. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org