[Bug 21471] New: Misspelled variable name in _get_outstanding_holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21471 Bug ID: 21471 Summary: Misspelled variable name in _get_outstanding_holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com $item should be $items, if patron is queued for a biblio _get_outstanding_holds will crash (but not caught since evaluated in eval context). Since this is a trivial fix I will not write a how to test, since fix should be obvious just looking at the code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21471 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 79817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79817&action=edit Bug 21471: Misspelled variable in _get_outstanding_holds Misspelled variable causes _get_outstanding_holds to crash if patron is queued on biblio level -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21471 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | Severity|enhancement |critical Status|NEW |Needs Signoff Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21471 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21471 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79817|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 79851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79851&action=edit Bug 21471: Misspelled variable in _get_outstanding_holds Misspelled variable causes _get_outstanding_holds to crash if patron is queued on biblio level Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21471 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |21184 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Oops, sorry! Caused by commit 62a075987af70ec5ed3665fe662adb31a17fdde4 Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21471 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21471 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79851|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79900&action=edit Bug 21471: (bug 21184 follow-up) Misspelled variable in _get_outstanding_holds Misspelled variable causes _get_outstanding_holds to crash if patron is queued on biblio level Caused by commit 62a075987af70ec5ed3665fe662adb31a17fdde4 Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21471 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21471 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Caused by bug 21184 not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org