[Bug 38326] New: MarcItemFieldsToOrder copyno not copying over
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Bug ID: 38326 Summary: MarcItemFieldsToOrder copyno not copying over Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Set copynumber in MarcItemFieldsToOrder: copyno: 965$z 2. Have a mrc file that includes this marc field 3. Stage a mrc file for import 4. Notice the copynumber isn't correctly copied over -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 173876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173876&action=edit Bug 38326: Don't convert to copynumber To test: 1. Set copynumber in MarcItemFieldsToOrder: copyno: 965$z 2. Have a mrc file that includes this marc field 3. Stage a mrc file for import 4. Notice the copynumber isn't correctly copied over 5. APPLY PATCH, restart_all 6. Try again, this time it should work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173876|0 |1 is obsolete| | --- Comment #2 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 174287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174287&action=edit Bug 38326: Don't convert to copynumber To test: 1. Set copynumber in MarcItemFieldsToOrder: copyno: 965$z 2. Have a mrc file that includes this marc field 3. Stage a mrc file for import 4. Notice the copynumber isn't correctly copied over 5. APPLY PATCH, restart_all 6. Try again, this time it should work. Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sam.sowanick@corvallisorego | |n.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174287|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174678&action=edit Bug 38326: Don't convert to copynumber To test: 1. Set copynumber in MarcItemFieldsToOrder: copyno: 965$z 2. Have a mrc file that includes this marc field 3. Stage a mrc file for import 4. Notice the copynumber isn't correctly copied over 5. APPLY PATCH, restart_all 6. Try again, this time it should work. Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174679&action=edit Bug 38326: (QA follow-up) Tidy Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|MarcItemFieldsToOrder |copyno not copied over when |copyno not copying over |set in | |MarcItemFieldsToOrder | |system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Are we sure about this fix? # Handle incorrectly named original parameters for MarcItemFieldsToOrder $iteminfos->{location} = delete $iteminfos->{loc} if $iteminfos->{loc}; - $iteminfos->{copynumber} = delete $iteminfos->{copyno} if $iteminfos->{copyno}; @Nick can you maybe have a look? It just seems like this was intentionally added at some point. Maybe because the configuration should be using copynumber? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I think I added that line by mistake as the field in the items table is called 'copynumber' but in the template it is called 'copyno' so Lucas is correct to remove that line otherwise it doesn't render the value in the template and it won't then be passed into the ordering process. The logic for handling the ordering takes in the copyno values and then parses them to the correct 'copynumber' field when creating the items and the orderlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was missing some kind of explanation :) Thanks for that, Matt! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com --- Comment #9 from Laura O'Neil <laura@bywatersolutions.com> --- Is it possible to backport this to 24.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38326 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- No Koha/MarcOrder.pm in 24.05.x, so no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org