[Bug 37255] New: Creating default waiting hold cancellation policy for all patron categories and itemtypes breaks Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Bug ID: 37255 Summary: Creating default waiting hold cancellation policy for all patron categories and itemtypes breaks Koha Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org If one creates a default waiting hold cancellation policy with patron categories set as "All" and itemtype set as "All", Koha breaks on 500 error. Logs read: Template process failed: undef error - Can't call method "description" on an undefined value at ../Koha/Koha/Template/Plugin/Categories.pm line 39. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 168494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168494&action=edit Bug 37255: Fix handling of "All" values on waiting hold cancellation policy If one creates a default waiting hold cancellation policy with patron categories set as "All" and itemtype set as "All", Koha breaks on 500 error. This happens because in we try to match template policy with "All" values either in category or itemtype with *, not undef. This patch fixes this. To test: 1. Create a new default waiting hold cancellation policy and set both patron category and itemtype as "All". 2. Save policy. => Error page for error 500 is displayed. 3. Apply this patch. 4. Reload page. => Page is displayed and policy listing displays new policy as it should. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168494|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 168524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168524&action=edit Bug 37255: Fix handling of "All" values on waiting hold cancellation policy If one creates a default waiting hold cancellation policy with patron categories set as "All" and itemtype set as "All", Koha breaks on 500 error. This happens because in we try to match template policy with "All" values either in category or itemtype with *, not undef. This patch fixes this. To test: 1. Create a new default waiting hold cancellation policy and set both patron category and itemtype as "All". 2. Save policy. => Error page for error 500 is displayed. 3. Apply this patch. 4. Reload page. => Page is displayed and policy listing displays new policy as it should. Sponsored-by: Koha-Suomi Oy Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@ptfs-europe.co |y.org |m CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168524|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168552&action=edit Bug 37255: Fix handling of "All" values on waiting hold cancellation policy If one creates a default waiting hold cancellation policy with patron categories set as "All" and itemtype set as "All", Koha breaks on 500 error. This happens because in we try to match template policy with "All" values either in category or itemtype with *, not undef. This patch fixes this. To test: 1. Create a new default waiting hold cancellation policy and set both patron category and itemtype as "All". 2. Save policy. => Error page for error 500 is displayed. 3. Apply this patch. 4. Reload page. => Page is displayed and policy listing displays new policy as it should. Sponsored-by: Koha-Suomi Oy Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37263 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Same pattern causing bug 37263. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Depends on| |36672 Keywords| |rel_23_05_candidate Severity|normal |critical --- Comment #6 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Increasing the severity on this one and flagging it for backport, since it crashes the page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36672 [Bug 36672] Circulation rules are performing too many lookups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37531 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isabel.pineda@ds.edu.sv --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- *** Bug 37531 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to main for 24.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Version(s)|24.11.00,24.05.04 |24.11.00,24.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.03 |24.11.00,24.05.03,23.05.15 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to 23.05.x. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to 23.05.x. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to 23.05.x. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 --- Comment #12 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Tomás Cohen Arazi from comment #11)
Pushed to 23.05.x.
Nice work everyone, thanks!
Git bz error? Or did this actually get pushed for 23.05.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Emily Lamancusa from comment #12)
(In reply to Tomás Cohen Arazi from comment #11)
Pushed to 23.05.x.
Nice work everyone, thanks!
Git bz error? Or did this actually get pushed for 23.05.x?
It will be part of the upcoming maintenance releases as an urgent backport. Stay tuned :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 --- Comment #14 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Katrin Fischer from comment #13)
(In reply to Emily Lamancusa from comment #12)
(In reply to Tomás Cohen Arazi from comment #11)
Pushed to 23.05.x.
Nice work everyone, thanks!
Git bz error? Or did this actually get pushed for 23.05.x?
It will be part of the upcoming maintenance releases as an urgent backport. Stay tuned :)
Ah, I see. It shouldn't be backported that far, though - the bug was caused by bug 36672, which is only in main and 24.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.03,23.05.15 |24.11.00,24.05.03,23.11.07, released in| |23.05.15 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for noticing Emily. I guess we can't leave it in? ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 --- Comment #16 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Unfortunately, no. :( The cause of this regression was that a variable value was switched from '*' to undef, and a few cases got missed. So applying this patch to 23.05 causes the same 500 error that it's meant to solve in 24.05 and main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It was more of a rhetoric question, I'll try to get that sorted ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.03,23.11.07, |24.11.00,24.05.03 released in|23.05.15 | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Reverted the patch from 23.11, 23.05 and 22.11 branches. Thanks again Emily! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #19 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #18)
Reverted the patch from 23.11, 23.05 and 22.11 branches. Thanks again Emily!
I don't think this was reverted from 23.11.x, as it's still in 23.11.08. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37764 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37764 [Bug 37764] 'Fix handling of "All" values on waiting hold cancellation policy' breaks Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #19)
(In reply to Katrin Fischer from comment #18)
Reverted the patch from 23.11, 23.05 and 22.11 branches. Thanks again Emily!
I don't think this was reverted from 23.11.x, as it's still in 23.11.08.
You need to look at the latest tag: 23.11.08-1. That's what we used for the tarballs and packages. It has the revert on top: https://git.koha-community.org/Koha-community/Koha/commits/tag/v23.11.08-1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 36672 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #22 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Bug 37255 depends on bug 36672, which changed state. Bug 36672 Summary: Circulation rules are performing too many lookups https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36672 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED --- Comment #23 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Big fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org