https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133308&action=edit Bug 30508: Do not display OPAC message about block from holds when OPACHoldRequests is disabled This patch adds a check for the OPACHoldRequests to determine whether a message should be shown to patrons whose account is over the maxoutstanding limit. To test, apply the patch and set the "maxoutstanding" system preference to a low value. Set OPACHoldRequests to "Allow." - Log in to the OPAC as a patron who has outstanding fines or charges which exceed the maxoutstanding value you set. - You should see a message on the "Your summary" page, "Holds are blocked because your fine balance is over the limit." - Set OPACHoldRequests to "Don't allow" and refresh the "Your summary" page in the OPAC. The message should disappear. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133308|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #3 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 133721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133721&action=edit Bug 30508: Do not display OPAC message about block from holds when OPACHoldRequests is disabled To test, apply the patch and set the "maxoutstanding" system preference to a low value. Set OPACHoldRequests to "Allow." - Log in to the OPAC as a patron who has outstanding fines or charges which exceed the maxoutstanding value you set. - You should see a message on the "Your summary" page, "Holds are blocked because your fine balance is over the limit." - Set OPACHoldRequests to "Don't allow" and refresh the "Your summary" page in the OPAC. The message should disappear. Works OK! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133721|application/mbox |text/plain mime type| | Attachment #133721|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks for testing Amit :) . For some reason when attaching the patch it hasn't been marked as a patch. And don't forget to add your signoff line to the patch with: git format-patch -s origin/master Here has been attached a version of the patch with your signoff added (assuming you want to use the same email address as in Bugzilla) Wait, it's not the same email address as the one I tried to attach! So there has been something else weird with the patch attachment. Comment 3 doesn't show the signoff line but it was there and resurfaced when I attached the patch. (Also for some reason, my attempt to add a SO line with a custom name and email didn't work) Anyway, what is your procedure to attach a patch here? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Victor, not sure about the confusion here, but Amit's sign-off line seems ok to me in his attached patch: Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Maybe it was uploaded manually, that could explain the missing 'patch' flag. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133740&action=edit Bug 30508: Do not display OPAC message about block from holds when OPACHoldRequests is disabled This patch adds a check for the OPACHoldRequests to determine whether a message should be shown to patrons whose account is over the maxoutstanding limit. To test, apply the patch and set the "maxoutstanding" system preference to a low value. Set OPACHoldRequests to "Allow." - Log in to the OPAC as a patron who has outstanding fines or charges which exceed the maxoutstanding value you set. - You should see a message on the "Your summary" page, "Holds are blocked because your fine balance is over the limit." - Set OPACHoldRequests to "Don't allow" and refresh the "Your summary" page in the OPAC. The message should disappear. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Lucas Gass from comment #2)

Shouldn't we just hide the "Holds are blocked because your fine balance is over the limit" part of the message?

Seems like it would still be useful to show the "Please note: Your account has outstanding fees & charges of X.XX" part of the message, regardless of OPACHoldRequests.

Good point -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate |rel_22_11_candidate --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer to leave it to next cycle -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.