[Bug 41788] New: Make holds queue redirection optional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Bug ID: 41788 Summary: Make holds queue redirection optional Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdonna@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Pushing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36455 without an option to not use it has caused issues for libraries with large hold queues. Without having the ability to filter before running the queue, it can take a long time to generate the list, taking up other resources on the server. Once the queue finally renders, staff have to re-run the process with the limitations/filters in place. This needs to be a system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36455 CC| |lucas@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36455 [Bug 36455] Default the hold queue link to your logged in library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36455 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36455 [Bug 36455] Default the hold queue link to your logged in library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36455 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36455 [Bug 36455] Default the hold queue link to your logged in library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192634&action=edit Bug 41788: Add system preference UseHoldsQueueFilterOptions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192635&action=edit Bug 41788: Implement UseHoldsQueueFilterOptions To test: 1. Apply patch, updatedatabase, restart_all 2. Search for new system preference UseHoldsQueueFilterOptions. 3. Disable it, and navigate to Circulation -> Holds queue 4. With the pref disabled the holds queue should run with asking for filters. 5. Also try the Holds queue link in the circ-nav ( left navigation ) panel, clicking it should automatically run the holds queue. 6. Also try the link in the breadcrumbs, clicking it should automatically run the holds queue. 7. Now enabled the pref. 8. With the pref enabled navigate to Circulation -> Holds queue, the holds queue link should present filters but NOT run the holds queue. 9. Test the Holds queue link in the circ-nav ( left navigation ) panel, click it should present filters but NOT run the holds queue. 10. Also try the link in the breadcrumbs, clicking them should presnt filters but not run the holds queue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Small patch Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make holds queue |Make running the holds |redirection optional |queue on click optional -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a system release notes| |preference | |'UseHoldsQueueFilterOptions | |'. When it is enabled it | |prevents the direct running | |of the holds queue by | |clicking on the 'Holds | |queue' links. With it | |enabled it will present the | |user with filter options | |before running the holds | |queue. This is to prevent | |excessive running of the | |holds queue which can cause | |slowdowns on larger | |systems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jrobb@sekls.org --- Comment #3 from Jason Robb <jrobb@sekls.org> --- It looks like there may be some errors in the sysprefs.sql file at lines 491 and 581. It might be good to add the phrase "filter options" to the syspref description to add some clarity: [Enable/Disable] filter options when running the holds queue. Other than that it seems to work great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jason Robb from comment #3)
It looks like there may be some errors in the sysprefs.sql file at lines 491 and 581.
It might be good to add the phrase "filter options" to the syspref description to add some clarity: [Enable/Disable] filter options when running the holds queue.
Other than that it seems to work great!
What errors do you see? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #5 from Jason Robb <jrobb@sekls.org> --- 491 /kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql('OPACAllowUserToChooseBranch','1',NULL,'Allow the user to choose the branch they want to pickup their hold from','YesNo'), 581 ('OpacShowRecentComments','0',NULL,'If ON a link to recent c/kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sqlomments will appear in the OPAC masthead','YesNo'), -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192952&action=edit Bug 41788: Order sys prefs correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192952|0 |1 is obsolete| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192953&action=edit Bug 41788: Order sys prefs correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192634|0 |1 is obsolete| | --- Comment #8 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 193024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193024&action=edit Bug 41788: Add system preference UseHoldsQueueFilterOptions Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192635|0 |1 is obsolete| | --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 193025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193025&action=edit Bug 41788: Implement UseHoldsQueueFilterOptions To test: 1. Apply patch, updatedatabase, restart_all 2. Search for new system preference UseHoldsQueueFilterOptions. 3. Disable it, and navigate to Circulation -> Holds queue 4. With the pref disabled the holds queue should run with asking for filters. 5. Also try the Holds queue link in the circ-nav ( left navigation ) panel, clicking it should automatically run the holds queue. 6. Also try the link in the breadcrumbs, clicking it should automatically run the holds queue. 7. Now enabled the pref. 8. With the pref enabled navigate to Circulation -> Holds queue, the holds queue link should present filters but NOT run the holds queue. 9. Test the Holds queue link in the circ-nav ( left navigation ) panel, click it should present filters but NOT run the holds queue. 10. Also try the link in the breadcrumbs, clicking them should presnt filters but not run the holds queue. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192953|0 |1 is obsolete| | --- Comment #10 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 193026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193026&action=edit Bug 41788: Order sys prefs correctly Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #11 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to Jason Robb from comment #5)
491 /kohadevbox/koha/installer/data/mysql/mandatory/sysprefs. sql('OPACAllowUserToChooseBranch','1',NULL,'Allow the user to choose the branch they want to pickup their hold from','YesNo'),
581 ('OpacShowRecentComments','0',NULL,'If ON a link to recent c/kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sqlomments will appear in the OPAC masthead','YesNo'),
When I tested this the patch did not apply at first due to a sha1 error. Jason noticed these two lines that look like an inadvertent paste happened. I was able to remove the two instances of `/kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql` and git am --continue After that the patch worked as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Putting this 'In discussion' based on some feedback on Mattermost. There are some small disagreements on whether or not something like this warrants a system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #13 from Donna <bwsdonna@gmail.com> --- Shouldn't discussion be taking place here, and NOT in Mattermost? This is a simple problem - bug 36455 made a change to how the queue runs, causing significant issues for libraries. So we have three options: 1. undo bug 36455 2. make a system preference 3. add a link on the circ module page to determine whether to run it with filters or just pull the whole thing for your library I don't care which one gets done, but it needs to happen. Bug 36455 introduced unintentional issues for libraries, and running their holds queue is now problematic and causes performance issues. We have a patch that works and does not cause other issues. I see no need for this to not move forward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #14 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- For context - this is expanding bug 36455 into something that takes 15 lines of code and a system preference, compared to 2-3 lines of JQuery that were being used to accomplish the same thing before 36455. On the one hand, we do value bringing common things into core rather than having libraries duplicate customizations; on the other hand, I wanted to at least ask the question of whether it still makes sense to have this feature in core when it means maintaining code that has become that much more complex than the JQuery it's replacing, or whether it makes more sense to revert 36455. That said, I'm also not excited to revert a community contribution to bring a common JQuery customization into core that has already been in 2 releases, and the prevailing sentiment on the Mattermost thread seems to be in favor of keeping it and adding the syspref, so I'm leaning towards going ahead with this if there aren't any major objections. I originally asked on Mattermost and not here because I was afraid if I only asked here, it wouldn't get seen and this bug would stall in In Discussion forever. Probably should have posted here first and then linked on Mattermost, sorry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Donna from comment #13)
Shouldn't discussion be taking place here, and NOT in Mattermost?
Yes that's why Lucas put the bug status to "In discussion" and asked us to take our comments to the bug. That said, discussions will always be happening on Mattermost, just as they were always happening on IRC. Taking the bug out of "In discussion" before there has been any discussion isn't how I think we should be doing things. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Here's my take: Before Bug 36455 the holds queue workflow worked for some libraries and not others. After Bug 36455 the holds queue workflow worked for some libraries and not others. We should choose a solution which works for both categories of libraries. We could revert Bug 36455 and tell *everyone* that they're responsible for making it work the way they want it to, or we add a switch to Koha to let them easily switch between the two. I think adding that switch, presumably in the form of a system preference, is the way to go. Could we simply the patch by putting the check for the new system preference into view_holdsqueue.tt instead of into each template which links to it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #17 from George Williams (NEKLS) <george@nekls.org> --- I would recommend going forward with adding a system preference that can determine whether or not the holds queue loads automatically when you go to view_holdsqueue.pl. The issue here relates to workflow management in 4 different directions. As stated previously: Before Bug 36455 the holds queue workflow worked for some libraries and not others. After Bug 36455 the holds queue workflow worked for some libraries and not others. But there's another layer here: Before Bug 36455, if a library wanted to modify their holds queue workflow, the librarians had to maintain custom jQuery or Javascript. If Bug 41788 is added to Koha, developers will have to maintain 15 lines of new code and a system preference and all of the possible bugs and issues that come along with that. ----- Before bug 36455 was added to Koha you needed to A) go to the circulation page, B) click on Holds queue, C) set any filters for the holds queue (the Library will default to the library you are logged in at), D) click submit. My experience is that most small to medium libraries neither want nor need steps C and D because there aren't that many items in their holds queues. In the original post in this bug, Donna says that bug 36455 "has caused issues for libraries with large hold queues." In that respect that becomes a small libraries vs large libraries issue. And in my experience, the smaller libraries are the ones that are less likely to learn how to write custom Javascript and jQuery for Koha, and they're less likely to participate in the community and file bugs and participate in the conversation here because they're too busy running their libraries. Ultimately, if the goal is to make Koha easy to use for as many libraries as possible, then Koha should have a built in way of setting whether or not the holds queue loads automatically when you go to view_holdsqueue.pl. So, I would recommend going forward with adding a system preference that can determine whether or not the holds queue loads automatically when you go to view_holdsqueue.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #18 from Jason Robb <jrobb@sekls.org> --- As someone who was involved with the originating patch, the issues it causes for larger libraries were not intentional. Apologies for not accounting for larger queues. Part of the intent of the initial work was to share the idea with the community so that we could both improve workflows and trend away from utilizing custom jQuery that has to be locally maintained and is prone to breaking on upgrades. I agree with George on all points. While a single click seems miniscule, it adds up for a task that's done at least once a day. In a small library with limited hours, anything we can do to speed up workflows is very beneficial. Were this reverted, I would imagine the combined burden to all the libraries that want to restore and maintain the behavior via custom jQuery would far outweigh the burden of the devs to maintain it as a syspref in the base code. Likely, many libraries without the time, ability or resources to restore the functionality with jQuery would lose it entirely. I'm definitely in favor of the existing work to implement a syspref so there's flexibility to accomodate libraries of different sizes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #19 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Thanks for the feedback, everyone! There's a clear consensus here, and I personally am completely convinced now as well! Setting this back to Signed off, and I'll finish up the QA on it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #20 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- One more small thing - the name "UseHoldsQueueFilterOptions" is confusing to me, because it sounds like you won't have the option to filter the holds queue at all if you disable the syspref. However, you still have the option to change the filters after running the holds queue either way; the only thing that changes is whether you *must* select filters *before* running the holds queue, or whether the holds queue defaults to the logged-in library and runs immediately. Could we tweak the wording to something like this instead for clarity? "RequireHoldsQueueFilters: If enabled, the user will be required to select filters before running the holds queue. If disabled, the holds queue will show all holds for the logged-in library by default, and can be re-run with more filters if desired." (Happy to make the change as a QA follow-up if you agree) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193024|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193025|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193026|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #21 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 195698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195698&action=edit Bug 41788: Add system preference UseHoldsQueueFilterOptions Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #22 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 195699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195699&action=edit Bug 41788: Implement UseHoldsQueueFilterOptions To test: 1. Apply patch, updatedatabase, restart_all 2. Search for new system preference UseHoldsQueueFilterOptions. 3. Disable it, and navigate to Circulation -> Holds queue 4. With the pref disabled the holds queue should run with asking for filters. 5. Also try the Holds queue link in the circ-nav ( left navigation ) panel, clicking it should automatically run the holds queue. 6. Also try the link in the breadcrumbs, clicking it should automatically run the holds queue. 7. Now enabled the pref. 8. With the pref enabled navigate to Circulation -> Holds queue, the holds queue link should present filters but NOT run the holds queue. 9. Test the Holds queue link in the circ-nav ( left navigation ) panel, click it should present filters but NOT run the holds queue. 10. Also try the link in the breadcrumbs, clicking them should presnt filters but not run the holds queue. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #23 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 195700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195700&action=edit Bug 41788: (QA follow-up) Clarify system preference description Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #24 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Sorry, didn't mean to leave it this long! It need a trivial rebase on top of 41834, but otherwise looks good and works as intended! Passing QA Thanks again everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42607 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 --- Comment #26 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788 rpalermo@oslri.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rpalermo@oslri.net -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org