https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42000 --- Comment #1 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 194510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194510&action=edit Bug 42000: Add bookings count info on result page Display number of bookings if: - items are bookable and syspref booking enabled of course - at least on item is available for booking - exclude past bookings and completed bookings (checked out normally) Test plan: 1) Apply this patch and restart_all 2) Perform a search and see new bookings count info Display number of bookings if: - items are bookable - at least on item is available for booking - exclude past bookings and completed bookings (checkouts normally) Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42000 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42000 --- Comment #2 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 195806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195806&action=edit Bug 42000: Add bookings count info on result page Display number of bookings if: - items are bookable and syspref booking enabled of course - at least on item is available for booking - exclude past bookings and completed bookings (checked out normally) Test plan: 1) Apply this patch and restart_all 2) Perform a search and see new bookings count info Display number of bookings if: - items are bookable - at least on item is available for booking - exclude past bookings and completed bookings (checkouts normally) Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like the idea of this patch adding more consistency to the display. But there are a few small things to fix: From QA tools: 1) Patch set is not tidy. 2) We are missing a filter. 3) Fallback for staff users without permissions I notice that we always show the holds, but the bookings will only show if the user has the permission to manage bookings. I think we should have an unlinked "text only" fallback if permissions are lacking here: [% ELSE %] <span>Holds ([% SEARCH_RESULT.biblio_object.holds.count | html %])</span> [% END %] + [% IF Koha.Preference('EnableBooking') && CAN_user_circulate_manage_bookings && SEARCH_RESULT.has_bookable_items %] + | <a href="/cgi-bin/koha/bookings/list.pl?biblionumber=[% SEARCH_RESULT.biblionumber | uri %]#bookings">Bookings ([% SEARCH_RESULT.future_bookings_count | html %])</a> + [% END %] It's also a question if the count should not be implemented as an object method like the holds count? It will probably be useful in more than this one spot, thinking of the detail page for example. -- You are receiving this mail because: You are watching all bug changes.