[Bug 17371] New: REST API: add CRUD for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Bug ID: 17371 Summary: REST API: add CRUD for biblios Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: benjamin.rokseth@kul.oslo.kommune.no QA Contact: testopia@bugs.koha-community.org This bug proposes to add full CRUD for biblios to the REST API, meaning a basic endpoint for managing records outside of Koha staff. It will make use of Koha Objects and largely replicate the /svc/biblios functionality, but from a RESTful perspective. Proposed routes : GET /api/v1/biblios/{biblionumber} Get a simple record GET /api/v1/biblios/{biblionumber}/items Get a record with items GET /api/v1/biblios/{biblionumber}/expanded Get a record with items and item statuses POST /api/v1/biblios/{biblionumber}/{frameworkcode} Create a record with items (and optional framework) PUT /api/v1/biblios/{biblionumber}/{frameworkcode} Update a record without touching items (and optional framework) DELETE /api/v1/biblios/{biblionumber} Delete a record with items POST and PUT will take marcxml as input -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #1 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 55898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55898&action=edit Bug 17371 - REST API: add CRUD for biblios Patch to add CRUD to biblios. Test plan: 1) add dependent bug 17004 2) create some staff user with editcatalogue permission 3) play with API with routes explained in bug description 4) run test t/db_dependent/api/v1/biblios.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Shouldn't this be "Needs signoff"? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |magnus@libriotech.no -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Setting this to "needs signoff", please correct me if I'm wrong! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@jkozlovsky.cz --- Comment #4 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- What if you visit items endpoint in a record with really huge amount of items? I think it would actually timeout, depending on the server or proxy configuration serving this endpoint. Wouldn't it be better to return only list of itemnumbers so that the user can fetch let's say only first 10 items and after he want to see next, he fetches another 10 items? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #5 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- (In reply to Jiri Kozlovsky from comment #4)
What if you visit items endpoint in a record with really huge amount of items? I think it would actually timeout, depending on the server or proxy configuration serving this endpoint. Wouldn't it be better to return only list of itemnumbers so that the user can fetch let's say only first 10 items and after he want to see next, he fetches another 10 items?
Depends on what you mean by huge amount? thousands? We have no issue on hundreds, although it takes some seconds. The API strives to be agnostic of the DB and merely uses Koha Objects ($biblio->items). Getting only the IDs would actually be more code and logic in the API than we want. However, if this is an issue, I would rather suggest adding a method to Koha::Biblios to get the IDs of the attached items only, and then the API could reflect that with another route. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17007 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14656 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #6 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- (In reply to Benjamin Rokseth from comment #5)
(In reply to Jiri Kozlovsky from comment #4)
What if you visit items endpoint in a record with really huge amount of items? I think it would actually timeout, depending on the server or proxy configuration serving this endpoint. Wouldn't it be better to return only list of itemnumbers so that the user can fetch let's say only first 10 items and after he want to see next, he fetches another 10 items?
Depends on what you mean by huge amount? thousands? We have no issue on hundreds, although it takes some seconds. The API strives to be agnostic of the DB and merely uses Koha Objects ($biblio->items). Getting only the IDs would actually be more code and logic in the API than we want.
However, if this is an issue, I would rather suggest adding a method to Koha::Biblios to get the IDs of the attached items only, and then the API could reflect that with another route.
I agree with that, it seems like much cleaner approach. I also think the problem I've came up with is not critical and it will not occur much. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #7 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- Comment on attachment 55898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55898 Bug 17371 - REST API: add CRUD for biblios Review of attachment 55898: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17371&attachment=55898) ----------------------------------------------------------------- Nice work by the way! ::: Koha/REST/V1/Biblio.pm @@ +45,5 @@
+ my $biblio = Koha::Biblios->find($args->{biblionumber}); + unless ($biblio) { + return $c->$cb({error => "Biblio not found"}, 404); + } + return $c->$cb({ biblio => $biblio->unblessed, items => $biblio->items->unblessed }, 200);
Does this respect OpacHiddenItems preference? @@ +79,5 @@
+ + # mark as onhold if item marked as hold + if (scalar(@{$holds}) > 0) { + $item->{status} = "onhold"; + }
I'm missing the next statement after one of the conditions succeeds. I can see no reason to check for another condition, which can result in not necessary DB querying. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55898|0 |1 is obsolete| | --- Comment #8 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- Created attachment 58995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58995&action=edit Bug 17371 - REST API: add CRUD for biblios Patch to add CRUD to biblios. Test plan: 1) add dependent bug 17004 2) create some staff user with editcatalogue permission 3) play with API with routes explained in bug description 4) run test t/db_dependent/api/v1/biblios.t Signed-off-by: Jiri Kozlovsky <mail@jkozlovsky.cz> Note that I've rebased this patch on top of master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #9 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- (In reply to Jiri Kozlovsky from comment #8)
Created attachment 58995 [details] [review] Bug 17371 - REST API: add CRUD for biblios
Patch to add CRUD to biblios.
Test plan: 1) add dependent bug 17004 2) create some staff user with editcatalogue permission 3) play with API with routes explained in bug description 4) run test t/db_dependent/api/v1/biblios.t
Signed-off-by: Jiri Kozlovsky <mail@jkozlovsky.cz>
Note that I've rebased this patch on top of master
Test plan was changed actually - I've cut off the dependency on bug 17004, which is not really needed for this API to work. Also there is a chance, the 17004 is going to be implemented somehow differently .. see comments till new year. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #10 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- (In reply to Jiri Kozlovsky from comment #7)
Comment on attachment 55898 [details] [review] Bug 17371 - REST API: add CRUD for biblios
Review of attachment 55898 [details] [review]: -----------------------------------------------------------------
Nice work by the way!
::: Koha/REST/V1/Biblio.pm @@ +45,5 @@
+ my $biblio = Koha::Biblios->find($args->{biblionumber}); + unless ($biblio) { + return $c->$cb({error => "Biblio not found"}, 404); + } + return $c->$cb({ biblio => $biblio->unblessed, items => $biblio->items->unblessed }, 200);
Does this respect OpacHiddenItems preference?
I'm going to implement this in next patch - basically just migrate completed work from bug 17007 so that it can be closed as duplicate. This bug has much more to offer.
@@ +79,5 @@
+ + # mark as onhold if item marked as hold + if (scalar(@{$holds}) > 0) { + $item->{status} = "onhold"; + }
I'm missing the next statement after one of the conditions succeeds. I can see no reason to check for another condition, which can result in not necessary DB querying.
I've probably misunderstood something - now I can't see anything being wrong about this chunk of code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #11 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- Created attachment 58996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58996&action=edit Added filtering OPAChiddenItems Test plan: 1) Create OpacHiddenItems rules to hide chosen items 2) Check that regular user doesn't see those items through the API 3) Check that librarian can see them through the API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58995|Bug 17371 - REST API: add |[SIGNED-OFF] Bug 17371 - description|CRUD for biblios |REST API: add CRUD for | |biblios --- Comment #12 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- Comment on attachment 58995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58995 [SIGNED-OFF] Bug 17371 - REST API: add CRUD for biblios Changed original patch name to include [SIGNED-OFF] to be clear what is signed off and what needs to be signed off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #13 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- *** Bug 17007 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- QA tool complains: FAIL t/db_dependent/api/v1/biblios.t OK critic FAIL forbidden patterns forbidden pattern: tab char (line 74) forbidden pattern: tab char (line 70) forbidden pattern: tab char (line 84) forbidden pattern: tab char (line 71) forbidden pattern: tab char (line 85) forbidden pattern: tab char (line 82) forbidden pattern: tab char (line 80) forbidden pattern: tab char (line 83) forbidden pattern: tab char (line 68) forbidden pattern: tab char (line 69) forbidden pattern: tab char (line 66) forbidden pattern: tab char (line 76) forbidden pattern: tab char (line 72) forbidden pattern: tab char (line 86) forbidden pattern: tab char (line 64) forbidden pattern: tab char (line 75) forbidden pattern: tab char (line 67) tests failing: t/db_dependent/api/v1/biblios.t .............. 1/3 substr outside of string at /usr/share/perl5/MARC/File/XML.pm line 561. Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 563. Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 563. Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 565. Use of uninitialized value $enc in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 568. # No tests run! t/db_dependent/api/v1/biblios.t .............. 2/3 # Failed test 'No tests run for subtest "Create biblio"' # at t/db_dependent/api/v1/biblios.t line 77. Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> Christie, Agatha, at /usr/share/perl5/MARC/File/XML.pm line 568. t/db_dependent/api/v1/swagger/definitions.t .. # Failed test 'Columns is nullable in DB, not in swagger file for biblio: datecreated, timestamp' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191 [Bug 18191] REST API: Add endpoint to list valid pickup locations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #15 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- Created attachment 64842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64842&action=edit Bug 17371 - REST API: add CRUD for biblios QA followup Note: Rebased on master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64842|Bug 17371 - REST API: add |Bug 17371 - REST API: add description|CRUD for biblios |CRUD for biblios (QA | |followup) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit | |y.org | Component|Web services |REST api CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |benjamin.rokseth@kul.oslo.k |ity.org |ommune.no -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- CONFLICT (content): Merge conflict in api/v1/swagger/definitions.json I tried to rebase but the tests then fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords| |needs_rfc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: add CRUD for |Add routes for biblios |biblios | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I've added the ''needs_rfc'' keyword to this bug. The community process requires a vote on the RFC, so the dev and interested parties should take care of adding the RFC to the agenda on a dev meeting, and gather support for it. Take a look here: https://wiki.koha-community.org/wiki/REST_api_RFCs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Biblios_endpoint_ | |RFC --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I've added an RFC for everyone to contribute. It is ni the lines of this patches with a broader target use cases in mind. Still WIP but the implementation should be pretty simple. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334 [Bug 21334] Add bibliographic content type definitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Bug 17371 depends on bug 21334, which changed state. Bug 21334 Summary: Add bibliographic content type definitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Bug 17371 depends on bug 21334, which changed state. Bug 21334 Summary: Add bibliographic content type definitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Bug 17371 depends on bug 21334, which changed state. Bug 21334 Summary: Add bibliographic content type definitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18191 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191 [Bug 18191] Add endpoint to list valid pickup locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|benjamin.rokseth@deichman.n |tomascohen@gmail.com |o | Keywords|needs_rfc | --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm taking over this bug, somehow. Will file separate bugs for separate use cases, and ask the original authors to add their comments there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23677 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa@koha-suomi.fi --- Comment #20 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- I have a suggestion to POST and PUT endpoints. At the moment the code doesn't validate or compare coming MARC record. On POST endpoint there should be some kind of validation at least checking that the control numbers exist. On PUT we should check matching rules so libraries can choose what they want to do with the fields. Matcher_id check could be added as an optional parameter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala@helsinki.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24751 CC| |lari.taskula@hypernova.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add routes for biblios |Add routes for biblios | |[OMNIBUS] Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58995|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58996|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64842|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23677 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23677 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 [Bug 23677] Add API route to get a bibliographic record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24909 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909 [Bug 24909] Add public route to get a bibliographic record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Rickard Lindfors <rickard.lindfors@sh.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rickard.lindfors@sh.se --- Comment #21 from Rickard Lindfors <rickard.lindfors@sh.se> --- Hi! We use the API for our discovery to get item information, but that's one api call per item. It would be nice to just use one call from the biblio. How about to add the get functions of this bug as starter, and add the post/put function later? They should be easier to implement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Rickard Lindfors from comment #21)
Hi! We use the API for our discovery to get item information, but that's one api call per item. It would be nice to just use one call from the biblio.
How about to add the get functions of this bug as starter, and add the post/put function later? They should be easier to implement.
See bug 27358. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201 [Bug 28201] Add API routes to update and create biblio record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 [Bug 30790] Add REST API route to list biblios -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30799 [Bug 30799] Add REST API route to update biblio metadata -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31788 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Bug 17371 depends on bug 30790, which changed state. Bug 30790 Summary: Add REST API route to list biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30790 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 [Bug 30790] Add REST API route to list biblios -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Bug 17371 depends on bug 28201, which changed state. Bug 28201 Summary: Add API routes to create biblio record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Bug 17371 depends on bug 30799, which changed state. Bug 30799 Summary: Add REST API route to update biblio metadata https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30799 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- All linked bugs have been resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org