[Bug 5449] New: JSON malformed in Koha - Blocker with jQuery 1.4.x
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5449 Summary: JSON malformed in Koha - Blocker with jQuery 1.4.x Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: blocker Priority: P5 Component: Tools AssignedTo: gmcharlt@gmail.com ReportedBy: brice.sanchez@sys-tech.net QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Created attachment 2789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2789 Patch for JSON bug [EN] After updating jQuery in version 1.4.3, I could not import MARC records with the tools "Stage MARC records for import". Indeed, JSON was malformed, the JSON script did not respect the standard. So I changed all JSON scripts created on Koha. Please note, this problem is a blocker with jQuery 1.4.x but not with 1.3.x as the old version was more permissive. Attached patch. [FR] Après avoir mis à jour jQuery en version 1.4.3, je ne pouvais plus importer de notices MARC avec l'outils "Stage MARC records for import". En effet, les JSON étaient mal formés, ils ne respectaient pas la norme. J'ai donc modifié tous les script créant des JSON sur Koha. Attention, ce problème est bloquant avec jQuery 1.4.x mais pas 1.3.x car l'ancienne version était plus permissive. Ci-joint, le correctif -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5449 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5449 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |brice.sanchez@sys-tech.net -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5449 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-01-12 20:36:12 UTC --- Can you give more details about problem you encountered? I'm working on a branch which includes an upgraded jquery (1.4.4) and I was able to import MARC records without any problem. Could it be a problem with jquery 1.4.3? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5449 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-01-12 20:39:32 UTC --- I should also note that my branch is based on HEAD, not rel_3_2. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5449 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Patch Status|Needs Signoff |Signed Off --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-11 13:42:27 UTC --- Tested on branch 3.2.x with jQuery 1.4.3 I successfully reproduce the bug and the patch solve the problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5449 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-11 19:53:16 UTC --- Owen, can you please test this patch and check it works with 1.4.4 too. If so, ill push it as it fixes it for 1.4.3 without breaking 1.4.4. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5449 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-03-17 18:09:02 UTC ---
Owen, can you please test this patch and check it works with 1.4.4 too.
Can I get some additional information on how to test this? What is broken when it doesn't work? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5449 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2011-03-17 18:30:00 UTC --- I got no JavaScript errors when I tested with jQuery 1.4.4 originally, and I get no JavaScript errors with 1.5 either. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5449 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com Patch Status|Patch Pushed |Signed Off --- Comment #7 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-01 09:43:34 UTC --- This bug is mentioned in: Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x http://lists.koha-community.org/pipermail/koha-patches/2011-March/014028.htm... --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-05-08 20:13:23 UTC --- I am resetting the patch status from "Patch pushed" to "Signed off" because the branch new/bug_5449 still needs to be merged into master. I tested and can confirm that it merges cleanly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5449 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-05-08 20:27:21 UTC --- It is in master now, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5449 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org