[Bug 17262] New: Plack on packages is not having memcached set properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Bug ID: 17262 Summary: Plack on packages is not having memcached set properly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: mirko@abunchofthings.net Using the patches from bug 17261, you will notice the running Plack backends are not getting the MEMCACHED_SERVERS and MEMCACHED_NAMESPACE variables filled as they should. Steps to reproduce: - Be on top of bug 17261 - Have a working memcached setup, plack disbaled (default in kohadevbox) => About page shows: Memcached: Servers: 127.0.0.1:11211 | Namespace: koha_kohadev | Status: running - Enable Plack: sudo koha-plack --enable kohadev sudo koha-plack --start kohadev sudo service apache2 restart - Reload about page => FAIL: You get: Memcached: Servers: undefined| Namespace: undefined | Status: unknown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |17261 CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle.m.hall@gmail.com, | |nick@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261 [Bug 17261] Add memcached configuration info to about.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 55266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55266&action=edit Bug 17262: Inject MEMCACHED_* variables into Plack's env This patch adds two functions to koha-functions.sh to read the MEMCACHED_* variables from configured instances' apache files (the only source for that info for now). It then tweaks koha-plack's start_plack() function so it exports the variables to env before launching starman. The patch seems trivial, but it highlights a bigger problem with our Plack integration as the starman server seems to hang if those environment variables are defined! Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Sorry for adding you all to the CC for this bug, but I think it deserves some urgent attention. Note: The patch itself cannot be pushed without solving the bigger problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Have you seen bug 11921 That shifts the config back out of ENV variables. I feel like signing that off and getting that in will be better than bandaiding what we do now. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #4 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- This is surprising (+ that there were no apparent complains related to this so far from people running this in production), plack + Cache::Memory is a really bad combination for so many reasons.. I thought that only the CLI scripts like updatedatabase.pl etc. were affected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17261 Depends on|17261 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261 [Bug 17261] Add memcached configuration info to about.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Chris Cormack from comment #3)
Have you seen bug 11921
That shifts the config back out of ENV variables. I feel like signing that off and getting that in will be better than bandaiding what we do now.
What do you think?
With 11921 pushed, is this obsolete now? Still needed? Needs adjustment? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Mirko Tietgen from comment #5)
(In reply to Chris Cormack from comment #3)
Have you seen bug 11921
That shifts the config back out of ENV variables. I feel like signing that off and getting that in will be better than bandaiding what we do now.
What do you think?
With 11921 pushed, is this obsolete now? Still needed? Needs adjustment?
Still needed for stable branches, not master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55266|0 |1 is obsolete| | --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 55742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55742&action=edit Bug 17262: Inject MEMCACHED_* variables into Plack's env This patch adds two functions to koha-functions.sh to read the MEMCACHED_* variables from configured instances' apache files (the only source for that info for now). It then tweaks koha-plack's start_plack() function so it exports the variables to env before launching starman. The patch seems trivial, but it highlights a bigger problem with our Plack integration as the starman server seems to hang if those environment variables are defined! Sponsored-by: ByWater Solutions Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |16.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 16.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #10 from Mirko Tietgen <mirko@abunchofthings.net> --- This patch was reverted from the 16.05.04.01 package by request because it would break instances running Plack. I will skip it for 3.22.11 too. Please sort this out until next release, either by a followup that fixes the problem or by reverting it officially from stable and oldstable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Mirko Tietgen from comment #10)
This patch was reverted from the 16.05.04.01 package by request because it would break instances running Plack. I will skip it for 3.22.11 too. Please sort this out until next release, either by a followup that fixes the problem or by reverting it officially from stable and oldstable.
Could you detail what is "the problem"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- I think the problem is described in bug 17342 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17342 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #13 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Jonathan Druart from comment #11)
Could you detail what is "the problem"?
Tomás said there is a circular dependency IIRC, and asked me to remove it from 16.05.04. Which I did and uploaded a new 16.05.04.01 while I was travelling, I had no time to look into the actual problem. He should be able to explain. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #14 from Frédéric Demians <frederic@tamil.fr> --- It's either not clear to me whether this patch has to be removed from 16.05 or completed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Frédéric Demians from comment #14)
It's either not clear to me whether this patch has to be removed from 16.05 or completed.
It would be better to fix it, see bug 17342 for a patch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org