https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |fridolin.somers@biblibre.co | |m --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- I'd like to sign this one but it does not apply anymore because of changes on breadcrumbs. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119597|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123672&action=edit Bug 28149: Improve internationalization and formatting on background jobs page This patch adds some logic to the background jobs template in order to make job status and job type translatable. Output of dates has been changed to use the KohaDates plugin, using the "with_hours" flag. This patch also modifies the page title and breadcrumbs so that if one is viewing the details of a background job the page title and breadcrumbs reflect this. I've also added inclusion of the preferences search form in the header, the default for administration pages which don't have their own search. To test, apply the patch and go to Administration -> Background jobs. - If there are no background jobs listed, submit at least one batch of bibliograhpic records and at least one batch of authorty records for modification (Tools -> Batch record modification). - In the table of background jobs, the status should be shown correctly. If you see it capitalized ("Finished") you're seeing the new string in the template which will be used for translation. - In the "Type" column, you should see either "Batch authority record modification" or "Batch bibliographic record modification" - In the "Queued," "Started," and "Ended" columns the date should be formatted according to your system's dateformat system preference, including the time. - View the details of a background job. The same changes to status and type should be seen on this page, as well as the date formatting of the date fields. - In the breadcrumbs, confirm that it shows a link to the background jobs page followed by "Details if job #X". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123870&action=edit Bug 28149: (follow-up) Add string for job status "new" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123672|0 |1 is obsolete| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123983&action=edit Bug 28149: Improve internationalization and formatting on background jobs page This patch adds some logic to the background jobs template in order to make job status and job type translatable. Output of dates has been changed to use the KohaDates plugin, using the "with_hours" flag. This patch also modifies the page title and breadcrumbs so that if one is viewing the details of a background job the page title and breadcrumbs reflect this. I've also added inclusion of the preferences search form in the header, the default for administration pages which don't have their own search. To test, apply the patch and go to Administration -> Background jobs. - If there are no background jobs listed, submit at least one batch of bibliograhpic records and at least one batch of authorty records for modification (Tools -> Batch record modification). - In the table of background jobs, the status should be shown correctly. If you see it capitalized ("Finished") you're seeing the new string in the template which will be used for translation. - In the "Type" column, you should see either "Batch authority record modification" or "Batch bibliographic record modification" - In the "Queued," "Started," and "Ended" columns the date should be formatted according to your system's dateformat system preference, including the time. - View the details of a background job. The same changes to status and type should be seen on this page, as well as the date formatting of the date fields. - In the breadcrumbs, confirm that it shows a link to the background jobs page followed by "Details if job #X". Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26080 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123983|0 |1 is obsolete| | Attachment #123984|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 124517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124517&action=edit Bug 28149: Improve internationalization and formatting on background jobs page This patch adds some logic to the background jobs template in order to make job status and job type translatable. Output of dates has been changed to use the KohaDates plugin, using the "with_hours" flag. This patch also modifies the page title and breadcrumbs so that if one is viewing the details of a background job the page title and breadcrumbs reflect this. I've also added inclusion of the preferences search form in the header, the default for administration pages which don't have their own search. To test, apply the patch and go to Administration -> Background jobs. - If there are no background jobs listed, submit at least one batch of bibliograhpic records and at least one batch of authorty records for modification (Tools -> Batch record modification). - In the table of background jobs, the status should be shown correctly. If you see it capitalized ("Finished") you're seeing the new string in the template which will be used for translation. - In the "Type" column, you should see either "Batch authority record modification" or "Batch bibliographic record modification" - In the "Queued," "Started," and "Ended" columns the date should be formatted according to your system's dateformat system preference, including the time. - View the details of a background job. The same changes to status and type should be seen on this page, as well as the date formatting of the date fields. - In the breadcrumbs, confirm that it shows a link to the background jobs page followed by "Details if job #X". Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.04 released in| | CC| |kyle@bywatersolutions.com --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.04 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.