[Bug 31610] New: When creating a guarantee, patron messaging preferences should be copied to this account from the category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Bug ID: 31610 Summary: When creating a guarantee, patron messaging preferences should be copied to this account from the category Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When creating a guarantee, patron messaging preferences should be copied to this account from the category. Steps: Have a guarantor. Create a guarantee. Koha will use the CHILD patron category to assign this guarantee, but will not copy over the message preferences from this CHILD patron category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Lisette Scheer <lisettepalouse+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisettepalouse+koha@gmail.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Mwoo <mary.woodward@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mary.woodward@bedfordtx.gov --- Comment #1 from Mwoo <mary.woodward@bedfordtx.gov> --- YES Please!!!! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 161595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161595&action=edit Bug 31610: Set messaging preferences in the new guarantee form On patron detail page, if the patron is an adult, there is a button "Add guarantee". It takes you to the patron creation form. In this form one of the "can be guarantee" category will be automatically selected, but the messaging preferences will not be automatically set to the default messaging preferences for this category. This patch fixes that. Test plan: 1. Make sure all the "can be guarantee" categories have default messaging preferences. The category dropdown list is not sorted so it's not always the same category that appear first and is automatically selected. Also make sure that preference borrowerRelationship is not empty 2. Find a patron whose category's type is Adult and go to its detail page 3. Click on "Add guarantee" in the toolbar 4. Verify that the messaging preferences are automatically set and match the selected category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Kelly McElligott <kelly@bywatersolutions.com> --- I tested this and I am not finding this to work. I create a patron that has default messaging preferences (Adult), and then I create a guarantee (kid) for this account. Now in Koha Admin, Patron Categories, the Kid category has specific messaging preferences as does the adult, and these messaging preferences are not the same. When I create the guarantee, no messaging preferences copy over. When I go back and edit the guarantee, after saving it, I do get a popup message asking if I want to copy messaging preferences over, I clicked ok. Nothing happens. Even if I go into an already created Adult patron, I get the same popup to update/copy messaging preferences, nothing updates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Did you clean your browser cache before testing ? As the patch only changes a JS file, it's possible that the browser loaded the old version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 --- Comment #5 from Kelly McElligott <kelly@bywatersolutions.com> --- I am using the sandbox- refreshed my cache- no luck. I logged out and logged back in, no luck. I also tried another browser, no luck. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 168051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168051&action=edit Bug 31610: Set messaging preferences only on "add_form" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> ---
Even if I go into an already created Adult patron, I get the same popup to update/copy messaging preferences, nothing updates.
The popup should not appear. This is a bug caused by the first patch and fixed by the 2nd patch. However, the fact that nothing updates when you click 'OK' in the popup probably means that there is something wrong in the AJAX request, but I think it's not caused by patches on this bug. Can you try on master (without patches of this bug): edit a borrower, change it's category (popup should appear, click OK), and verify if the category preferences were applied ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161595|0 |1 is obsolete| | --- Comment #8 from Olivier V <ovezina@inlibro.com> --- Created attachment 171427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171427&action=edit Bug 31610: Set messaging preferences in the new guarantee form On patron detail page, if the patron is an adult, there is a button "Add guarantee". It takes you to the patron creation form. In this form one of the "can be guarantee" category will be automatically selected, but the messaging preferences will not be automatically set to the default messaging preferences for this category. This patch fixes that. Test plan: 1. Make sure all the "can be guarantee" categories have default messaging preferences. The category dropdown list is not sorted so it's not always the same category that appear first and is automatically selected. Also make sure that preference borrowerRelationship is not empty 2. Find a patron whose category's type is Adult and go to its detail page 3. Click on "Add guarantee" in the toolbar 4. Verify that the messaging preferences are automatically set and match the selected category. Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168051|0 |1 is obsolete| | --- Comment #9 from Olivier V <ovezina@inlibro.com> --- Created attachment 171428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171428&action=edit Bug 31610: Set messaging preferences only on "add_form" Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ovezina@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org --- Comment #10 from Juliet Heltibridle <jheltibridle@rcplib.org> --- I tried to test this, but it looks like Bug 38429 is affecting how this works (in a good way). That patch makes it so you pick the guarantee category when you select add guarantee, and makes it apply the correct notice preferences for whatever patron category you choose for the guarantee, which I believe would be the desired result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Up ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com --- Comment #12 from Esther Melander <esther.melander@bywatersolutions.com> --- Bug 38429 (backported to 24.11.02) appears to solve the problem but only when there is more than one patron category that can be a guarantee. However, the problem persists when there is only one patron category that can be a guarantee. To replicate: 1. Create an adult patron category and assign default messaging preferences. 2. Create a child patron category. Check the option "can be a guarantee" and assign default messaging preferences. 3. Make sure there are no other patron categories that can be a guarantee. 4. Find an adult patron and click on +add guarantee. Notice the child patron category is correctly assigned but the default messaging preferences do not come through. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31610 Justin Swink <jswink@littleelm.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jswink@littleelm.org --- Comment #13 from Justin Swink <jswink@littleelm.org> --- Thanks to Esther, I was able to use the recommendation of Bug 38429 to get around the issue. However, since we do not have any other patron types that we allow to be guarantees, I had to create a new one specifically for this purpose. But so that no staff members accidentally chooses this new option when they create a guarantee, I had to make if explicitly clear that this patron type is not to be used. I title the patron category "Do not use this option (for bug fix)". -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org