https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 Noémie Labine <noemie.labine@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine@collecto.ca --- Comment #1 from Noémie Labine <noemie.labine@collecto.ca> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147020&action=edit Bug 22428: Change datatype of field_value to text This patch changes the datatype of the field_value column in marc_modification_template_actions to "text". This is to stop text strings longer than 100 characters from being chopped short and allow longer strings up to 65,000 characters. Test plan: 1) Follow the same steps outlined by Caroline in the problem statement 2) Apply patch 3) Follow the steps again and this time the text should upload with no problem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147021&action=edit Bug 22428: Attach DBIC file DBIC file for updated column Test plan as above -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147020|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 147074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147074&action=edit Bug 22428: Change datatype of field_value to text This patch changes the datatype of the field_value column in marc_modification_template_actions to "text". This is to stop text strings longer than 100 characters from being chopped short and allow longer strings up to 65,000 characters. Test plan: 1. Create a MARC modification template with a text value over 100 characters 1.1 Go to Cataloging > MARC modification templates 1.2. Click on 'New template' 1.3. Name your new template and click on 'Submit' 1.4. Click on 'New action' 1.5. Enter the following information in the form - 'Add new' - field(s): 856 y - with value: Organization-wide access - sign on to OnePass / Accès à l'échelle de l'organisation - Ouvrez une session (OnePass) 1.6. Click on Add action --> Note that the text is cut in the displayed table 'Organization-wide access - sign on to OnePass / Accès à l'échelle de l'organisation - Ouvrez une ses' 2. Use the MARC modification template on a bibliographic record 2.1 Make a search in the catalog 2.2. Click on the title to go to the detailed record 2.3. Click 'Edit' and choose 'Modify record using template' 2.4. Choose the template from step 1 from the drop-down menu 2.5. Click on 'Show MARC' to see the result of the modification (the added line is usually at the bottom) --> Note that the text is still cut after 100 characters (so not only a display bug) 2.6. Click on 'Close' 2.7. Click on 'Modify selected records' 2.8. Click on 'View detail of the enqueued job' 2.9. Click on the biblionumber under 'Detailed messages' to see the modified record --> In the detailed record, the 856y field is under 'Online resources', note that the text is still cut 3. Apply patch, update database 4. Redo steps 1 and 2 --> On step 1.6. the text is displayed in full in the table --> On step 2.5. the text is displayed in full in the MARC preview --> On step 2.9. the text is displayed in full in the detailed record, under Online resources Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> I updated the test plan for new functionalities in master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Some things had changed in master since my original test plan (some things moved, some new functionalities reduced the test plan to less steps), so I updated it a bit. I hope that's ok -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147074|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147374&action=edit Bug 22428: Change datatype of field_value to text This patch changes the datatype of the field_value column in marc_modification_template_actions to "text". This is to stop text strings longer than 100 characters from being chopped short and allow longer strings up to 65,000 characters. Test plan: 1) Follow the same steps outlined by Caroline in the problem statement 2) Apply patch 3) Follow the steps again and this time the text should upload with no problem Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147376&action=edit Bug 22428: (QA follow-up) Add exec flag to update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Seems to be only backend stuff, nothing to add/change in the manual. -- You are receiving this mail because: You are watching all bug changes.