[Bug 38712] New: Order My Lists options alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Bug ID: 38712 Summary: Order My Lists options alphabetically Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: chloe.zermatten@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org In the top header navigation menu on the Koha OPAC, sets the order of the 'My Lists' dropdown to be sorted alphabetically instead of by modification date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Chloe Zermatten <chloe.zermatten@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |chloe.zermatten@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Chloe Zermatten <chloe.zermatten@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18148 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 --- Comment #1 from Chloe Zermatten <chloe.zermatten@ptfs-europe.com> --- Created attachment 175497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175497&action=edit Bug 38712: order My Lists options alphabetically In the top header navigation menu, sets the order of the 'My Lists' dropdown to be alphabetical. Test plan: - on the Koha OPAC, navigate to /cgi-bin/koha/opac-shelves.pl - create a few public and private lists - open the 'My List' dropdown in the top navigation menu - notice that the lists appear in the order they were created - apply the patch - open the 'My List' dropdown in the top navigation - notice that the lists are now sorted alphabetically -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Chloe Zermatten <chloe.zermatten@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Probably a sensible thing to do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 175583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175583&action=edit Bug 38712: Order public and private lists alphabetically In the OPAC top header navigation menu, public and private lists are ordered by the date created, instead of alphabetically. Test plan: 1. On the Koha OPAC, login and navigate to Your account > Lists (/cgi-bin/koha/opac-shelves.pl). 2. Create a few public and private lists. 3. Open the lists dropdown in the top navigation menu. 4. Notice that the lists appear in the order they were created. 5. Apply the patch. 6. Refresh the page and open the lists dropdown in the top navigation. 7. Notice that the lists are now sorted alphabetically. 8. Log out and notice that the lists are now sorted alphabetically. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #175497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from David Nind <david@davidnind.com> --- Hi Chloe. This is a good idea - as it matches how the lists are ordered under Your account > Lists. I amended the patch commit message and was going to sign off. However, I noted that if you log out, you get an error and the OPAC is unusable: Can't use an undefined value as a HASH reference at /kohadevbox/koha/Koha/ Virtualshelves.pm line 200 .... So I've changed the status to Failed QA. David Nind -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 --- Comment #5 from Chloe Zermatten <chloe.zermatten@ptfs-europe.com> --- Created attachment 175596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175596&action=edit Bug 38712: order My Lists options alphabetically In the top header navigation menu, sets the order of the 'My Lists' dropdown to be alphabetical. Note: this patch was updated to also handle cases where $params->{search_attributes} is not defined. Test plan: - on the Koha OPAC, navigate to /cgi-bin/koha/opac-shelves.pl - create a few public and private lists - open the 'My List' dropdown in the top navigation menu - notice that the lists appear in the order they were created - apply the patch - open the 'My List' dropdown in the top navigation - notice that the lists are now sorted alphabetically fix: handle undefined search attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Chloe Zermatten <chloe.zermatten@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 --- Comment #6 from Chloe Zermatten <chloe.zermatten@ptfs-europe.com> --- Hello David, Thank you for the feedback! I have amended the patch accordingly - hopefully this should take care of the issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175583|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Chloe Zermatten from comment #6)
Hello David,
Thank you for the feedback! I have amended the patch accordingly - hopefully this should take care of the issue
Thanks Chloe! I've retested, and that fixes the error. However, if you are logged out, the public lists aren't sorted alphabetically 8-(... David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Chloe Zermatten <chloe.zermatten@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175596|0 |1 is obsolete| | --- Comment #8 from Chloe Zermatten <chloe.zermatten@ptfs-europe.com> --- Created attachment 175643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175643&action=edit Bug 38712: order My Lists options alphabetically In the top header navigation menu, sets the order of the 'My Lists' dropdown to be alphabetical. Note: this patch was updated to also handle cases where $params->{search_attributes} is not defined, and also to ensure that it also applies to the list of public lists show to users who are not logged in. Test plan: - on the Koha OPAC, navigate to /cgi-bin/koha/opac-shelves.pl - create a few public and private lists - open the 'My List' dropdown in the top navigation menu - notice that the lists appear in the order they were created - apply the patch - open the 'My List' dropdown in the top navigation - notice that the lists are now sorted alphabetically -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Chloe Zermatten <chloe.zermatten@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175643|0 |1 is obsolete| | --- Comment #9 from Chloe Zermatten <chloe.zermatten@ptfs-europe.com> --- Created attachment 175646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175646&action=edit Bug 38712: order My Lists options alphabetically In the top header navigation menu, sets the order of the 'My Lists' dropdown to be alphabetical. Note: this patch was updated to also handle cases where $params->{search_attributes} is not defined, and well as ordering public lists when the user is not logged in. Test plan: - on the Koha OPAC, navigate to /cgi-bin/koha/opac-shelves.pl - create a few public and private lists - open the 'My List' dropdown in the top navigation menu - notice that the lists appear in the order they were created - apply the patch - open the 'My List' dropdown in the top navigation - notice that the lists are now sorted alphabetically fix: handle undefined search attributes order list when logged out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175646|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 175681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175681&action=edit Bug 38712: order My Lists options alphabetically In the top header navigation menu, sets the order of the 'My Lists' dropdown to be alphabetical. Note: this patch was updated to also handle cases where $params->{search_attributes} is not defined, and well as ordering public lists when the user is not logged in. Test plan: - on the Koha OPAC, navigate to /cgi-bin/koha/opac-shelves.pl - create a few public and private lists - open the 'My List' dropdown in the top navigation menu - notice that the lists appear in the order they were created - apply the patch - open the 'My List' dropdown in the top navigation - notice that the lists are now sorted alphabetically fix: handle undefined search attributes order list when logged out Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Text to go in the| |This fixes the display of release notes| |the lists menu on the OPAC | |header - public and private | |lists (when logged in) are | |now listed in alphabetical | |order, instead of the date | |created. Status|Needs Signoff |Signed Off --- Comment #11 from David Nind <david@davidnind.com> --- Thanks Chloe! I've added a release note, and changed this to a normal bug, instead of an enhancement. I would suggest formatting the commit message using the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages, for example: - Sentence case for the bug title - Number the test plan steps (See comment# 3 for how I previously updated the commit message.) Good luck with the QA step! David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Signed Off |Failed QA --- Comment #12 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Thanks for submitting the bug report and patch, Chloe! For changes to .pm files, we also require unit tests (see https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL17:_Unit_tests_ar... and https://wiki.koha-community.org/wiki/Unit_Tests). It seems odd to me to make a sorting change in pm files instead of at the script or templating level, so you might want to look into that possibility (if you haven't already) before investing time on unit tests. I'm afraid I'm not familiar enough with My Lists or these parts of the code to comment on that with any certainty, though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 --- Comment #13 from Chloe Zermatten <chloe.zermatten@ptfs-europe.com> --- Hi Emily and David, Thank you both for the feedback! I will be on leave over the holiday period, so I will pick this back up once I get back. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Maura Stephens <maura.stephens@atu.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maura.stephens@atu.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175681|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 --- Comment #14 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Created attachment 200501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200501&action=edit Bug 38712: order My Lists options alphabetically In the top header navigation menu, sets the order of the 'My Lists' dropdown to be alphabetical. Note: this patch was updated to also handle cases where $params->{search_attributes} is not defined, and well as ordering public lists when the user is not logged in. Test plan: 1. on the Koha OPAC, navigate to /cgi-bin/koha/opac-shelves.pl 2. create a few public and private lists 3. open the 'My List' dropdown in the top navigation menu 4. notice that the lists appear in the order they were created 5. apply the patch 6. open the 'My List' dropdown in the top navigation 7. notice that the lists are now sorted alphabetically -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 --- Comment #15 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Created attachment 200502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200502&action=edit Bug 38712: test: shelf list ordering Add shelf list ordering test in Auth.t and in VirtualShelves.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|emily.lamancusa@montgomeryc |lucas@bywatersolutions.com |ountymd.gov | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This looks right. Howeever, I am filing Bug 43222 as none of this code regarding lists belongs in Auth.pm: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43222 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43222 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43222 [Bug 43222] Remove virtualshelves code from Auth.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Setting this one to BLOCKED because, in my opinion, none of this code should be in Auth.pm -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org