[Bug 31294] New: Article requests: Mandatory subfields in OPAC don't show they are required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Bug ID: 31294 Summary: Article requests: Mandatory subfields in OPAC don't show they are required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org There are 3 system preference to mark fields mandatory in the article request form for different use cases: ArticleRequestsMandatory* If you set fields to mandatory, they will trigger a message on saving, but they are missing the visible markup so you can tell right away that they are mandatory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 139013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139013&action=edit Bug 31294: Show "Required" label on mandatory fields This patch adds "Required" label on mandatory fields for Article Requests 0. Apply the patch 1. koha-plack --restart kohadev 2. Change syspref 'ArticleRequests' to 'Enable' 3. Change syspref 'ArticleRequestsMandatoryFields' to '[Select all]' 4. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 5. Click "Request article" for "Gairm" 6. Note that "Title", "Author", "Volume", "Issue", "Date", "Pages", and "Chapters" all say required 7. Change syspref 'ArticleRequestsMandatoryFields' to 'Title' and 'Author' 8. Go to http://localhost:8080/cgi-bin/koha/opac-request-article.pl?biblionumber=29 9. Note that only "Title" and "Author" say required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139013|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 139023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139023&action=edit Bug 31294: Show "Required" label on mandatory fields This patch adds "Required" label on mandatory fields for Article Requests 0. Apply the patch 1. koha-plack --restart kohadev 2. Change syspref 'ArticleRequests' to 'Enable' 3. Change syspref 'ArticleRequestsMandatoryFields' to '[Select all]' 4. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 5. Click "Request article" for "Gairm" 6. Note that "Title", "Author", "Volume", "Issue", "Date", "Pages", and "Chapters" all say required 7. Change syspref 'ArticleRequestsMandatoryFields' to 'Title' and 'Author' 8. Go to http://localhost:8080/cgi-bin/koha/opac-request-article.pl?biblionumber=29 9. Note that only "Title" and "Author" say required Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139023|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139055&action=edit Bug 31294: Show "Required" label on mandatory fields This patch adds "Required" label on mandatory fields for Article Requests 0. Apply the patch 1. koha-plack --restart kohadev 2. Change syspref 'ArticleRequests' to 'Enable' 3. Change syspref 'ArticleRequestsMandatoryFields' to '[Select all]' 4. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 5. Click "Request article" for "Gairm" 6. Note that "Title", "Author", "Volume", "Issue", "Date", "Pages", and "Chapters" all say required 7. Change syspref 'ArticleRequestsMandatoryFields' to 'Title' and 'Author' 8. Go to http://localhost:8080/cgi-bin/koha/opac-request-article.pl?biblionumber=29 9. Note that only "Title" and "Author" say required Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org