[Bug 21174] New: Sysprefs to enable the opening of OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Bug ID: 21174 Summary: Sysprefs to enable the opening of OPAC cart in one click Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Instead of having to click on the OPAC cart icon, then having to click on the 'Items in your cart: ..' box before the cart popup loads it would be nice to give libraries control if they want the cart popup to appear directly after the cart icon is clicked upon. Implementing a syspref, defaulted to 'false' to enable one click cart opening would libraries allow one click cart opening without having to manually alter the JS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77550&action=edit Bug 21174 - Implemented syspref to enable the loading of cart popup on one click Sponsored-By: Toi Ohomai Insitute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |alexbuckley@catalyst.net.nz Status|NEW |ASSIGNED --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I will amend the commit message shortly to contain a test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77550|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77642&action=edit Bug 21174 - Implemented syspref to enable the loading of cart popup on one click Test plan: 1. In Koha OPAC click on the cart icon (making sure to have items in the cart and the dropdown box 'Items in your cart:..' appears. 2. Click this dropdown and the cart popup appears. 3. Confirm you can successfully remove items from and empty the cart 4. Apply patch 5. Restart memcached, plack and in koha-shell run ./updatedatabase.pl 6. By default the new syspref in this patch is turned off. Therefore repeat steps: 1,2,3 and confirm they work the same as before you applied the commit 7. In Koha staff client go to Administration->Global system preferences and enable the 'EnableOneClickToOpenCartPopup' preference 8. Back in the OPAC click on the cart icon (making sure to have items in the cart) and notice no 'Items in your: ..' dropdown appears instead the cart popup loads straight away. 9. Confirm the items in your cart is displayed by the cart popup 10. Confirm you can remove items from/empty the cart Sponsored-By: Toi Ohomai Insitute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Amended commit added containing a test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77684&action=edit Bug 21174: (alternate) Sysprefs to enable the opening of OPAC cart in one click This is an alternate patch which would replace the proposed changes to masthead.inc, opac-bottom.inc, opac-basket.tt, and basket.js. This patch slightly changes the markup in masthead.inc so that the Cart link doesn't try to interpret it as a dropdown trigger, and switches out the ID attribute so that it triggers the right action from basket.js. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Alex: I think my proposed patch would simplify the change you want to make. See if it works for you. Your patch is missing an update to the database, and I think that's causing a blocking JavaScript error. I'm going to mark this failed QA for that. BUT... Does anyone really love the way it currently works? Maybe we should just make this updated interaction the default? I think it would be worth asking on the Koha mailing list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 for asking the mailing list, the current behaviour causes a bit of confusion here and there -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 78006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78006&action=edit Bug 21174 - Added missing atomicupdate Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78006|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 78007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78007&action=edit Bug 21174 - Syspref for choosing to load cart popup upon one click on the cart icon. Instead of OPAC users having to click on the cart icon, then having to click on the dropdown box 'Items in your cart:..' to load the cart popup with this syspref enabled OPAC users only need to click once on theOPAC cart icon and the cart popup loads. Test plan: 1. In Koha OPAC click on the cart icon (making sure to have items in the cart and the dropdown box 'Items in your cart:..' appears. 2. Click this dropdown and the cart popup appears. 3. Confirm you can successfully remove items from and empty the cart 4. Apply patch 5. Restart memcached, plack and in koha-shell run ./updatedatabase.pl 6. By default the new syspref in this patch is turned off. Therefore repeat steps: 1,2,3 and confirm they work the same as before you applied the commit 7. In Koha staff client go to Administration->Global system preferences and enable the 'EnableOneClickToOpenCartPopup' preference 8. Back in the OPAC click on the cart icon (making sure to have items in the cart) and notice no 'Items in your: ..' dropdown appears instead the cart popup loads straight away. 9. Confirm the items in your cart is displayed by the cart popup 10. Confirm you can remove items from/empty the cart Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77642|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77684|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78007|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 78008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78008&action=edit Bug 21174: (alternate) Sysprefs to enable the opening of OPAC cart in one click This is an alternate patch which would replace the proposed changes to masthead.inc, opac-bottom.inc, opac-basket.tt, and basket.js. This patch slightly changes the markup in masthead.inc so that the Cart link doesn't try to interpret it as a dropdown trigger, and switches out the ID attribute so that it triggers the right action from basket.js. Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 78009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78009&action=edit Bug 21174 - Syspref for choosing to load cart popup upon one click on the cart icon. Instead of OPAC users having to click on the cart icon, then having to click on the dropdown box 'Items in your cart:..' to load the cart popup with this syspref enabled OPAC users only need to click once on theOPAC cart icon and the cart popup loads. Test plan: 1. In Koha OPAC click on the cart icon (making sure to have items in the cart and the dropdown box 'Items in your cart:..' appears. 2. Click this dropdown and the cart popup appears. 3. Confirm you can successfully remove items from and empty the cart 4. Apply patch 5. Restart memcached, plack and in koha-shell run ./updatedatabase.pl 6. By default the new syspref in this patch is turned off. Therefore repeat steps: 1,2,3 and confirm they work the same as before you applied the commit 7. In Koha staff client go to Administration->Global system preferences and enable the 'EnableOneClickToOpenCartPopup' preference 8. Back in the OPAC click on the cart icon (making sure to have items in the cart) and notice no 'Items in your: ..' dropdown appears instead the cart popup loads straight away. 9. Confirm the items in your cart is displayed by the cart popup 10. Confirm you can remove items from/empty the cart Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78009|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 78010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78010&action=edit Bug 21174 - Syspref for choosing to load cart popup upon one click on the cart icon. Instead of OPAC users having to click on the cart icon, then having to click on the dropdown box 'Items in your cart:..' to load the cart popup with this syspref enabled OPAC users only need to click once on theOPAC cart icon and the cart popup loads. Test plan: 1. In Koha OPAC click on the cart icon (making sure to have items in the cart and the dropdown box 'Items in your cart:..' appears. 2. Click this dropdown and the cart popup appears. 3. Confirm you can successfully remove items from and empty the cart 4. Apply patch 5. Restart memcached, plack and in koha-shell run ./updatedatabase.pl 6. By default the new syspref in this patch is turned off. Therefore repeat steps: 1,2,3 and confirm they work the same as before you applied the commit 7. In Koha staff client go to Administration->Global system preferences and enable the 'EnableOneClickToOpenCartPopup' preference 8. Back in the OPAC click on the cart icon (making sure to have items in the cart) and notice no 'Items in your: ..' dropdown appears instead the cart popup loads straight away. 9. Confirm the items in your cart is displayed by the cart popup 10. Confirm you can remove items from/empty the cart Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21173, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21241, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21159 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Owen and Katrin Thanks, Owen I have taken a look at your commit and signed off on it. I have also added a new commit containing the atomicupdate file and some changes to basket.js fixing a few minor bugs. Now when both commits the JS error is not being thrown, and so I have reset this back to 'Needs signoff'. Can you please take a look/test at my new commit? Additionally, as you may have seen I have asked the general and dev mailing lists about what peoples thoughts on the default cart popup opening process is, and for feedback on changing the default behavior for opening the cart popup to just clicking on the cart icon once to load the cart popup. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Hi all, about the question asked on mailing lists: I think the default behaviour change to one click to show the cart does make sense. So I am for it ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Elaine Bradtke <eb@efdss.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb@efdss.org --- Comment #15 from Elaine Bradtke <eb@efdss.org> --- Yes, the fewer clicks the better. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21249 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20678 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fewer clicks++ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jesse@bywatersolutions.com --- Comment #17 from Jesse Maseto <jesse@bywatersolutions.com> --- PATCH DOESNT APPLY. Applying: Bug 21174: (alternate) Sysprefs to enable the opening of OPAC cart in one click Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Failed to merge in the changes. Patch failed at 0001 Bug 21174: (alternate) Sysprefs to enable the opening of OPAC cart in one click The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21174-alternate-Sysprefs-to-enable-the-opening-vGL1MP.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Alex, can you provide a new patch changing the default behaviour (no syspref needed) plz? We are getting closer to the freeze dates and it would be nice to see this go in! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78008|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78010|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sysprefs to enable the |Change default behavior to |opening of OPAC cart in one |open OPAC cart in one click |click | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #19 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 79647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79647&action=edit Bug 21174 - Open the OPAC cart with one click by default Feedback from the Koha mailing list in Aug 2018 showed there was widespread concensus for making the default behaviour of the OPAC cart to be to open with one click, rather than clicking on the cart icon then on the dropdown box to load the cart popup. This commit is a combination of Owen Leonard's alternative patch (slightly changing the markup in masthead.inc) and my work to remove the dropdown elements from the template and basket.js Test plan: 1. In Koha OPAC click on the cart icon (making sure to have items in the cart and the dropdown box 'Items in your cart:..' appears. 2. Click this dropdown and the cart popup appears. 3. Confirm you can successfully remove items from and empty the cart 4. Apply patch 5. Restart memcached, and plack 6. Click on the cart icon (making sure to have items in the cart) and notice no 'Items in your: ..' dropdown appears instead the cart popup loads straight away. 7. Confirm the items in your cart are displayed by the cart popup 8. Confirm you can remove items from/empty the cart, and that as you do this the number of cart items shown by the number to the right of the cart icon changes accordingly Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #20 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Katrin Fischer in comment 18): Thanks for the reminder Katrin! Apologies for the display. I have attached a patch making clicking on the OPAC cart icon once to load the cart popup the default behavior (no syspref), with also incorporates Owen's work from his alternative patch. Please test, as you say it would be great to get this into master :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79647|0 |1 is obsolete| | --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79714&action=edit Bug 21174: Open the OPAC cart with one click by default Feedback from the Koha mailing list in Aug 2018 showed there was widespread concensus for making the default behaviour of the OPAC cart to be to open with one click, rather than clicking on the cart icon then on the dropdown box to load the cart popup. This commit is a combination of Owen Leonard's alternative patch (slightly changing the markup in masthead.inc) and my work to remove the dropdown elements from the template and basket.js Test plan: 1. In Koha OPAC click on the cart icon (making sure to have items in the cart and the dropdown box 'Items in your cart:..' appears. 2. Click this dropdown and the cart popup appears. 3. Confirm you can successfully remove items from and empty the cart 4. Apply patch 5. Restart memcached, and plack 6. Click on the cart icon (making sure to have items in the cart) and notice no 'Items in your: ..' dropdown appears instead the cart popup loads straight away. 7. Confirm the items in your cart are displayed by the cart popup 8. Confirm you can remove items from/empty the cart, and that as you do this the number of cart items shown by the number to the right of the cart icon changes accordingly Sponsored-By: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Is this message became obsolete? var MSG_IN_YOUR_CART = _("Items in your cart: "); I do not manage to display it (which means we may need to remove more code). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also found a bug: >From the search result page: - "Add to cart" - "Add to cart" (another one) => Cart displays 2 elements - OK - "(remove)" => Cart displays nothing - KO must display 1 (maybe on master as well) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #23)
Also found a bug: From the search result page: - "Add to cart" - "Add to cart" (another one) => Cart displays 2 elements - OK - "(remove)" => Cart displays nothing - KO must display 1
(maybe on master as well)
I have opened bug 21479 (with a fix). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #25 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Jonathan Druart in comment #22) Hi Jonathan Yes, that message is now obsolete with the cart dropdown option now being removed. I am attaching another commit which removes the assignment of the MSG_IN_YOUR_CART (in opac-bottom.inc) and the use of it in the updateBasket() in opac-tmpl/bootstrap/js/basket.js. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #26 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 79856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79856&action=edit Bug 21174: Removed MSG_IN_YOUR_CART and its usage in OPAC JS The 'Items in your cart' message is obsolete with the cart dropdown box being removed. Therefore the assignment of this text into the MSG_IN_YOUR_CART variable (which is done in the opac-bottom.inc), and the use of the MSG_IN_YOUR_CART variable in the updateBasket() function (in the OPAC's basket.js) has been removed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #27 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Can the additional patch removing unneccessary code related to the MSG_IN_YOUR_CODE message please be tested. Thanks :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21479 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21479 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21479 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479 [Bug 21479] Removing from cart removes 2 items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79714|0 |1 is obsolete| | Attachment #79856|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80293&action=edit Bug 21174: Open the OPAC cart with one click by default Feedback from the Koha mailing list in Aug 2018 showed there was widespread concensus for making the default behaviour of the OPAC cart to be to open with one click, rather than clicking on the cart icon then on the dropdown box to load the cart popup. This commit is a combination of Owen Leonard's alternative patch (slightly changing the markup in masthead.inc) and my work to remove the dropdown elements from the template and basket.js Test plan: 1. In Koha OPAC click on the cart icon (making sure to have items in the cart and the dropdown box 'Items in your cart:..' appears. 2. Click this dropdown and the cart popup appears. 3. Confirm you can successfully remove items from and empty the cart 4. Apply patch 5. Restart memcached, and plack 6. Click on the cart icon (making sure to have items in the cart) and notice no 'Items in your: ..' dropdown appears instead the cart popup loads straight away. 7. Confirm the items in your cart are displayed by the cart popup 8. Confirm you can remove items from/empty the cart, and that as you do this the number of cart items shown by the number to the right of the cart icon changes accordingly Sponsored-By: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80294&action=edit Bug 21174: Removed MSG_IN_YOUR_CART and its usage in OPAC JS The 'Items in your cart' message is obsolete with the cart dropdown box being removed. Therefore the assignment of this text into the MSG_IN_YOUR_CART variable (which is done in the opac-bottom.inc), and the use of the MSG_IN_YOUR_CART variable in the updateBasket() function (in the OPAC's basket.js) has been removed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80295&action=edit Bug 21174: (follow-up) Removed MSG_IN_YOUR_CART and its usage in OPAC JS Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80293|0 |1 is obsolete| | Attachment #80294|0 |1 is obsolete| | Attachment #80295|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80373&action=edit Bug 21174: Open the OPAC cart with one click by default Feedback from the Koha mailing list in Aug 2018 showed there was widespread concensus for making the default behaviour of the OPAC cart to be to open with one click, rather than clicking on the cart icon then on the dropdown box to load the cart popup. This commit is a combination of Owen Leonard's alternative patch (slightly changing the markup in masthead.inc) and my work to remove the dropdown elements from the template and basket.js Test plan: 1. In Koha OPAC click on the cart icon (making sure to have items in the cart and the dropdown box 'Items in your cart:..' appears. 2. Click this dropdown and the cart popup appears. 3. Confirm you can successfully remove items from and empty the cart 4. Apply patch 5. Restart memcached, and plack 6. Click on the cart icon (making sure to have items in the cart) and notice no 'Items in your: ..' dropdown appears instead the cart popup loads straight away. 7. Confirm the items in your cart are displayed by the cart popup 8. Confirm you can remove items from/empty the cart, and that as you do this the number of cart items shown by the number to the right of the cart icon changes accordingly Sponsored-By: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80374&action=edit Bug 21174: Removed MSG_IN_YOUR_CART and its usage in OPAC JS The 'Items in your cart' message is obsolete with the cart dropdown box being removed. Therefore the assignment of this text into the MSG_IN_YOUR_CART variable (which is done in the opac-bottom.inc), and the use of the MSG_IN_YOUR_CART variable in the updateBasket() function (in the OPAC's basket.js) has been removed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80375&action=edit Bug 21174: (follow-up) Removed MSG_IN_YOUR_CART and its usage in OPAC JS Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Bug 21174 depends on bug 21479, which changed state. Bug 21479 Summary: Removing from cart removes 2 items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org