https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17065 |17965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065 [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59449&action=edit Bug 17975: TT syntax for notices - Prove that HOLD_SLIP is compatible Here we need to test <<today>>. We already pass a value, but it was wrong. We must pass a string, not a DateTime object, otherwise the KohaDates plugin will not display the hours part if we need it. Test plan: Define a HOLD_SLIP notice template to match your need. Do not forget to use [% today | $KohaDates %] or [% today | $KohaDates with_hours => 1 %] To access data from the reserves table, use the 'hold' variable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 --- Comment #2 from Marc Véron <veron@veron.ch> --- I run into following problem: Syspref dateformat is dd/mm/yyy Notice HOLD contains: [% today | $KohaDates %] Result: Internal Software Error with: undef error - The given date (25/02/2017) does not match the date format (iso) at (...) DateUtils.pm No error if: HOLD contains [% today %] (it displays the date formated following syspref) No error if: HOLD contains [% today | $KohaDates %] and syspref dateformat is changed to iso (yyy-mm-dd) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nice catch Marc! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60691|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 60720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60720&action=edit Bug 17975: Let C4::Letters manage today param substitution The today parameter is properly handled from C4::Letters subroutines, we do not need to pass it from callers. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60717|0 |1 is obsolete| | Attachment #60720|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63968&action=edit Bug 17975: TT syntax for notices - Prove that HOLD_SLIP is compatible Here we need to test <<today>>. We already pass a value, but it was wrong. We must pass a string, not a DateTime object, otherwise the KohaDates plugin will not display the hours part if we need it. Test plan: Define a HOLD_SLIP notice template to match your need. Do not forget to use [% today | $KohaDates %] or [% today | $KohaDates with_hours => 1 %] To access data from the reserves table, use the 'hold' variable Tested both patches together with several date formats, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63968|0 |1 is obsolete| | Attachment #63969|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63973&action=edit Bug 17975: TT syntax for notices - Prove that HOLD_SLIP is compatible Here we need to test <<today>>. We already pass a value, but it was wrong. We must pass a string, not a DateTime object, otherwise the KohaDates plugin will not display the hours part if we need it. Test plan: Define a HOLD_SLIP notice template to match your need. Do not forget to use [% today | $KohaDates %] or [% today | $KohaDates with_hours => 1 %] To access data from the reserves table, use the 'hold' variable Tested both patches together with several date formats, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63973|0 |1 is obsolete| | Attachment #63974|0 |1 is obsolete| | Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 64334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64334&action=edit Bug 17975: TT syntax for notices - Prove that HOLD_SLIP is compatible Here we need to test <<today>>. We already pass a value, but it was wrong. We must pass a string, not a DateTime object, otherwise the KohaDates plugin will not display the hours part if we need it. Test plan: Define a HOLD_SLIP notice template to match your need. Do not forget to use [% today | $KohaDates %] or [% today | $KohaDates with_hours => 1 %] To access data from the reserves table, use the 'hold' variable Tested both patches together with several date formats, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 64335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64335&action=edit Bug 17975: Let C4::Letters manage today param substitution The today parameter is properly handled from C4::Letters subroutines, we do not need to pass it from callers. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.