https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #70 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #69)

I have the feeling that there is a design issue. I'd have let the type="sql" but add another DB field ('usage' or similar) to identify how the profile can be used.

I agree with Jonathan. Although I acknowledge that this patch already has quite a history already. Export format is the name of the table for the CSV profiles (this is already confusing btw). Actually, csv profiles would be a better name. The column type should be either marc or sql: we refer to marc fields or database columns. But yes, we need an additional column where to use which profile. Probably we can start here with the simple list we have now. Could be expanded later.. About t/db_dependent/Acquisition/GetBasketAsCSV.t: Remove the dbh statements. You do not need them. You use schema txn.. You pass a new CGI object in your test. You probably can; just wondering if you should mock C4::Languages::getlanguage and not use CGI here. Typo defautl -- You are receiving this mail because: You are watching all bug changes.