[Bug 35925] New: Port default purchase suggestion notices to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35925 Bug ID: 35925 Summary: Port default purchase suggestion notices to Template Toolkit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: roadmap_24_05 Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Blocks: 15278 The following notices relating to purchase suggestions all need to be updated to use Template Toolkit syntax: ACCEPTED AVAILABLE NEW_SUGGESTION ORDERED REJECTED TO_PROCESS Most of these messages are very similar and access the same data, so it makes sense to do them all together. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35925 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35925 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov Summary|Port default purchase |Port default |suggestion notices to |NEW_SUGGESTION, REJECTED, |Template Toolkit |ACCEPTED, and ORDERED | |notices to Template Toolkit --- Comment #1 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Splitting this into two bugs based on workflow, for simplicity of testing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35925 --- Comment #2 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 164951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164951&action=edit Bug 35925: Adjust default purchase suggestion notices to use TT 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Set syspref EmailPurchaseSuggestions to "email address of library" 4. Under Administration > Libraries, enter an email address for at least one library 5. Go to "my account", and enter a Primary email and Phone number 6. Go to the Acquisitions module > Suggestions page 7. Click "New purchase suggestion", and fill in values for, at minimum: Bibliographic information: Title Author Copyright date ISBN/ISSN Publisher Publication place Collection title Document type Reason for suggestion Notes Acquisition information: Library (set to the library you entered an email for in step 4) Copies 8. Submit the suggestion 9. Set the suggestion status to "Rejected" a. Check the checkbox next to the suggestion b. Set the "Mark selected as" drop-down (below the table) to Rejected c. Select a value for the "Reason" drop-down d. Click the Submit button 10. Set the suggestion status to "Accepted" (as above) 11. Set the suggestion status to "Ordered" (as above) 12. Return to "my account" and open the Notices tab --> There should be notices suggestion declined, suggestion accepted, suggestion ordered, and (depending on settings) new suggestion* 13. Open each notice, and confirm the all information was filled in correctly * New suggestion will be there if you're using default KTD settings/data and logged in as the root user. If it is not there, query the database (by command line or SQL report) to see the generated notice text: SELECT * FROM message_queue WHERE letter_code = 'NEW_SUGGESTION' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35925 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35925 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164951|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166416&action=edit Bug 35925: Adjust default purchase suggestion notices to use TT 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Set syspref EmailPurchaseSuggestions to "email address of library" 4. Under Administration > Libraries, enter an email address for at least one library 5. Go to "my account", and enter a Primary email and Phone number 6. Go to the Acquisitions module > Suggestions page 7. Click "New purchase suggestion", and fill in values for, at minimum: Bibliographic information: Title Author Copyright date ISBN/ISSN Publisher Publication place Collection title Document type Reason for suggestion Notes Acquisition information: Library (set to the library you entered an email for in step 4) Copies 8. Submit the suggestion 9. Set the suggestion status to "Rejected" a. Check the checkbox next to the suggestion b. Set the "Mark selected as" drop-down (below the table) to Rejected c. Select a value for the "Reason" drop-down d. Click the Submit button 10. Set the suggestion status to "Accepted" (as above) 11. Set the suggestion status to "Ordered" (as above) 12. Return to "my account" and open the Notices tab --> There should be notices suggestion declined, suggestion accepted, suggestion ordered, and (depending on settings) new suggestion* 13. Open each notice, and confirm the all information was filled in correctly * New suggestion will be there if you're using default KTD settings/data and logged in as the root user. If it is not there, query the database (by command line or SQL report) to see the generated notice text: SELECT * FROM message_queue WHERE letter_code = 'NEW_SUGGESTION' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35925 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- More great work, Passing QA, Thankyou! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35925 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35925 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35925 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35925 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35925 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35925 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The default notice release notes| |templates for suggestion | |notifications | |(NEW_SUGGESTION, REJECTED, | |ACCEPTED, and ORDERED) now | |use modern Template Toolkit | |rather than the old custom | |syntax. This will only | |affect new installations, | |unless the library chooses | |to reset their notices to | |the default. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org