[Bug 17731] New: noxml option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Bug ID: 17731 Summary: noxml option Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|noxml option |Remove noxml option from | |rebuild_zebra.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58003&action=edit Bug 17731: Remove noxml option from rebuild_zebra.pl The removal of the noxml is a logical follow-up of bug 16506 (which make xml the default). Actually this option should have been removed by bug 10455 (it removes the biblioitem.marc field). Test plan: Make sure the rebuild_zebra.pl script works as before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Summary|Remove noxml option from |Remove the noxml option |rebuild_zebra.pl |from rebuild_zebra.pl Depends on| |10455 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 [Bug 10455] remove redundant 'biblioitems.marc' field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Emma <emma.nakamura.smith@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Emma <emma.nakamura.smith@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58003|0 |1 is obsolete| | --- Comment #2 from Emma <emma.nakamura.smith@gmail.com> --- Created attachment 59038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59038&action=edit Bug 17731: Remove noxml option from rebuild_zebra.pl The removal of the noxml is a logical follow-up of bug 16506 (which make xml the default). Actually this option should have been removed by bug 10455 (it removes the biblioitem.marc field). Test plan: Make sure the rebuild_zebra.pl script works as before. Signed-off-by: Emma Smith <emma.nakamura.smith@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59038|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 59238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59238&action=edit Bug 17731: Remove noxml option from rebuild_zebra.pl The removal of the noxml is a logical follow-up of bug 16506 (which make xml the default). Actually this option should have been removed by bug 10455 (it removes the biblioitem.marc field). Test plan: Make sure the rebuild_zebra.pl script works as before. Signed-off-by: Emma Smith <emma.nakamura.smith@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think there is still some trace left of the -x: vagrant@kohadevbox:~$ sudo koha-rebuild-zebra -f kohadev Warning: You passed -x which is already the default and is now deprecated Waiting for feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #5)
I think there is still some trace left of the -x:
vagrant@kohadevbox:~$ sudo koha-rebuild-zebra -f kohadev Warning: You passed -x which is already the default and is now deprecated
Waiting for feedback.
You are not using the patched scripts if you did not copy the debian scripts. sudo which koha-rebuild-zebra /usr/sbin/koha-rebuild-zebra -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I will try that, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the warning is not from outdated scripts, I have copied them, but old and newer koha-rebuild-zebra contain the following line: 98 opt_xml="-x" Which seems to trigger the message shown below for koha-rebuild-zebra? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18069 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Indeed! See bug 18069. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18069 [Bug 18069] koha-rebuild-zebra still calls rebuild_zebra with -x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, will take another look at this for 16.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.04. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org