https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43624 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 206722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206722&action=edit Bug 43624: Update some acquisitions pages to use grid layout for forms - Part 3 This patch updates more acquisitions pages so that forms use CSS grid layout. To test, apply the patch and rebuild the staff interface CSS. Test each page to confirm that forms look correct and function correctly: - Acquisitions -> Vendors -> Search for vendor - Vendor issues -> New issue - Basket -> Add to Basket -> From an external source - Search for a title and create an order. Under "Accounting details," check the "Uncertain price" checkbox. - Submit the order. - In the sidebar, click "Uncertain prices." - This page has been modified to remove an unused instance of the "rows" fieldset class, and the "Show orders from" form has been made more compact in order for it to better reflect its use as a filter on the table below it. Changing the "Show orders from" selection should automatically submit the form. - Test the process of receiving an order: - If necessary, search for a vendor and create a basket for that vendor. - Add orders to the basket. - Close the basket. - Click "Receive shipments" in the toolbar. - Fill in and submit the "Receive a new shipment" form. - From the list of pending orders, check the checkbox on one or more titles and click "Receive selected." - If you selected a single order, a modal will automatically pop up containing the updated form. If not, click "Edit" on one of the titles. - The item edit form is not updated in this patch, but the "Accounting details" form should be tested. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43624 Frédéric Demians <f.demians@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206722|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43624 --- Comment #3 from Frédéric Demians <f.demians@tamil.fr> --- Created attachment 207898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207898&action=edit Bug 43624: (follow-up) Don't break uncertainprice.pl after saving prices After saving the prices, uncertainprice.tt only renders a redirection: the "Show orders from" filter form is not displayed, but the new script still adds a listener to it, which throws a JavaScript error: TypeError: Cannot read properties of null (reading 'addEventListener') Only add the listener if the filter is on the page. To test: 1. Create an order with an uncertain price: - Go to Acquisitions, search for a vendor and open one of its baskets (or create a new basket). - Click "Add to basket" and choose whatever you want. - In the order form, under "Accounting details", fill in the quantity, choose a fund and check "Uncertain price". - Save the order. 2. Click "Uncertain prices" => menu on the left 3. Open the browser console. Click on Setting (icon) and enable "Preserve log" => necessary because the page is reloaded after saving. 4. Change the price of the order. Click "Save": the TypeError is displayed in the console. 5. Apply this patch. 6. Repeat step 4: no more error, the new price is saved. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43624 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 207900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207900&action=edit Bug 43624: (follow-up) Don't break uncertainprice.pl after saving prices After saving the prices, uncertainprice.tt only renders a redirection: the "Show orders from" filter form is not displayed, but the new script still adds a listener to it, which throws a JavaScript error: TypeError: Cannot read properties of null (reading 'addEventListener') Only add the listener if the filter is on the page. To test: 1. Create an order with an uncertain price: - Go to Acquisitions, search for a vendor and open one of its baskets (or create a new basket). - Click "Add to basket" and choose whatever you want. - In the order form, under "Accounting details", fill in the quantity, choose a fund and check "Uncertain price". - Save the order. 2. Click "Uncertain prices" => menu on the left 3. Open the browser console. Click on Setting (icon) and enable "Preserve log" => necessary because the page is reloaded after saving. 4. Change the price of the order. Click "Save": the TypeError is displayed in the console. 5. Apply this patch. 6. Repeat step 4: no more error, the new price is saved. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.