[Bug 41574] New: Tidy kohaTable block - patroncards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 Bug ID: 41574 Summary: Tidy kohaTable block - patroncards Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41324 QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 [Bug 41324] Tidy kohaTable block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191143&action=edit Bug 41574: Tidy kohaTable - patroncards/edit-batch.tt Patch from commit 4a160f8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191144&action=edit Bug 41574: patroncards - auto tidy Patch from commit dfadfab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41562 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41562 [Bug 41562] Introduce the concept of "stores" for regular javascript -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191143|0 |1 is obsolete| | Attachment #191144|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191533&action=edit Bug 41574: Tidy kohaTable - patroncards/edit-batch.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191534&action=edit Bug 41574: patroncards - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191535&action=edit Bug 41574: (follow-up) Fixing syntax error and wrong variable name Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191536&action=edit Bug 41574: (follow-up) More tidying Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191533|0 |1 is obsolete| | --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194740&action=edit Bug 41574: Tidy kohaTable - patroncards/edit-batch.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191534|0 |1 is obsolete| | --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194741&action=edit Bug 41574: patroncards - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191535|0 |1 is obsolete| | --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194742&action=edit Bug 41574: (follow-up) Fixing syntax error and wrong variable name Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191536|0 |1 is obsolete| | --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194743&action=edit Bug 41574: (follow-up) More tidying Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194744&action=edit Bug 41574: (QA follow-up) Rename shadowing batch_id variables - The top-level const batch_id (from TT) is shadowed by var batch_id inside the .export and #savedesc click handlers - Rename to export_batch_id and save_batch_id respectively to make the intent clear Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41574 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #13 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org