[Bug 18070] New: Working title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Bug ID: 18070 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14026 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 [Bug 17908] Authority merge omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59972&action=edit Bug 18070: Deleting an authority should update the linked biblio records Adding a test where we delete an authority and prove that the linked biblio still contains a reference to it. Note: Currently, the interface does not allow you to delete an authority that still has linked biblio records. Especially, if security bug 18019 has been pushed. This report will add a maintenance script that allows you to delete such records and cleanup the biblios. This is a first step. Test plan: [1] Run t/db_dependent/Authorities/Merge.t Last test should fail: not ok 1 - Field 609 should be gone too Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59973&action=edit Bug 18070: Extend sub merge to remove fields for deleted authorities In order to accomplish this, we need to add some additional checks in the merge routine. The actual change to remove the field, is quite small. Furthermore, we need to add a merge call in DelAuthority and adjust the merge cron job accordingly. The change is well supported by additional tests, including a simulation of postponed removal via cron, if dontmerge is enabled. Note: Deleting an authority with linked biblios is tested on the next patch. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Delete an authority without linked biblios from the interface. If the indexer is not fast enough, wait a bit and refresh to verify that the authority is gone on authorities-home.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18071 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 [Bug 18071] Extend script update_authorities.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59977&action=edit Bug 18070: Add script for clean removal of authorities This script now supports clean removal of authority records that still have linked biblio records. On BZ report 18071, we will extend its functionality to include updating 001 fields, triggering a merge (refresh biblio records), etc. Test plan: [1] Look for one or two authority records with linked biblio records. [2] Pass their authority id's to the script: perl misc/maintenance/update_authorities.pl -authid X,Y -del [3] Verify that authority record is gone and biblio records are clean. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59978&action=edit Bug 18070: Correct error from podchecker on line 1376 Resolves: *** ERROR: Spurious =cut command at line 1376 in file C4/AuthoritiesMarc.pm Test plan: [1] Run podchecker on C4/AuthoritiesMarc.pm Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Working title |Support clean removal of | |authority records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Marcel, I have tried this patchset, but have problem with deleting authority... The authority link is not removed when I run update_authorities.pl with delete param... the authority itself is removed but still linked from biblio.... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Josef Moravec from comment #5)
Marcel,
I have tried this patchset, but have problem with deleting authority...
The authority link is not removed when I run update_authorities.pl with delete param...
the authority itself is removed but still linked from biblio....
Can you show me the biblio record? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- And are you sure that your PERL5LIB points to the changed AuthoritiesMarc module? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Marcel de Rooy from comment #6)
(In reply to Josef Moravec from comment #5)
Marcel,
I have tried this patchset, but have problem with deleting authority...
The authority link is not removed when I run update_authorities.pl with delete param...
the authority itself is removed but still linked from biblio....
Can you show me the biblio record?
For example this one: http://paste.koha-community.org/309 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Marcel de Rooy from comment #7)
And are you sure that your PERL5LIB points to the changed AuthoritiesMarc module?
I am testing on kohadevbox in koha-shell env, tried to read the file and looks ok... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Josef Moravec from comment #8)
(In reply to Marcel de Rooy from comment #6)
(In reply to Josef Moravec from comment #5)
Marcel,
I have tried this patchset, but have problem with deleting authority...
The authority link is not removed when I run update_authorities.pl with delete param...
the authority itself is removed but still linked from biblio....
Can you show me the biblio record?
For example this one:
I deleted the authority linked in field 100 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Josef Moravec from comment #9)
(In reply to Marcel de Rooy from comment #7)
And are you sure that your PERL5LIB points to the changed AuthoritiesMarc module?
I am testing on kohadevbox in koha-shell env, tried to read the file and looks ok...
before you run the script please echo $PERL5LIB does it mention home/vagrant/kohaclone first or /usr/share/koha/lib ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Or could it be an index issue? IF you added an authority to the biblio record, and it was not yet indexed, the search an=index will not yet find it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- an=auth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just tested again: add authority PERSO_NAME, used it in a 100 of a biblio. And removed it with update_authorities. Record is clean too.. I may have tested with 600s, but doing this in 100 should not be a problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- What we still miss, is: chmod 755 misc/maintenance/update_authorities.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Hm, it really looks like indexing problem... but I can't figure it out still... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9988 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 [Bug 9988] Leave larger authority merges to merge_authority cronjob (pref AuthorityMergeLimit) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Still found something -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16018 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 [Bug 16018] Merge.pl code cleanup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59972|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 60251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60251&action=edit Bug 18070: Deleting an authority should update the linked biblio records Adding a test where we delete an authority and prove that the linked biblio still contains a reference to it. Note: Currently, you can only delete a used authority from Tools, batch record deletion. If you do, the biblio records will still contain references to the deleted authority. Test plan: [1] Run t/db_dependent/Authorities/Merge.t Last test should fail: not ok 1 - Field 609 should be gone too Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59973|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 60252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60252&action=edit Bug 18070: Extend sub merge to remove fields for deleted authorities In order to accomplish this, we need to add some additional checks in the merge routine. The actual change to remove the field, is quite small. Furthermore, we need to add a merge call in DelAuthority and adjust the merge cron job accordingly. The change is well supported by additional tests, including a simulation of postponed removal via cron, if dontmerge is enabled. Note: Deleting an authority with linked biblios is tested on the next patch. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Delete an authority without linked biblios from the Authorities module. If the indexer is not fast enough, wait a bit and refresh to verify that the authority is gone on authorities-home.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 60253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60253&action=edit Bug 18070: [Follow-up] What should DelAuthority return? Script tools/batch_delete_records.pl only checks the return value of DelAuthority. The return value depends on DBI rows, which is not always reliable. It may return -1 when it 'does not know'. Testing $@ in tools/batch_delete_records.pl should actually be enough. The return value was discarded in C4/ImportBatch.pm. Removing an unused variable. Test plan: [1] Pick an authority record with a few linked biblios. Delete this authority record via tools/batch_delete_records.pl. Check if the linked biblio records are cleaned up. [2] Bonus: Make a typo in the SQL statement of DelAuthority. Check if batch_delete_records shows you the error message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59978|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 60254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60254&action=edit Bug 18070: Correct error from podchecker on line 1376 Resolves: *** ERROR: Spurious =cut command at line 1376 in file C4/AuthoritiesMarc.pm Test plan: [1] Run podchecker on C4/AuthoritiesMarc.pm Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59977|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- What happened: Added the followup patch about the return value of DelAuthority. This introduced the dependency on 16018 for authorities/merge.pl. Moved the maintenance script to 18071; testing with tools/batch record delete should be enough here. Josef: If you got your indexing working again, please retry this one. Anyone else is welcome too ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60251|0 |1 is obsolete| | Attachment #60252|0 |1 is obsolete| | Attachment #60253|0 |1 is obsolete| | Attachment #60254|0 |1 is obsolete| | --- Comment #23 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 60392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60392&action=edit [SIGNED-OFF] Bug 18070: Deleting an authority should update the linked biblio records Adding a test where we delete an authority and prove that the linked biblio still contains a reference to it. Note: Currently, you can only delete a used authority from Tools, batch record deletion. If you do, the biblio records will still contain references to the deleted authority. Test plan: [1] Run t/db_dependent/Authorities/Merge.t Last test should fail: not ok 1 - Field 609 should be gone too Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #24 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 60393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60393&action=edit [SIGNED-OFF] Bug 18070: Extend sub merge to remove fields for deleted authorities In order to accomplish this, we need to add some additional checks in the merge routine. The actual change to remove the field, is quite small. Furthermore, we need to add a merge call in DelAuthority and adjust the merge cron job accordingly. The change is well supported by additional tests, including a simulation of postponed removal via cron, if dontmerge is enabled. Note: Deleting an authority with linked biblios is tested on the next patch. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Delete an authority without linked biblios from the Authorities module. If the indexer is not fast enough, wait a bit and refresh to verify that the authority is gone on authorities-home.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #25 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 60394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60394&action=edit [SIGNED-OFF] Bug 18070: [Follow-up] What should DelAuthority return? Script tools/batch_delete_records.pl only checks the return value of DelAuthority. The return value depends on DBI rows, which is not always reliable. It may return -1 when it 'does not know'. Testing $@ in tools/batch_delete_records.pl should actually be enough. The return value was discarded in C4/ImportBatch.pm. Removing an unused variable. Test plan: [1] Pick an authority record with a few linked biblios. Delete this authority record via tools/batch_delete_records.pl. Check if the linked biblio records are cleaned up. [2] Bonus: Make a typo in the SQL statement of DelAuthority. Check if batch_delete_records shows you the error message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #26 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 60395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60395&action=edit [SIGNED-OFF] Bug 18070: Correct error from podchecker on line 1376 Resolves: *** ERROR: Spurious =cut command at line 1376 in file C4/AuthoritiesMarc.pm Test plan: [1] Run podchecker on C4/AuthoritiesMarc.pm Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Bug 18070 depends on bug 16018, which changed state. Bug 16018 Summary: Merge.pl code cleanup https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #27 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 60557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60557&action=edit Bug 18070: Deleting an authority should update the linked biblio records Adding a test where we delete an authority and prove that the linked biblio still contains a reference to it. Note: Currently, you can only delete a used authority from Tools, batch record deletion. If you do, the biblio records will still contain references to the deleted authority. Test plan: [1] Run t/db_dependent/Authorities/Merge.t Last test should fail: not ok 1 - Field 609 should be gone too Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #28 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 60558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60558&action=edit Bug 18070: Extend sub merge to remove fields for deleted authorities In order to accomplish this, we need to add some additional checks in the merge routine. The actual change to remove the field, is quite small. Furthermore, we need to add a merge call in DelAuthority and adjust the merge cron job accordingly. The change is well supported by additional tests, including a simulation of postponed removal via cron, if dontmerge is enabled. Note: Deleting an authority with linked biblios is tested on the next patch. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Delete an authority without linked biblios from the Authorities module. If the indexer is not fast enough, wait a bit and refresh to verify that the authority is gone on authorities-home.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #29 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 60559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60559&action=edit Bug 18070: [Follow-up] What should DelAuthority return? Script tools/batch_delete_records.pl only checks the return value of DelAuthority. The return value depends on DBI rows, which is not always reliable. It may return -1 when it 'does not know'. Testing $@ in tools/batch_delete_records.pl should actually be enough. The return value was discarded in C4/ImportBatch.pm. Removing an unused variable. Test plan: [1] Pick an authority record with a few linked biblios. Delete this authority record via tools/batch_delete_records.pl. Check if the linked biblio records are cleaned up. [2] Bonus: Make a typo in the SQL statement of DelAuthority. Check if batch_delete_records shows you the error message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 --- Comment #30 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 60560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60560&action=edit Bug 18070: Correct error from podchecker on line 1376 Resolves: *** ERROR: Spurious =cut command at line 1376 in file C4/AuthoritiesMarc.pm Test plan: [1] Run podchecker on C4/AuthoritiesMarc.pm Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Passed QA --- Comment #31 from Julian Maurice <julian.maurice@biblibre.com> --- Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60392|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60393|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60394|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60395|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org