[Bug 6027] New: Delete biblios if deleting all their items in batch deletion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Bug #: 6027 Summary: Delete biblios if deleting all their items in batch deletion Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Tools AssignedTo: gmcharlt@gmail.com ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org Blocks: 5992 This needs a lot of testing, I dont think it tests for any reserves on the biblio, before deleting. (Or serial subscriptions etc) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-31 21:01:38 UTC --- Created attachment 3590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3590 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nengard@gmail.com Patch Status|Needs Signoff |Failed QA AssignedTo|gmcharlt@gmail.com |matthias.meusburger@biblibr | |e.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-03-31 21:36:02 UTC --- When I try to load up the batch bib delete tool I get the following: Software error: Global symbol "$values_to_modify" requires explicit package name at /home/koha/kohaclone/tools/batchMod.pl line 156. Global symbol "$values_to_blank" requires explicit package name at /home/koha/kohaclone/tools/batchMod.pl line 156. Global symbol "$marcitem" requires explicit package name at /home/koha/kohaclone/tools/batchMod.pl line 158. Execution of /home/koha/kohaclone/tools/batchMod.pl aborted due to compilation errors. For help, please send mail to the webmaster (ian.walls@bywatersolutions.com), giving this error message and the time and date of the error. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-04 08:10:02 UTC --- This bug is mentioned in: Bug 6027 : MT3532: Deletes biblio record when there are no more items left for this biblio while batch item deleting http://lists.koha-community.org/pipermail/koha-patches/2011-March/014413.htm... --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-19 10:43:10 UTC --- This sounds like an interesting feature Is there a chance to fix the patch in time for 3.6? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-21 14:19:07 UTC --- *** Bug 5694 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-17 15:28:23 UTC --- Created attachment 7737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7737 Bug 6027 - Delete biblios if deleting all their items in batch deletion Optionally delete bibliographic record when batch deleting items, if no items remain on the record. Adds deleting of reserves to DelBiblio. Since subscriptions are deleted automatically, it made sense for deletion of reserves to maintain the same behavior. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3590|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |kyle.m.hall@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- I entered three barcodes in the batch deletion, two were the last items and one was one of many items on the bib record. When I clicked the 'deleted selected items' button I got this error: Software error: Undefined subroutine &C4::Search::SimpleSearch called at /home/nengard/kohaclone/C4/Items.pm line 2465. For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Kyle, did denesting strike you? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7737|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8235&action=edit Bug 6027 - Delete biblios if deleting all their items in batch deletion Optionally delete bibliographic record when batch deleting items, if no items remain on the record. Adds deleting of reserves to DelBiblio. Since subscriptions are deleted automatically, it made sense for deletion of reserves to maintain the same behavior. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8235|0 |1 is obsolete| | --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 8239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8239&action=edit Bug 6027 - Delete biblios if deleting all their items in batch deletion Optionally delete bibliographic record when batch deleting items, if no items remain on the record. Adds deleting of reserves to DelBiblio. Since subscriptions are deleted automatically, it made sense for deletion of reserves to maintain the same behavior. Signed-off-by: Liz Rea <wizzyrea@gmail.com> I like the way this works, and it does. Passes tests. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 --- Comment #11 from Liz Rea <wizzyrea@gmail.com> --- Also takes care of that insidious problem with deleting the reserves associated with batch deleted items. The only extra thing I would ask (it can be a followup) is that it report which titles/patrons had holds deleted so that the librarian can notify the patron. Maybe do this on the "delete prep" screen, have a column for reserves and the names of the patrons? That would be easy for staff to print before clicking "delete." -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #12 from Ian Walls <koha.sekjal@gmail.com> --- Adds this functionality very cleanly. Marking as Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P4 Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Assignee|matthias.meusburger@biblibr |kyle.m.hall@gmail.com |e.com | --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- I like the way it's made, but have 2 questions: * why do you have added +use C4::Search qw/SimpleSearch/; ? Checking, it seems this sub is used in GetAnalyticsCount, that is not related to this patch (maybe we should add a require C4::Search in this sub and not load it everytime ? * you also add &SimpleSearch into C4::Search, same question : it's not used by this patch, isn't it ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 --- Comment #14 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to comment #13) My installation was dying with errors on master, and these edits fixed it. I'm not sure why. I can remove them if you think that would be best.
I like the way it's made, but have 2 questions: * why do you have added +use C4::Search qw/SimpleSearch/; ? Checking, it seems this sub is used in GetAnalyticsCount, that is not related to this patch (maybe we should add a require C4::Search in this sub and not load it everytime ? * you also add &SimpleSearch into C4::Search, same question : it's not used by this patch, isn't it ?
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7847 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 --- Comment #15 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 8733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8733&action=edit Bug 6027 created Bug 7847 This change fixes Bug 7847 without other changes, but I'm at loss why. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org --- Comment #16 from Dobrica Pavlinusic <dpavlin@rot13.org> --- This bug seems to be prefered solution to fix Bug 7847 - OPAC search dies with plack - see discussion there. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8733|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7958 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Depends on| |8149 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8149 Depends on|8149 | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 --- Comment #17 from Nicole C. Engard <nengard@gmail.com> --- I'm going to have to add to this. The feature works, but only on small batches I saved the report of withdrawn titles, and when I ran it I got a message saying the list was too long to display individual barcodes, but all titles would be deleted. I did not get the checkbox with the choice of "Delete records if no items remain". I do see this checkbox is I'm loading in a smaller file though. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 --- Comment #18 from Kyle M Hall <kyle.m.hall@gmail.com> --- Nicole, could you open a new bug for this problem and put it in the see also on this bug? Thanks, Kyle (In reply to comment #17)
I'm going to have to add to this. The feature works, but only on small batches
I saved the report of withdrawn titles, and when I ran it I got a message saying the list was too long to display individual barcodes, but all titles would be deleted. I did not get the checkbox with the choice of "Delete records if no items remain".
I do see this checkbox is I'm loading in a smaller file though.
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8246 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 --- Comment #19 from Nicole C. Engard <nengard@gmail.com> --- Done -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org