[Bug 9618] New: Add support for intranetuserjs to labels/spinelabel-print.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Bug ID: 9618 Summary: Add support for intranetuserjs to labels/spinelabel-print.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15364&action=edit Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15364|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15365&action=edit Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15365|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15379&action=edit Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- This patch has no commit message, thus no description of its purpose and no test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15379|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15722&action=edit Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl For some reason, spinelabel-print.pl is is including intranetuserjs. This pref would be useful for making certain customizations to spine labels. Test Plan: 1) Apply patch 2) Put something in the syspref intranetuserjs 3) Load up labels/spinelabel-print.pl 4) View the page source and verify the code you entered in intranetuserjs is there. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15722|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16306&action=edit Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl The template for printing a single spine label is a stripped-down version of a standard Koha template, but it should include intranetuserjs and IntranetUserCSS so that libraries can make local customizations. This patch updates the page's DOCTYPE to HTML5 and adds the missing markup for including those preferences. Also added is jQuery, since there's a good chance local customizations are using jQuery. To test, make sure there is something in your intranetuserjs and IntranetUserCSS system preferences. Visit /cgi-bin/koha/labels/spinelabel-home.pl and submit a barcode. View source on the spine label output page and confirm that your custom js and css were included correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18416&action=edit Bug 9618: Followup Add support for intranetuserjs to labels/spinelabel-print.pl the jQuery lib is useful only if js code is filled into the intranetuserjs pref. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- I think the jQuery lib should only be include if user had defined js code. Owen, could you confirm that please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> ---
I think the jQuery lib should only be include if user had defined js code.
That makes sense to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Campbell Reid-Tait <campbellreidtait@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16306|0 |1 is obsolete| | CC| |campbellreidtait@gmail.com --- Comment #10 from Campbell Reid-Tait <campbellreidtait@gmail.com> --- Created attachment 20685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20685&action=edit Signed Off: 16306: Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Campbell Reid-Tait <campbellreidtait@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18416|0 |1 is obsolete| | --- Comment #11 from Campbell Reid-Tait <campbellreidtait@gmail.com> --- Created attachment 20686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20686&action=edit Signed Off: 18416: Bug 9618: Followup Add support for intranetuserjs to labels/spinelabel-print.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Campbell Reid-Tait <campbellreidtait@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20685|0 |1 is obsolete| | Attachment #20686|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20930&action=edit [PASSED QA] Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl The template for printing a single spine label is a stripped-down version of a standard Koha template, but it should include intranetuserjs and IntranetUserCSS so that libraries can make local customizations. This patch updates the page's DOCTYPE to HTML5 and adds the missing markup for including those preferences. Also added is jQuery, since there's a good chance local customizations are using jQuery. To test, make sure there is something in your intranetuserjs and IntranetUserCSS system preferences. Visit /cgi-bin/koha/labels/spinelabel-home.pl and submit a barcode. View source on the spine label output page and confirm that your custom js and css were included correctly. Signed-off-by: Campbell Reid-Tait <campbellreidtait@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template only change, works nicely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20931&action=edit [PASSED QA] Bug 9618: Followup Add support for intranetuserjs to labels/spinelabel-print.pl the jQuery lib is useful only if js code is filled into the intranetuserjs pref. Signed-off-by: Campbell Reid-Tait <campbellreidtait@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> To test: - Use Quick spine label creator - Make sure you have Javascript in your intranetuserjs system preference - Validate Javascript effect on screen or check source code to make sure your code is visible there. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10850 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org