[Bug 10587] New: HTML errors on authority detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Bug ID: 10587 Summary: HTML errors on authority detail page in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de CC: jcamins@cpbibliography.com When checking the source code for some ids and classed I found that Firefox showed some red error marks in the source code. It seems 2 divs are closed, but not opened. The W3C HTML validator also points out those: Error Line 357, Column 10: End tag div seen, but there were open elements. </div> Error Line 256, Column 24: Unclosed element ul. <ul class="seefrom"> Error Line 381, Column 6: Stray end tag div. </div> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20239&action=edit Bug 10587 - HTML errors on authority detail page in OPAC A validator check of the OPAC's authority detail returns a few minor errors. This patch corrects the errors. To test, apply the patch and run an OPAC authority detail page through an HTML validator. There should be no errors which are specific to the authorities detail template (as opposed to header and footer includes). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20239|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20336&action=edit Bug 10587: fix HTML errors on authority detail page in OPAC A validator check of the OPAC's authority detail returns a few minor errors. This patch corrects the errors. To test, apply the patch and run an OPAC authority detail page through an HTML validator. There should be no errors which are specific to the authorities detail template (as opposed to header and footer includes). Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20336|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20666&action=edit [PASSED QA] Bug 10587: fix HTML errors on authority detail page in OPAC A validator check of the OPAC's authority detail returns a few minor errors. This patch corrects the errors. To test, apply the patch and run an OPAC authority detail page through an HTML validator. There should be no errors which are specific to the authorities detail template (as opposed to header and footer includes). Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Also checked using the W3C validator and testing the authority detail page in the OPAC is still correctly displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org