[Bug 15824] New: 'Done' button is unclear on batch item modification and deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Bug ID: 15824 Summary: 'Done' button is unclear on batch item modification and deletion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org To reproduce, go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) Click edit -> Edit items in a batch Click Save (you don't need to make any changes) Notice Done link at the bottom of the page is not very noticeable. This is the same with batch item deletion as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48083&action=edit Bug 15824 - 'Done' button is unclear on batch item modification and deletion To test: MODIFICATION 1) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 2) Click edit -> Edit items in a batch 3) Click Save (you don't need to make any changes) 4) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 5) Go to a biblio record page 6) Select one or some or all items in the record 7) Click modify selected items 8) Click Save 9) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 10) Go to batch item modification (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl) 11) Write some barcodes into the barcode list and click Continue 12) Click Save 13) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item mod page. DELETION 14) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 15) Click edit -> Delete items in a batch 16) Unselect all the items so you don't actually delete them, then click Delete selected items 17) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 18) Go to a biblio record page 19) Select one or some or all items in the record 20) Click Delete selected items 21) Unselect all the items so you don't actually delete them, then click Delete selected items 22) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 23) Go to batch item deletion (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl?del=1) 24) Write some barcodes into the barcode list and click Continue 25) Unselect all the items so you don't actually delete them, then click Delete selected items 26) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item deletion page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |aleishaamohia@hotmail.com Change sponsored?|--- |Sponsored --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48083|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48147&action=edit [SIGNED-OFF] Bug 15824 - 'Done' button is unclear on batch item modification and deletion To test: MODIFICATION 1) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 2) Click edit -> Edit items in a batch 3) Click Save (you don't need to make any changes) 4) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 5) Go to a biblio record page 6) Select one or some or all items in the record 7) Click modify selected items 8) Click Save 9) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 10) Go to batch item modification (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl) 11) Write some barcodes into the barcode list and click Continue 12) Click Save 13) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item mod page. DELETION 14) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 15) Click edit -> Delete items in a batch 16) Unselect all the items so you don't actually delete them, then click Delete selected items 17) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 18) Go to a biblio record page 19) Select one or some or all items in the record 20) Click Delete selected items 21) Unselect all the items so you don't actually delete them, then click Delete selected items 22) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 23) Go to batch item deletion (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl?del=1) 24) Write some barcodes into the barcode list and click Continue 25) Unselect all the items so you don't actually delete them, then click Delete selected items 26) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item deletion page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- After modifying items (from the catalogue/detail.pl), I get a screen with: 5 item(s) modified (with 5 fields modified). Return to where you were [TABLE] Done button If I click on the done button, I am not redirected to the detail page but the still on the batch tool with the same screen "item(s) modified (with fields modified)." The submit button you have added is in a form, the window.location.href does not work and the form is submitted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48565&action=edit Bug 15824 - 'Done' button is unclear on batch item modification and deletion To test: MODIFICATION 1) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 2) Click edit -> Edit items in a batch 3) Click Save (you don't need to make any changes) 4) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 5) Go to a biblio record page 6) Select one or some or all items in the record 7) Click modify selected items 8) Click Save 9) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 10) Go to batch item modification (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl) 11) Write some barcodes into the barcode list and click Continue 12) Click Save 13) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item mod page. DELETION 14) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 15) Click edit -> Delete items in a batch 16) Unselect all the items so you don't actually delete them, then click Delete selected items 17) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 18) Go to a biblio record page 19) Select one or some or all items in the record 20) Click Delete selected items 21) Unselect all the items so you don't actually delete them, then click Delete selected items 22) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 23) Go to batch item deletion (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl?del=1) 24) Write some barcodes into the barcode list and click Continue 25) Unselect all the items so you don't actually delete them, then click Delete selected items 26) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item deletion page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48147|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 48565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48565 Bug 15824 - 'Done' button is unclear on batch item modification and deletion Review of attachment 48565: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15824&attachment=48565) ----------------------------------------------------------------- Comments base on eyeballing. ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt @@ +161,5 @@
+ [% ELSIF src %] + <a href="[% src %]">Return to where you were</a> + [% ELSE %] + <a href="/cgi-bin/koha/tools/batchMod.pl?del=1">Return to batch item deletion</a> + [% END %]
Why not style this identical to the existing block below? @@ +192,4 @@
<p> [% IF src == 'CATALOGUING' # from catalogue/detail.pl > Delete items in a batch%] + <a class="btn" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber %]"><i class="fa fa-check-square-o"></i> Done</a>
Why not change this to "Return to the record", as above? @@ +196,2 @@
[% ELSIF src %] + <a class="btn" href="[% src %]"><i class="fa fa-check-square-o"></i> Done</a>
Why not change this to "Return to where you were", as above? ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt @@ +66,5 @@
+ [% ELSIF src %] + <a href="[% src %]">Return to where you were</a> + [% ELSE %] + <a href="/cgi-bin/koha/tools/batchMod.pl">Return to batch item modification</a> + [% END %]
Why not style this block as was done below? @@ +245,4 @@
[% ELSE %] <!-- // show --> <fieldset class="action"> [% IF src == 'CATALOGUING' # from catalogue/detail.pl > Edit items in a batch%] + <a class="btn" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber %]"><i class="fa fa-check-square-o"></i> Done</a>
Why not change this to "Return to where you were", as above? @@ +249,2 @@
[% ELSIF src %] + <a class="btn" href="[% src %]"><i class="fa fa-check-square-o"></i> Done</a>
Why not change this to "Return to where you were", as above? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48565|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49477&action=edit Bug 15824 - 'Done' button is unclear on batch item modification and deletion EDIT: Making sure the messages and the buttons show the same text, as per Comment 6. To test: MODIFICATION 1) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 2) Click edit -> Edit items in a batch 3) Click Save (you don't need to make any changes) 4) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 5) Go to a biblio record page 6) Select one or some or all items in the record 7) Click modify selected items 8) Click Save 9) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 10) Go to batch item modification (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl) 11) Write some barcodes into the barcode list and click Continue 12) Click Save 13) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item mod page. DELETION 14) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 15) Click edit -> Delete items in a batch 16) Unselect all the items so you don't actually delete them, then click Delete selected items 17) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 18) Go to a biblio record page 19) Select one or some or all items in the record 20) Click Delete selected items 21) Unselect all the items so you don't actually delete them, then click Delete selected items 22) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 23) Go to batch item deletion (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl?del=1) 24) Write some barcodes into the barcode list and click Continue 25) Unselect all the items so you don't actually delete them, then click Delete selected items 26) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item deletion page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 49525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49525&action=edit Button and link in batch item deletion result page Buttons for batch item modification look fine. Regarding batch item deletion: The "Return" button appears in addition to the "Return" links on all Batch item deletion results. I think it would be better to replace the link with the button at the position where the link is (inside the blueish result message box). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #9 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Marc Véron from comment #8)
Created attachment 49525 [details] Button and link in batch item deletion result page
Buttons for batch item modification look fine.
Regarding batch item deletion:
The "Return" button appears in addition to the "Return" links on all Batch item deletion results. I think it would be better to replace the link with the button at the position where the link is (inside the blueish result message box).
Hi Marc, Can I ask why you think this would look better? The behaviour is exactly the same for batch item modification. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #10 from Marc Véron <veron@veron.ch> --- (In reply to Aleisha Amohia from comment #9)
(In reply to Marc Véron from comment #8)
Created attachment 49525 [details] Button and link in batch item deletion result page
Buttons for batch item modification look fine.
Regarding batch item deletion:
The "Return" button appears in addition to the "Return" links on all Batch item deletion results. I think it would be better to replace the link with the button at the position where the link is (inside the blueish result message box).
Hi Marc,
Can I ask why you think this would look better? The behaviour is exactly the same for batch item modification.
Not a big deal. It was because the "Return to..." appears twice, one time as a link inside the message box and one time as button underneath. But you are right, it looks the same as with batch item modification. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49477|0 |1 is obsolete| | --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 49621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49621&action=edit Bug 15824 - 'Done' button is unclear on batch item modification and deletion EDIT: Making sure the messages and the buttons show the same text, as per Comment 6. To test: MODIFICATION 1) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 2) Click edit -> Edit items in a batch 3) Click Save (you don't need to make any changes) 4) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 5) Go to a biblio record page 6) Select one or some or all items in the record 7) Click modify selected items 8) Click Save 9) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 10) Go to batch item modification (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl) 11) Write some barcodes into the barcode list and click Continue 12) Click Save 13) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item mod page. DELETION 14) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 15) Click edit -> Delete items in a batch 16) Unselect all the items so you don't actually delete them, then click Delete selected items 17) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 18) Go to a biblio record page 19) Select one or some or all items in the record 20) Click Delete selected items 21) Unselect all the items so you don't actually delete them, then click Delete selected items 22) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 23) Go to batch item deletion (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl?del=1) 24) Write some barcodes into the barcode list and click Continue 25) Unselect all the items so you don't actually delete them, then click Delete selected items 26) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item deletion page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 49621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49621 Bug 15824 - 'Done' button is unclear on batch item modification and deletion Review of attachment 49621: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15824&attachment=49621) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt @@ +251,2 @@
[% ELSE %] + <a class="btn" href="/cgi-bin/koha/tools/batchMod.pl"><i class="fa fa-check-square-o"></i> Return to batch item modification</a>
Do you all agree on this fa-check-square icon? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #13 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #12)
Comment on attachment 49621 [details] [review] Bug 15824 - 'Done' button is unclear on batch item modification and deletion
Review of attachment 49621 [details] [review]: -----------------------------------------------------------------
::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt @@ +251,2 @@
[% ELSE %] + <a class="btn" href="/cgi-bin/koha/tools/batchMod.pl"><i class="fa fa-check-square-o"></i> Return to batch item modification</a>
Do you all agree on this fa-check-square icon?
OK for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49621|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49849&action=edit Bug 15824 - 'Done' button is unclear on batch item modification and deletion EDIT: Making sure the messages and the buttons show the same text, as per Comment 6. To test: MODIFICATION 1) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 2) Click edit -> Edit items in a batch 3) Click Save (you don't need to make any changes) 4) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 5) Go to a biblio record page 6) Select one or some or all items in the record 7) Click modify selected items 8) Click Save 9) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 10) Go to batch item modification (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl) 11) Write some barcodes into the barcode list and click Continue 12) Click Save 13) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item mod page. DELETION 14) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 15) Click edit -> Delete items in a batch 16) Unselect all the items so you don't actually delete them, then click Delete selected items 17) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 18) Go to a biblio record page 19) Select one or some or all items in the record 20) Click Delete selected items 21) Unselect all the items so you don't actually delete them, then click Delete selected items 22) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 23) Go to batch item deletion (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl?del=1) 24) Write some barcodes into the barcode list and click Continue 25) Unselect all the items so you don't actually delete them, then click Delete selected items 26) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item deletion page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #15 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, when deleting items using the batch item deletion tools, I now get 2 "Return to batch item deletion": 1 button and 1 link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #17 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Jonathan Druart from comment #16)
Aleisha, when deleting items using the batch item deletion tools, I now get 2 "Return to batch item deletion": 1 button and 1 link.
Hi Jonathan, you should have 2 as you've described - the link in the purple message box at the top, and the button at the bottom of all of the deleted items (handy if deleting many items and would have to scroll all the way back to the top) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #16)
Aleisha, when deleting items using the batch item deletion tools, I now get 2 "Return to batch item deletion": 1 button and 1 link.
Having both the link and the button makes sense with batch item modifications when the list of modified items is displayed. On the batch item deletion confirmation screen I think we should move the button into the [% IF ( not_deleted_loop ) %] block so that it is only shown if the page is listing items which could not be deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #19 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Owen Leonard from comment #18)
(In reply to Jonathan Druart from comment #16)
Aleisha, when deleting items using the batch item deletion tools, I now get 2 "Return to batch item deletion": 1 button and 1 link.
Having both the link and the button makes sense with batch item modifications when the list of modified items is displayed.
On the batch item deletion confirmation screen I think we should move the button into the [% IF ( not_deleted_loop ) %] block so that it is only shown if the page is listing items which could not be deleted.
See Bug 16948 for a fix for this -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org