[Bug 27555] New: Use psgi_env from errors/* controller scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27555 Bug ID: 27555 Summary: Use psgi_env from errors/* controller scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 26048 errors/* controller scripts are using any { /(^psgi\.|^plack\.)/i } keys %ENV to know if we are running under psgi. This is also defined in C4::Auth (psgi_env subroutine), but it's not available as it is in BEGIN. We should put this trick in an exportable subroutine to make it accessible from pl scripts. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26048 [Bug 26048] PSGI Koha does not use custom ErrorDocument pages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27555 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- When I was working on Bug 26048, I thought it would be enough to check for environmental variables starting with "psgi." but I don't think they were being set, but there were "plack." environmental variables. So we'd need to make sure to update "psgi_env" in C4::Auth if we did use it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27555 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118292&action=edit Bug 27555: Use psgi_env from errors sripts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27555 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |matthias.meusburger@biblibr | |e.com --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't understand why psgi_env and safe_exit were in the BEGIN block. Should we expect a regression from CAS or Shib auth here? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27555 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, pass I'm afraid... I think that predates the work I did on Shibboleth.. I just used it.. Hopefully Matts knows? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27555 --- Comment #5 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Hi, Actually, the psgi compatibility was written by eiro at the time, see https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3551 That being said, I don't see why they should be in the BEGIN block either. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27555 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** This bug has been marked as a duplicate of bug 29420 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27555 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 29744 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org