[Bug 10927] New: C4::Utils becomes useless
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 Bug ID: 10927 Summary: C4::Utils becomes useless Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 10925 removes the last use to C4::Utils. We can remove it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10925 Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21283&action=edit Bug 10927: C4::Utils is unused Bug 10925 removes the last call to C4::Utils. The module becomes useless and can be deleted. Verify that t/db_dependent/Context.t still successfully passes. git grep hashdump git grep maxwidth -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-24 last check this| | --- Comment #2 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 --- Comment #3 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- $ grep -l hashdump `find .` ./C4/Auth_with_ldap.pm ./C4/Utils.pm ./t/db_dependent/Context.t $ grep -l maxwidth `find .` ./C4/Utils.pm ./C4/Images.pm ./t/db_dependent/Context.t Checking C4/Images.pm showed that wasn't applicable. Checking C4/Auth_with_ldap.pm showed that it was applicable. I think it is triggered by the LDAP user existing locally and debug turned on, but I didn't try to figure out expressly. I eyeballed the patch and was wondering why the "Examining defined key values" section was cut, and not changed. Is there a reason to cut it? Perhaps it makes the test look prettier. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Did you apply dependent patches? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Okay, that solves the mystery of the Auth_with_ldap.pm, but that doesn't answer the question about why cut the "Examining defined key values" section. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21283|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 21425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21425&action=edit Bug 10927: C4::Utils is unused Bug 10925 removes the last call to C4::Utils. The module becomes useless and can be deleted. Verify that t/db_dependent/Context.t still successfully passes. git grep hashdump git grep maxwidth Signed-off-by: Your Name <you@example.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 21426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21426&action=edit [SIGNED OFF] Bug 10927: C4::Utils is unused Bug 10925 removes the last call to C4::Utils. The module becomes useless and can be deleted. Verify that t/db_dependent/Context.t still successfully passes. git grep hashdump git grep maxwidth Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21425|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- $ git bz apply 10925 $ git bz apply 10927 $ prove -v t/db_dependent/Context.t I also confirmed that t/Utils.t was removes, and C4/Utils.pm was as well. I did not do an LDAP login. However, that should be tested with 10925. I did not do a CAS login. However, this eyeballs rather easily, in my opinion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. Tompsett from comment #6)
Okay, that solves the mystery of the Auth_with_ldap.pm, but that doesn't answer the question about why cut the "Examining defined key values" section.
Hello Mark, I removed the section because it was only a display. Being into a unit test file, I don't think it is useful to keep it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is BLOCKED, because 10925 still waits for sign-off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Perhaps it is premature, but I switched this to signed off, as I got around to testing 10925 and signing it off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please leave at BLOCKED, it can go back to Signed off when the dependency is resolved. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #13)
Please leave at BLOCKED, it can go back to Signed off when the dependency is resolved.
Hi Katrin, I'm not sure to understand : if the dependency is signed off, I think this one could be have a signed off status too. On this way, 2 patches could be QA together, don't you think? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I thought it was Failed QA when I checked - so there was not much one could do here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21426|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21761&action=edit Bug 10927: C4::Utils is unused Bug 10925 removes the last call to C4::Utils. The module becomes useless and can be deleted. Verify that t/db_dependent/Context.t still successfully passes. git grep hashdump git grep maxwidth Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, no subs from the module are used anywhere -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #17 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org