[Bug 33552] New: Automatic renewals should only send emails for successes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 Bug ID: 33552 Summary: Automatic renewals should only send emails for successes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org I get frequent complaints from libraries about patrons getting emails saying their items can't auto renew. The typical error message is "too_many", and it's sent every single day. Most of the time, we probably only want to send email notices out when the item has successfully renewed. Then notices like advanced item due, item due, and overdues take over from there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31427 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- (On a side note, the precedence of errors in automatic renewals makes no sense. In the most common scenarios, you'll probably never see an "overdue" because you'll get "too_many" first.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Since people will disagree on this one, we would wrap it in a system preference anyway. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 Cindy Murdock Ames <cmurdock@ccfls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock@ccfls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- This one might not be valid anymore... as I think the auto renewals logic has improved a lot over the last year... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 --- Comment #4 from Ray Delahunty <r.delahunty@arts.ac.uk> --- Auto-renewal logic has changed a lot but there still are many challenges. Yes, ‘pointless emails’ are a problem (bug 35656 doesn’t help!). But we want the opposite of what is suggested here. Our patrons are told the items will renew 9 times (for ten 1 week loan periods) and we want to email them only if that routine is stopped. Ideally the development direction auto-renewals takes generally will offer choice, so the customer can select preferred functionality. Koha administrators have subtly different expectations for how auto-renewal should work. The functionality is puzzling at times, for example with potentially duplicate emails from different notices (see bug 38203). And our 23.11 still sends digests for the too_many error as well as the auto_renewal_final one but we are delighted it does despite what bug 34924 says. Yes, we have multiple too_many (and other DGST emails duplicated) but that is down to bug 35656. In the absence of a product manager who defines the LMS roadmap, getting agreement as to what should be ‘standard auto-renewals functionality’ is always going to be a challenge that open-source Koha faces. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@hypernova.fi --- Comment #5 from Lari Taskula <lari.taskula@hypernova.fi> --- We noticed AUTO_RENEWALS_DGST letters are sent even if it contains zero successful renewals. I'm not familiar with the feature so I'm wondering if there is a reason why we shouldn't skip generating such notices. Something like this... https://github.com/Hypernova-Oy/Koha/commit/ef099a91f7ee17b2fa7ba7e4afa1db05... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 --- Comment #6 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Lari Taskula from comment #5)
I'm not familiar with the feature so I'm wondering if there is a reason why we shouldn't skip generating such notices. Ok based on Ray's comment 4 I now understand there is more depth to this feature and the change linked above would kill such use case.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 --- Comment #7 from Lari Taskula <lari.taskula@hypernova.fi> --- I see the default auto renewal digest notice template skips the renewals that have failed due to "auto_too_soon", but for some reason we are also seeing issues.auto_renew_error with content "too_soon" (without prefix "auto_") and those are then included in the notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Mmm that's a good point. I think at my local public library I might only get emails when my automatic renewal fails... I think the original issue I described in 2023 for this is a separate thing that I think has been addressed elsewhere. Maybe we close this one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 --- Comment #9 from Ray Delahunty <raymund.delahunty@outlook.com> --- In the last month before I retired I tested about 30 versions of an AUTO_RENEWALS_DGST with various ridiculously nested IF / ELSE loops in template toolkit code in the DGST notice to try to have a digest that would produce an email that covered every scenario perfectly (including dealing with singular and plural issues). I came close but I was unable to get one scenario covered correctly in the email. (It was months back but I recall part of the problem was the auto_renewal_final is considered a success rather than an error, and we wanted to advise of errors). Whatever solution is finally offered I just hope it is flexible enough to deal with all needs- some Koha users want emails sent only on success, others only on failure. And where there are successes and failures in the same day’s run of the renewal script that adds additional complexity. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 --- Comment #10 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to David Cook from comment #8)
Maybe we close this one?
Yeah I think so too. I don't have anything to add to this Bug. I might have discovered an unrelated issue but I'll handle it in another Bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org