[Bug 8621] New: Template for sending out carts not formatting correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 Priority: P5 - low Change sponsored?: --- Bug ID: 8621 Assignee: oleonard@myacpl.org Summary: Template for sending out carts not formatting correctly Severity: enhancement Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: Templates Product: Koha I send myself a cart from the English and from the German templates, both emails show wrong formatting. I sent 2 titles, one with, one without items. Then numbering is wrong: Hi, Katrin Fischer sent you a cart from our online catalog. Please note that the attached file is a MARC bibliographic records file which can be imported into personal bibliographic software like EndNote, Reference Manager or ProCite. --------------------------------------------------------------------- 1. Allgemeine deutsche Biographie / * Author(s): Bayerische Akademie der Wissenschaften --Historische Kommission * Published by: Duncker & Humblot,, 54 * Notes : Zitiert.: ADB. - Neudr. mit Ersch.-Ort Berlin. - In Fraktur * Items: 2. Veröffentlichungen des Max-Planck-Instituts für Geschichte 3. Published by: Vandenhoeck & Ruprecht, 54 4. URL : http://www.bsz-bw.de/rekla/show.php?mode=urce&id2 5. Items: * Midway (non public note testing) dia -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8062 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The new template is also missing a link to the catalog. In HTML format the title would be linked, but when converting it to text, the link gets lost. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, I tried bringing back the links to the OPAC, but I have run into a bigger issue with html2text. If the link is longer than the line width, the link is cut off. Result looks like this: * In the online catalog: http://localhost/cgi-bin/koha/opac-detail.pl?biblionumber So even with a short URL we got a problem here. :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 11562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11562&action=edit Bug 8621: Fix formatting in cart email - Reformatted template for better readability and to find missing element - Added missing </li> - Added check for existance of items, so 'Items:' is only printed, if there are items To test: - Add several records to the cart, add items with and without items - Send yourself the cart as email and check formatting - Update po files for any language, translate the po file for OPAC and install language - Send yourself the cart email again from the translated templates, check formatting -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8626 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I filed bug 8628 for the URL problem - turns out it's not the length but = being part of the URL that is causing the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 11593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11593&action=edit Bug 8621: Alternative template for cart email - uses less list elements, in favour of paragraphs and line breaks - reimplements a link to the opac for each record Note: In order for the URLs to be correct this needs to be tested together with the patch for bug 8626. To test: - Add several records to the cart, add items with and without items - Send yourself the cart as email and check formatting - Update po files for any language, translate the po file for OPAC and install language - Send yourself the cart email again from the translated templates, check formatting -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, first patch only fixes a problem in the existing template, second patch is an alternative and should not be applied on top of the first, but separately. Looking for sign-offs and feedback :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11562|0 |1 is obsolete| | Attachment #11593|0 |1 is obsolete| | --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11609&action=edit Bug 8621: Alternative template for cart email - uses less list elements, in favour of paragraphs and line breaks - reimplements a link to the opac for each record Note: In order for the URLs to be correct this needs to be tested together with the patch for bug 8626. To test: - Add several records to the cart, add items with and without items - Send yourself the cart as email and check formatting - Update po files for any language, translate the po file for OPAC and install language - Send yourself the cart email again from the translated templates, check formatting Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #8 from Ian Walls <koha.sekjal@gmail.com> --- Template only change, fixing indenting and other issues. Easy to read, passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed, some comments: * I couldn't check that the mail is OK, because my test installation does not send email. So trusting signoff. * Can't decide if it's an ENH or a bugfix. Not switching to ENH, and letting RMaint decide * Katrin, shouldn't we do the same think on staff basket sending as well (modules/basket/sendbasket.tt) ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Paul, both staff cart and sending lists need more work, but I haven't had time to replicate the recent changes to the cart email templates to the lists and staff interface. Happy if somemone beats me to it (see bug 8062) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org