[Bug 21020] New: Return branch not set for transfer when using SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Bug ID: 21020 Summary: Return branch not set for transfer when using SIP Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Bug 17680 replace GetItemIssue with a call to the Issue object - the code in /C4/SIP/ILS/Transaction/Checkin.pm expects item information I think line 97: $self->{item}->destination_loc($iteminformation->{homebranch}); Should be: $self->{item}->destination_loc($iteminformation->item->homebranch); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17680 CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76563&action=edit Bug 21020: Fix return branch on transfer - SIP Caused by commit 546379cc92b733cb29a0b70247a72c770afdad26 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls Since this commit AddReturn return a Koha::Issue object, not a hashref with item's info. Test plan: ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Jonathan, shouldn't "$issue->issue->homebranch" be "$issue->item->homebranch"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76563|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76570&action=edit Bug 21020: Fix return branch on transfer - SIP Caused by commit 546379cc92b733cb29a0b70247a72c770afdad26 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls Since this commit AddReturn return a Koha::Issue object, not a hashref with item's info. Test plan: ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #2)
Jonathan, shouldn't "$issue->issue->homebranch" be "$issue->item->homebranch"?
Whoops, yes of course! Thanks for catching that :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76570|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76574&action=edit Bug 21020: Fix return branch on transfer - SIP Caused by commit 546379cc92b733cb29a0b70247a72c770afdad26 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls Since this commit AddReturn return a Koha::Issue object, not a hashref with item's info. Test plan: 1 - Enable SIP server on your test instance For kohadevbox: cp /etc/koha/SIPConfig.xml /etc/koha/sites/kohadev/ create patron with user/pass term1/term1 and grant circulation privileges 2 - enable AutomaticItemReturn 3 - Checkin an item which will generate a transfer via SIP2: perl /home/vagrant/kohaclone/misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l LPL --item {BARCODE} -m checkin -t CR 4 - Note no CT field 5 - Apply patch 6 - Repeate checkin via SIP2 7 - Transfer destination is correctly returned in CT Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76574|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76716&action=edit Bug 21020: Fix return branch on transfer - SIP Caused by commit 546379cc92b733cb29a0b70247a72c770afdad26 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls Since this commit AddReturn return a Koha::Issue object, not a hashref with item's info. Test plan: 1 - Enable SIP server on your test instance For kohadevbox: cp /etc/koha/SIPConfig.xml /etc/koha/sites/kohadev/ create patron with user/pass term1/term1 and grant circulation privileges 2 - enable AutomaticItemReturn 3 - Checkin an item which will generate a transfer via SIP2: perl /home/vagrant/kohaclone/misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l LPL --item {BARCODE} -m checkin -t CR 4 - Note no CT field 5 - Apply patch 6 - Repeate checkin via SIP2 7 - Transfer destination is correctly returned in CT Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |17680 Blocks|17680 | --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.08 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 17680 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27196 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org