[Bug 23852] New: Merge biblio-title.inc and biblio-default-view.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Bug ID: 23852 Summary: Merge biblio-title.inc and biblio-default-view.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The functionality in biblio-default-view.inc should be moved into biblio-title.inc. A "link" parameter will be set when the include file should show a linked title. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23841 [Bug 23841] Add link to bibliographic details page in item details breadcrumbs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94455&action=edit Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94455|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 98770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98770&action=edit Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Hi Owen. Just checking on this one before I sign it off. There are several areas where, while they reflect current behaviour, are inconsistent. I'm assuming this bug is 'like for like' and that any corrections to address inconsistencies should be a separate bug. Examples include: - Home › Circulation › Checkouts <-- Checkouts is in bold, should possibly be Check out (to match with other buttons and labels) - Home › Circulation › Checkouts › [Patron name (ID)] <-- should possibly be Check out rather than Checkouts (after putting in a patron) - For several items the last part of the breadcrumb is linked: . Home › Circulation › Article requests . Home › Circulation › Holds queue . Home › Circulation › Holds awaiting pickup . Home › Circulation › Set library . Home › Tools › Batch record deletion - Other things noticed: . Home › Circulation › Transfers <-- Button on the circulation page is Transfer, although it does have a group heading Transfers . Home › Circulation › Overdues at [Library name] <-- For Overdues with fines, should this display as Overdues with fines at [Library name] instead? Notes for myself from testing - enable these system preferences: - StockRotation (enable) - ArticleRequests (enable) - BatchCheckouts (allow) + BatchCheckoutsValidCategories (add patron categories) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Klas Blomberg <klas.blomberg@skovde.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |klas.blomberg@skovde.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98770|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106879&action=edit Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind <david@davidnind.com> --- Patch no longer applies 8-( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106879|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109687&action=edit Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109687|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 109702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109702&action=edit Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, with the patch applied the title of a record in the result list suddenly appears italic, is this intentional? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 110055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110055&action=edit Bug 23852: (QA follow-up) Correct scope of breadcrumb title style This patch corrects the scope of the ".title" style intended for titles displayed in the breadcrumbs bar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109702|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110128&action=edit Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110055|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110129&action=edit Bug 23852: (QA follow-up) Correct scope of breadcrumb title style This patch corrects the scope of the ".title" style intended for titles displayed in the breadcrumbs bar. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Does no longer apply, please rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110128|0 |1 is obsolete| | Attachment #110129|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 111134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111134&action=edit Bug 23852: (QA follow-up) Correct scope of breadcrumb title style This patch corrects the scope of the ".title" style intended for titles displayed in the breadcrumbs bar. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111134|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 111135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111135&action=edit Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 111136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111136&action=edit Bug 23852: (QA follow-up) Correct scope of breadcrumb title style This patch corrects the scope of the ".title" style intended for titles displayed in the breadcrumbs bar. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111393&action=edit Bug 23852: (QA follow-up) Fix remaining call to biblio-default-view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #17)
Created attachment 111393 [details] [review] Bug 23852: (QA follow-up) Fix remaining call to biblio-default-view
This patch has ben pushed to master on Oct 9. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org