[Bug 18236] New: Add classes to material type icons on result lists and detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Bug ID: 18236 Summary: Add classes to material type icons on result lists and detail pages Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Some libraries would prefer to show different material type icons in the result lists and detail pages in OPAC in staff. In order to make this possible with CSS, it would be nice if every icon had its own specific class so it's easy to target them. Something like: mt_icon_book, mt_icon_film, mt_icon_... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 jwayway@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 --- Comment #1 from jwayway@hotmail.com --- Created attachment 70570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70570&action=edit Bug-18236: Add classes to material type Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_book -Kit = m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 jwayway@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70570|Bug-18236: Add classes to |Bug-18236: Add classes to description|material type Test plan: 1. |material type |Open a list of results 2. |Test plan: |Use fn+f12 to inspect |1. Open a list of results |element 3. Without patch it |2. Use fn+f12 to inspect |should show that the image |element |class is 'materialtype' 4. |3. Without patch |With patch the class should |it should show that the |have changed -Books = |image class is |mt_icon_book -Kit = m |'materialtype' | |4. With | |patch the class should have | |changed | |-Books = | |mt_icon_book | |-Kit = | |mt_icon_kit | |-Continuous | |resource = | |mt_icon_cresource | |-Mixed | |material = mixmaterial | |-Computer files = | | | |mt_icon_computer | |-Map = | |mt_icon_map | |-Score = | |mt_icon_score | |-Music = | |mt_icon_music | |OR | |1. Try | |using the classes in css to | |change the style -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 jwayway@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70570|0 |1 is obsolete| | --- Comment #2 from jwayway@hotmail.com --- Created attachment 70571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70571&action=edit Bug-18236: Add classes to material type Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_book -Kit = mt_icon_kit -Continuous resource = mt_icon_cresource -Mixed material = mixmaterial -Computer files = mt_icon_computer -Map = mt_icon_map -Score = mt_icon_score -Music = mt_icon_music OR 1. Try using the classes in css to change the style Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_bo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 jwayway@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwayway@hotmail.com --- Comment #3 from jwayway@hotmail.com --- Bug-18236: Add classes to material type Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_book -Kit = mt_icon_kit -Continuous resource = mt_icon_cresource -Mixed material = mixmaterial -Computer files = mt_icon_computer -Map = mt_icon_map -Score = mt_icon_score -Music = mt_icon_music OR 1. Try using the classes in css to change the style My commit message stuffed up so please use this test plan :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- This looks great, but can I ask for more? It would be helpful if the icons kept the "materialtype" class along with the new class: <img src="/intranet-tmpl/prog/img/famfamfam/silk/book.png" alt="book" title="book" class="materialtype mt_icon_book"/> That would let us define common styles for all material type icons in addition to specific ones for specific types. Also: Could you include changes to MARC21slim2intranetDetail.xsl too? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 jwayway@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 jwayway@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70571|0 |1 is obsolete| | --- Comment #5 from jwayway@hotmail.com --- Created attachment 70653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70653&action=edit Bug-18236: Add classes to material type Test plan: -Following the test plan above, the class should still have 'materialtype' but also the new class: Books = mt_icon_BK Kit = mt_icon_MX Article = mt_icon_AR Mixed material = mt_icon_MX Computer files = mt_icon_CF Map = mt_icon_MP Music = mt_icon_MU Sound = mt_icon_MU Score = mt_icon_PR Visual material = mt_icon_VM -When viewing the details of a record, the material type img should also have the same changes -Check that the material type classes in the results page is the same as the details page Notes -The class names have changed from the previous patch in accordance to $materialTypeCode in MARC21slim2intranetDetail.xsl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |claire_gravely@hotmail.com --- Comment #6 from Claire Gravely <claire_gravely@hotmail.com> --- Patch does not apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70571|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70571|0 |1 is obsolete| | Attachment #70653|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76149&action=edit Bug-18236: Add classes to material type Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_book -Kit = mt_icon_kit -Continuous resource = mt_icon_cresource -Mixed material = mixmaterial -Computer files = mt_icon_computer -Map = mt_icon_map -Score = mt_icon_score -Music = mt_icon_music OR 1. Try using the classes in css to change the style Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76150&action=edit Bug-18236: Add classes to material type Test plan: -Following the test plan above, the class should still have 'materialtype' but also the new class: Books = mt_icon_BK Kit = mt_icon_MX Article = mt_icon_AR Mixed material = mt_icon_MX Computer files = mt_icon_CF Map = mt_icon_MP Music = mt_icon_MU Sound = mt_icon_MU Score = mt_icon_PR Visual material = mt_icon_VM -When viewing the details of a record, the material type img should also have the same changes -Check that the material type classes in the results page is the same as the details page Notes -The class names have changed from the previous patch in accordance to $materialTypeCode in MARC21slim2intranetDetail.xsl Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jwayway@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add classes to material |Add classes to material |type icons on result lists |type icons on intranet |and detail pages |result lists and detail | |pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add classes to material |MARC21: Add classes to |type icons on intranet |material type icons on |result lists and detail |intranet result lists and |pages |detail pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76149|0 |1 is obsolete| | Attachment #76150|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77375&action=edit Bug 18236: MARC21 - Add classes to material type on intranet detail and results pages Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch there will be an additional class -Books = mt_icon_BK -Kit = mt_icon_MX -Article = mt_icon_AR -Continuous resource = mt_icon_CR -Mixed material = mt_icon_MX -Computer files = mt_icon_CF -Map = mt_icon_MP -Music = mt_icon_MU -Sound = mt_icon_MU -Score = mt_icon_PR -Visual material = mt_icon_VM OR 1. Try using the classes in css to change the style -When viewing the details of a record, the material type img should also have the same changes -Check that the material type classes in the results page is the same as the details page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I've squashed the patches to make chanes easier readable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It would be great if someone could include those changes in the OPAC as well, I've filed bug 21138. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org