[Bug 39934] New: Standard backend shows attributes from previously "migrated from" backends
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Bug ID: 39934 Summary: Standard backend shows attributes from previously "migrated from" backends Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: pedro.amorim@openfifth.co.uk Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: pedro.amorim@openfifth.co.uk, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182581&action=edit Bug 39934: Only fetch attributes from 'Standard' Furthermore, this now only shows metadata present in _get_core_fields, so a list of attributes to ignore is not longer needed (they're not in _get_core_fields). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182582&action=edit Bug 39934: Use _get_core_fields as fields to be migrated Instead of ignoring from an arbitrary list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182583&action=edit Bug 39934: Add tests prove t/db_dependent/Koha/ILL/Backend/Standard.t Test plan, k-t-d, don't apply patches yet: 1) Enable ILLModule sys pref 2) Install an additional backend, e.g. ReprintsDesk: https://github.com/openfifth/koha-ill-reprintsdesk/releases/tag/v3.0.2 3) Restart plack $ koha-plack --restart kohadev 4) Create a new ReprintsDesk request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=ReprintsDesk 5) Enter DOI: '123', EISSN: 'abc', a cardnumber '42' and a library. Click 'Make request' 6) Click 'Switch provider'. Pick 'Standard'. 7) Notice 'Eissn' shows. This is confusing as it means nothing in the 'Standard' context. 'Migrated from' is also shown and is equally as confusing for staff members (This is a remnant of previous behavior when migrating a request would create a new request). 8) Apply patches. Repeat test plan. The attributes from the previous backend still exist in the database, but the UI now only shows attributes relevant to the current backend of the request. To confirm this, run: $ koha-mysql kohadev $ select * from illrequestattributes; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38341 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Hi @Tomas. Patch still applies for me on current main, can you please double-check? Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com, | |katrin.fischer@bsz-bw.de, | |lisette@bywatersolutions.co | |m, | |martin.renvoize@openfifth.c | |o.uk --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Adding others here if anyone fancies testing as it's been on 'Needs Sign-off' for 4 months now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from David Nind <david@davidnind.com> --- The patches no longer apply 8-(... git bz apply 39934 Bug 39934 - Standard backend shows attributes from previously "migrated from" backends 182581 - Bug 39934: Only fetch attributes from 'Standard' 182582 - Bug 39934: Use _get_core_fields as fields to be migrated 182583 - Bug 39934: Add tests Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 39934: Only fetch attributes from 'Standard' Using index info to reconstruct a base tree... M Koha/ILL/Backend/Standard.pm Falling back to patching base and 3-way merge... Auto-merging Koha/ILL/Backend/Standard.pm CONFLICT (content): Merge conflict in Koha/ILL/Backend/Standard.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 39934: Only fetch attributes from 'Standard' Testing notes (using KTD): 1. For step 2, I downloaded the 3.0.2 version of the plugin (if I searched for it, v2.0.5 was the only result, I didn't use the latest as that required applying naother bug). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182581|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 190887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190887&action=edit Bug 39934: Only fetch attributes from 'Standard' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182582|0 |1 is obsolete| | --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 190888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190888&action=edit Bug 39934: Use _get_core_fields as fields to be migrated Also add backend check to add_or_update_attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182583|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 190889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190889&action=edit Bug 39934: Add tests prove t/db_dependent/Koha/ILL/Backend/Standard.t Test plan, k-t-d, don't apply patches yet: 1) Enable ILLModule sys pref 2) Install an additional backend, e.g. ReprintsDesk: https://github.com/openfifth/koha-ill-reprintsdesk/releases/tag/v4.0.3 3) Restart plack $ koha-plack --restart kohadev 4) Create a new ReprintsDesk request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=ReprintsDesk 5) Enter DOI: '123', 'First page of article in journal': 'abc', a cardnumber '42' and a library. Click 'Make request' 6) Click 'Switch provider'. Pick 'Standard'. 7) Notice 'First page of article in journal' shows. This is confusing as it means nothing in the 'Standard' context. 8) Apply patches. Repeat test plan. The attributes from the previous backend still exist in the database, but the UI now only shows attributes relevant to the current backend of the request. To confirm this, run: $ koha-mysql kohadev $ select * from illrequestattributes; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190887|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 190908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190908&action=edit Bug 39934: Only fetch attributes from 'Standard' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190888|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 190909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190909&action=edit Bug 39934: Use _get_core_fields as fields to be migrated Also add backend check to add_or_update_attributes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190889|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 190910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190910&action=edit Bug 39934: Add tests prove t/db_dependent/Koha/ILL/Backend/Standard.t Test plan, k-t-d, don't apply patches yet: 1) Enable ILLModule sys pref 2) Install an additional backend, e.g. ReprintsDesk: https://github.com/openfifth/koha-ill-reprintsdesk/releases/tag/v4.0.3 3) Restart plack $ koha-plack --restart kohadev 4) Create a new ReprintsDesk request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=ReprintsDesk 5) Enter DOI: '123', 'First page of article in journal': 'abc', a cardnumber '42' and a library. Click 'Make request' 6) Click 'Switch provider'. Pick 'Standard'. 7) Notice 'First page of article in journal' shows. This is confusing as it means nothing in the 'Standard' context. 8) Apply patches. Repeat test plan. The attributes from the previous backend still exist in the database, but the UI now only shows attributes relevant to the current backend of the request. To confirm this, run: $ koha-mysql kohadev $ select * from illrequestattributes; Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190908|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193630&action=edit Bug 39934: Only fetch attributes from 'Standard' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190909|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193631&action=edit Bug 39934: Use _get_core_fields as fields to be migrated Also add backend check to add_or_update_attributes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190910|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193632&action=edit Bug 39934: Add tests prove t/db_dependent/Koha/ILL/Backend/Standard.t Test plan, k-t-d, don't apply patches yet: 1) Enable ILLModule sys pref 2) Install an additional backend, e.g. ReprintsDesk: https://github.com/openfifth/koha-ill-reprintsdesk/releases/tag/v4.0.3 3) Restart plack $ koha-plack --restart kohadev 4) Create a new ReprintsDesk request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=ReprintsDesk 5) Enter DOI: '123', 'First page of article in journal': 'abc', a cardnumber '42' and a library. Click 'Make request' 6) Click 'Switch provider'. Pick 'Standard'. 7) Notice 'First page of article in journal' shows. This is confusing as it means nothing in the 'Standard' context. 8) Apply patches. Repeat test plan. The attributes from the previous backend still exist in the database, but the UI now only shows attributes relevant to the current backend of the request. To confirm this, run: $ koha-mysql kohadev $ select * from illrequestattributes; Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39934 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This mostly works, but my request still has a "PubMed ID" once I've converted it to the standard backend. It did correctly drop the "First page of article in journal" and "Last page of article in journal" fields. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org