https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18689 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 63957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63957&action=edit Bug 16976: Authorities searches with double quotes gives ZOOM error 20003 To recreate: Go to Home > Authorities Search "test" (including double quotes Result: Internal server error, plack error log says: ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 7=1 @attr 1=Heading 0 @attr 1=Heading-Main @attr 5=1 @attr 4=6 "\\"test\\""") from diag-set 'ZOOM' To test: - Appply patch, restart memchached an dplack - Repeat search "test" - Verify that there is no internal server error - Add an authority containing quotes, e.g. Johann "Wolfie" Goethe - Search after Wolfie (without quotes) - Verify that authority ist found - Search after "Wolfie" - Verify that authority is found - Verify that other searches for authorities behave as before Technical note: Escaping did not work. The patch simply removes double quotes from search values. Not sure if that is the ultimate solution, but it works. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63957|0 |1 is obsolete| | --- Comment #3 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 63963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63963&action=edit Bug 16976: Authorities searches with double quotes gives ZOOM error 20003 To recreate: Go to Home > Authorities Search "test" (including double quotes Result: Internal server error, plack error log says: ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 7=1 @attr 1=Heading 0 @attr 1=Heading-Main @attr 5=1 @attr 4=6 "\\"test\\""") from diag-set 'ZOOM' To test: - Appply patch, restart memchached an dplack - Repeat search "test" - Verify that there is no internal server error - Add an authority containing quotes, e.g. Johann "Wolfie" Goethe - Search after Wolfie (without quotes) - Verify that authority ist found - Search after "Wolfie" - Verify that authority is found - Verify that other searches for authorities behave as before Technical note: Escaping did not work. The patch simply removes double quotes from search values. Not sure if that is the ultimate solution, but it works. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63963|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64382&action=edit Bug 16976 - Authorities searches with double quotes gives ZOOM error 20003 [Alternate] I dug into this a little bit, it seems the issue is that we were double processing the query because of an extra call to C4::AuthoritiesMarc::SearchAuthorities I think we can simply remove this call To test: 1 - Perform an authority search for a value that returns results 2 - Wrap it in quotes and search 3 - 'Internal server error' 4 - Apply patch 5 - Search with quotes succeeds https://bugs.koha-community.org/show_bug.cgi?id=16796 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64382|0 |1 is obsolete| | --- Comment #5 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64384&action=edit Bug 16976 - Authorities searches with double quotes gives ZOOM error 20003 [Alternate] I dug into this a little bit, it seems the issue is that we were double processing the query because of an extra call to C4::AuthoritiesMarc::SearchAuthorities I think we can simply remove this call To test: 1 - Perform an authority search for a value that returns results 2 - Wrap it in quotes and search 3 - 'Internal server error' 4 - Apply patch 5 - Search with quotes succeeds https://bugs.koha-community.org/show_bug.cgi?id=16796 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> When testing in kohadevbox a restart_all is required -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64384|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 64655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64655&action=edit Bug 16976 - Authorities searches with double quotes gives ZOOM error 20003 [Alternate] I dug into this a little bit, it seems the issue is that we were double processing the query because of an extra call to C4::AuthoritiesMarc::SearchAuthorities I think we can simply remove this call To test: 1 - Perform an authority search for a value that returns results 2 - Wrap it in quotes and search 3 - 'Internal server error' 4 - Apply patch 5 - Search with quotes succeeds https://bugs.koha-community.org/show_bug.cgi?id=16796 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|veron@veron.ch |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64923&action=edit Bug 16976 - Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64998|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64999&action=edit Bug 16976 - Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Nick Clemens from comment #10)

Created attachment 64999 [details] [review] Bug 16976 - Unit tests

Nick, please comment on which bug this one depends (for the tests) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #12)

Nick, please comment on which bug this one depends (for the tests)

Ah, sorry about that - accidentally obsoleted an extra patch, this depended on itself :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65901|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65903&action=edit Bug 16976 - Unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65903|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65905&action=edit Bug 16976 - Unit tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65904|0 |1 is obsolete| | Attachment #65905|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66017&action=edit [SIGNED OFF] Bug 16976 - Authorities searches with double quotes gives ZOOM error 20003 [Alternate] I dug into this a little bit, it seems the issue is that we were double processing the query because of an extra call to C4::AuthoritiesMarc::SearchAuthorities I think we can simply remove this call To test: 1 - Perform an authority search for a value that returns results 2 - Wrap it in quotes and search 3 - 'Internal server error' 4 - Apply patch 5 - Search with quotes succeeds https://bugs.koha-community.org/show_bug.cgi?id=16796 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #22 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.04 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Depends on| |10407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 [Bug 10407] Allow MARCXML records to be imported with Tools/Stage MARC records for import -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- CC| |marjorie.barry-vila@collect | |o.ca Status|RESOLVED |REOPENED --- Comment #25 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- Hi, In 17.05, i have same error message on koha/tools/manage-marc-import.pl Software error: ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 7=1 @attr 4=109 @attr 1=Local-Number 0 @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "F298826" @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "(SQTD)191897"") from diag-set 'ZOOM' I understand that patch is just for search on authorities/authorities-home.pl ? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20596 -- You are receiving this mail because: You are watching all bug changes.