[Bug 35795] New: Missing closing tag in OPAC course details template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35795 Bug ID: 35795 Summary: Missing closing tag in OPAC course details template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 34855 There is a missing </em> in the breadcrumbs of the OPAC course details template. This causes all the following markup to be styled in italics. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34855 [Bug 34855] Use template wrapper for breadcrumbs: OPAC part 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35795 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35795 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160989&action=edit Bug 35795: Missing closing tag in OPAC course details template This patch adds a missing closing tag, "</em>" to the breadcrumb navigation shown when viewing the detail page of a course. To test you must have at least one course created in the course reserves module (Course reserves -> New course) - Apply the patch and go to the OPAC. - Open the Course reserves page and click the name of the course you created. - The last item in the breadcrumb menu should be "Course reserves for [your course name]" and "you_course_name" should be in italics. - The rest of the page should look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35795 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35795 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160989|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 160991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160991&action=edit Bug 35795: Missing closing tag in OPAC course details template This patch adds a missing closing tag, "</em>" to the breadcrumb navigation shown when viewing the detail page of a course. To test you must have at least one course created in the course reserves module (Course reserves -> New course) - Apply the patch and go to the OPAC. - Open the Course reserves page and click the name of the course you created. - The last item in the breadcrumb menu should be "Course reserves for [your course name]" and "you_course_name" should be in italics. - The rest of the page should look correct. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35795 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35795 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160991|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 161203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161203&action=edit Bug 35795: Missing closing tag in OPAC course details template This patch adds a missing closing tag, "</em>" to the breadcrumb navigation shown when viewing the detail page of a course. To test you must have at least one course created in the course reserves module (Course reserves -> New course) - Apply the patch and go to the OPAC. - Open the Course reserves page and click the name of the course you created. - The last item in the breadcrumb menu should be "Course reserves for [your course name]" and "you_course_name" should be in italics. - The rest of the page should look correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35795 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35795 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35795 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.03 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35795 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org