https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37461 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36051 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I also wonder if it should be it's own syspref rather than one of four in the same sentence? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051 [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37461 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 169514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169514&action=edit Bug 37461: Typo in SMSSendAdditionalOptions description This patch correct a typo in the SMSSendAdditionalOptions system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for SMSSendAdditionalOptions 4. Read the description, make sure there are no spelling or grammar error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37461 Bug 37461 depends on bug 36051, which changed state. Bug 36051 Summary: Add option to specify SMS::Send driver parameters in a system preference instead of a file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37461 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #3 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- After applying the patch in a sandbox I am seeing no change. There are no quotes around the words "enter them here". Also there is a typo in the sentence - it reads as follows: If the SMS::Send driver requires more options that just username/login and password: The word 'that' should be 'than' so that it reads 'more options than' Like this: If the SMS::Send driver requires more options than just username/login and password: -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37461 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169514|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 169592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169592&action=edit Bug 37461: Typo in SMSSendAdditionalOptions description -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37461 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi Barbara, Thanks for testing. I hadn't seen the other typo (that -> than). As for the "enter them here", I didn't mean that the words should be between quotes but that "entire" should be "enter". I corrected both in the new patch and set back to Needs Signoff. Caroline -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37461 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169593|0 |1 is obsolete| | --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 169595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169595&action=edit Bug 37461: Typo in SMSSendAdditionalOptions description This patch correct a typo in the SMSSendAdditionalOptions system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for SMSSendAdditionalOptions 4. Read the description, make sure there are no spelling or grammar error Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37461 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169595|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 169993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169993&action=edit Bug 37461: Typo in SMSSendAdditionalOptions description This patch correct a typo in the SMSSendAdditionalOptions system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for SMSSendAdditionalOptions 4. Read the description, make sure there are no spelling or grammar error Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37461 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, Sandbox | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37461 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37461 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 36051 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.