[Bug 13487] New: DataTables pagination needs some fixes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Bug ID: 13487 Summary: DataTables pagination needs some fixes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org On acqui/basketgroup.pl and catalogue/itemsearch.pl, the sPaginationType DT parameter is not explicitly defined. This broken the pagination display. Moreover, since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST"). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |11425, 12986 Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34626&action=edit Bug 13487: DT pagination contains '...' for the full_numbers form Since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST"). Test plan: 1/ Go on the member search and launch a search which will return more than 7 pages 2/ Without this patch, the '...' span is put at the end of the pagination bar. 3/ With the patch it should be better placed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34627&action=edit Bug 13487: Fix pagination for basketgroup Test plan: Go on the acqui/basketgroup.pl page and verify that the pagination button (First, Prev, Next, Last) is now correctly styled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34628&action=edit Bug 13487: Fix pagination for the item search Test plan: Go on the catalogue/itemsearch.pl page and verify that the pagination button (First, Prev, PAGES, Next, Last) is now correctly styled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #1)
Created attachment 34626 [details] [review] Bug 13487: DT pagination contains '...' for the full_numbers form
This is certainly not the best way to fix that. Feel free to suggest something else. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Let me know if you found other pagination problems. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34626|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34683&action=edit Bug 13487: DT pagination contains '...' for the full_numbers form Since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST"). Test plan: 1/ Go on the member search and launch a search which will return more than 7 pages 2/ Without this patch, the '...' span is put at the end of the pagination bar. 3/ With the patch it should be better placed. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34627|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34684&action=edit Bug 13487: Fix pagination for basketgroup Test plan: Go on the acqui/basketgroup.pl page and verify that the pagination button (First, Prev, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34628|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34685&action=edit Bug 13487: Fix pagination for the item search Test plan: Go on the catalogue/itemsearch.pl page and verify that the pagination button (First, Prev, PAGES, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13459 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34703&action=edit [PASSED QA] Bug 13487: DT pagination contains '...' for the full_numbers form Since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST"). Test plan: 1/ Go on the member search and launch a search which will return more than 7 pages 2/ Without this patch, the '...' span is put at the end of the pagination bar. 3/ With the patch it should be better placed. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34704&action=edit [PASSED QA] Bug 13487: Fix pagination for basketgroup Test plan: Go on the acqui/basketgroup.pl page and verify that the pagination button (First, Prev, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34705&action=edit [PASSED QA] Bug 13487: Fix pagination for the item search Test plan: Go on the catalogue/itemsearch.pl page and verify that the pagination button (First, Prev, PAGES, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34683|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34684|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34685|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13744 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11708 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12985 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org