[Bug 38777] New: HOLD letter should use the reply to of the branch that hold is waiting at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 Bug ID: 38777 Summary: HOLD letter should use the reply to of the branch that hold is waiting at Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When sending a notice of a hold ready for pickup (not digest) we use the library where the hold is at. We should also use this when setting the reply to. To test: 1 - Set the email/replyto for a patron's library to be: patron@example.com 2 - Set the email/replyto for another branch to be: holdbranch@example.com 3 - Place a hold for the patron for pickup at the other branch 4 - Check in and set hold waiting 5 - SELECT * FROM message_queue 6 - Note the message is from the hold branch, but has a null replyto This means we will use patron branch when sending -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 175913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175913&action=edit Bug 38777: Use branch reply to for HOLD messages When sending a notice of a hold ready for pickup (not digest) we use the library where the hold is at. We should also use this when setting the reply to. To test: 1 - Set the email/replyto for a patron's library to be: patron@example.com 2 - Set the email/replyto for another branch to be: holdbranch@example.com 3 - Place a hold for the patron for pickup at the other branch 4 - Check in and set hold waiting 5 - SELECT * FROM message_queue 6 - Note the message is from the hold branch, but has a null replyto This means we will use patron branch when sending 7 - Apply patch 8 - Revert hold waiting status 9 - Checkin and confirm hold again 10 -Check message queue 11 - Hold now has reply address of branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175913|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 175921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175921&action=edit Bug 38777: Use branch reply to for HOLD messages When sending a notice of a hold ready for pickup (not digest) we use the library where the hold is at. We should also use this when setting the reply to. To test: 1 - Set the email/replyto for a patron's library to be: patron@example.com 2 - Set the email/replyto for another branch to be: holdbranch@example.com 3 - Place a hold for the patron for pickup at the other branch 4 - Check in and set hold waiting 5 - SELECT * FROM message_queue 6 - Note the message is from the hold branch, but has a null replyto This means we will use patron branch when sending 7 - Apply patch 8 - Revert hold waiting status 9 - Checkin and confirm hold again 10 -Check message queue 11 - Hold now has reply address of branch Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|HOLD letter should use the |HOLD letter should use the |reply to of the branch that |reply to of the library |hold is waiting at |that hold is waiting at -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175921|0 |1 is obsolete| | --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 176054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176054&action=edit Bug 38777: Use branch reply to for HOLD messages When sending a notice of a hold ready for pickup (not digest) we use the library where the hold is at. We should also use this when setting the reply to. To test: 1 - Set the email/replyto for a patron's library to be: patron@example.com 2 - Set the email/replyto for another branch to be: holdbranch@example.com 3 - Place a hold for the patron for pickup at the other branch 4 - Check in and set hold waiting 5 - SELECT * FROM message_queue 6 - Note the message is from the hold branch, but has a null replyto This means we will use patron branch when sending 7 - Apply patch 8 - Revert hold waiting status 9 - Checkin and confirm hold again 10 -Check message queue 11 - Hold now has reply address of branch Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Works as expected, Qa tools passes, changes makes sense and is proven by appropriate test, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Text to go in the| |This updates the HOLD release notes| |letter to use the reply to | |email address of the | |library the hold is waiting | |at instead of the patron | |library to ensure replies | |go to the correct branch | |for the hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38777 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org